From: Florian Westphal <fw@strlen.de>
To: Fernando Fernandez Mancera <ffmancera@riseup.net>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 1/2 nf-next] netfilter: nf_tables: Introduce stateful object update operation
Date: Wed, 21 Aug 2019 13:11:05 +0200 [thread overview]
Message-ID: <20190821111105.GA13057@breakpoint.cc> (raw)
In-Reply-To: <17f338ec-fe44-3ba7-3115-4b5f16d93ccf@riseup.net>
Fernando Fernandez Mancera <ffmancera@riseup.net> wrote:
> How is that argument going to be used? If 'commit' is false we should
> just check that values are fine but not update them?
Yes, thats the idea.
> Yes, I agree on updating the object in the commit phase. But I am not
> sure about how I should place it on 'trans'. Any hints? Thanks :-)
Can you place a pointer to the tb array on the trans object?
Another possibility is to have ->update return a kmalloced blob
that contains ready-to-use binary data, so depending on the 'bool
commit' the update hook would expect either tb[] (for validation)
or a backend-maintained struct with the to-update values.
In the quota case it would be a struct containing the u64 values.
> I am also writing some userspace shell tests.
Thats good, thanks Fernando!
next prev parent reply other threads:[~2019-08-21 11:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 9:44 [PATCH 1/2 nf-next] netfilter: nf_tables: Introduce stateful object update operation Fernando Fernandez Mancera
2019-08-21 9:44 ` [PATCH 2/2 nf-next] netfilter: nft_quota: add quota object update support Fernando Fernandez Mancera
2019-08-21 10:09 ` [PATCH 1/2 nf-next] netfilter: nf_tables: Introduce stateful object update operation Florian Westphal
2019-08-21 11:01 ` Fernando Fernandez Mancera
2019-08-21 11:11 ` Florian Westphal [this message]
2019-08-21 11:14 ` Fernando Fernandez Mancera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821111105.GA13057@breakpoint.cc \
--to=fw@strlen.de \
--cc=ffmancera@riseup.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.