From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90673C3A59E for ; Wed, 21 Aug 2019 12:39:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 62A312341F for ; Wed, 21 Aug 2019 12:39:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AfmcH0Qb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="TupyVj17" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62A312341F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Gv21qyT/8egkVJl2vE7bh3YhXO0ikzWwAmpRMtEoyxs=; b=AfmcH0QbkwRW44 dnmpB/6hMaaF0d6dFJkKOeUT6+DNUx+UOQK4WaCZRvAMsESU5sDvZscMaw4XvP7gt3z6/y/dtTPA5 yJEq3Uc3VXPEEIpeoMJwEWq2/KRHieQy0sZtDLWCPORKDb0HVamZK4McqZoFjf04CvEEPZWfZjvn3 UqQs2cdZpFVRs06sMr1mSOwMUrZnc2/78izLd1J+GXjIFQxaLUlZBKyl6lStkQWR7DSmikf8au3wz 4aj5/DqhQNa5KlYphodlfOUnNzmKtMnc646tcz1rjsot6iCK4CycMIA7A3RbYXGayyvQBqzJwuElo o56+FfoyzEjU0gKpdM4w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i0Ptp-0005BH-5K; Wed, 21 Aug 2019 12:39:37 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i0Ptm-0005Aa-Q8; Wed, 21 Aug 2019 12:39:36 +0000 Received: from localhost (unknown [12.166.174.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 81D002341E; Wed, 21 Aug 2019 12:39:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566391173; bh=9bKz63tfFMpFQqEEIloPUowFJ5JwR4y30ptvJscL/Iw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TupyVj17ES+TfT+ew5wxVn8/RoB+TY3kzi7v4OUpPABmXN54r5OmVi6tbiKQX/bZY 5gCzoLUZziA2oHRwBivvPBaJ3vxbNxMmuKTqKq08ygNvwKx22cXMo1ObY0kyFKURpq clArw0ZdRLuq6XCWIqAV2EpnFRwl4GNUZtxnjD1Y= Date: Wed, 21 Aug 2019 05:39:33 -0700 From: Greg KH To: Matthias Maennich Subject: Re: [PATCH v3 11/11] RFC: watchdog: export core symbols in WATCHDOG_CORE namespace Message-ID: <20190821123933.GC4059@kroah.com> References: <20190813121733.52480-1-maennich@google.com> <20190821114955.12788-1-maennich@google.com> <20190821114955.12788-12-maennich@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190821114955.12788-12-maennich@google.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190821_053934_890404_35624912 X-CRM114-Status: GOOD ( 19.34 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomer Maimon , lucas.de.marchi@gmail.com, linux-stm32@st-md-mailman.stormreply.com, linux-arch@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Kevin Hilman , Michal Simek , Ludovic Desroches , mingo@redhat.com, geert@linux-m68k.org, NXP Linux Team , Tomas Winkler , Guenter Roeck , Jean Delvare , Sascha Hauer , tglx@linutronix.de, michal.lkml@markovi.net, Scott Branden , Andrew Jeffery , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team , Alexandre Belloni , linux-aspeed@lists.ozlabs.org, yamada.masahiro@socionext.com, Thierry Reding , Alexandre Torgue , Chunyan Zhang , Jonathan Hunter , Kukjin Kim , kernel-team@android.com, sspatil@google.com, linux-watchdog@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-arm-msm@vger.kernel.org, pombredanne@nexb.com, linux-m68k@lists.linux-m68k.org, linux-rpi-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, maco@android.com, linux-arm-kernel@lists.infradead.org, Barry Song , Johannes Thumshirn , oneukum@suse.com, Patrice Chotard , Stefan Wahren , Maxime Coquelin , kstewart@linuxfoundation.org, usb-storage@lists.one-eyed-alien.net, linux-tegra@vger.kernel.org, patches@opensource.cirrus.com, joel@joelfernandes.org, sam@ravnborg.org, linux-rtc@vger.kernel.org, Florian Fainelli , Benjamin Fair , Eric Anholt , Krzysztof Kozlowski , Nancy Yuen , Chen-Yu Tsai , bcm-kernel-feedback-list@broadcom.com, Joel Stanley , stern@rowland.harvard.edu, arnd@arndb.de, Ray Jui , Vladimir Zapolskiy , Orson Zhai , linux-hwmon@vger.kernel.org, Support Opensource , Andreas Werner , Avi Fishman , maco@google.com, jeyu@kernel.org, Shawn Guo , Baruch Siach , Mans Rullgard , Maxime Ripard , Jerry Hoemann , Tali Perry , hpa@zytor.com, linux-scsi@vger.kernel.org, openbmc@lists.ozlabs.org, x86@kernel.org, Andy Gross , Marc Gonzalez , William Breathitt Gray , linux-mediatek@lists.infradead.org, Fabio Estevam , Matthias Brugger , Wim Van Sebroeck , Alessandro Zummo , Baolin Wang , Patrick Venture , Nicolas Ferre , linux-modules@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Wed, Aug 21, 2019 at 12:49:26PM +0100, Matthias Maennich wrote: > Modules using these symbols are required to explicitly import the > namespace. This patch was generated with the following steps and serves > as a reference to use the symbol namespace feature: > > 1) Use EXPORT_SYMBOL_NS* macros instead of EXPORT_SYMBOL* for symbols > in watchdog_core.c > 2) make (see warnings during modpost about missing imports) > 3) make nsdeps > > I used 'allmodconfig' for the above steps to ensure all occurrences are > patched. > > Defining DEFAULT_SYMBOL_NAMESPACE in the Makefile is not trivial in this > case as not only watchdog_core is defined in drivers/watchdog/Makefile. > Hence this patch uses the variant of using the EXPORT_SYMBOL_NS* macros > to export into a different namespace. > > An alternative to this patch would be a single definition line before > any use of EXPORT_SYMBOL*: > #define DEFAULT_SYMBOL_NAMESPACE WATCHDOG_CORE > > Signed-off-by: Matthias Maennich As we talked in chat, the cc: list for this patch was crazy :) If you end up resending this (as odds are the mailing lists will trash it for too many recipients), feel free to add: Reviewed-by: Greg Kroah-Hartman Great work, greg k-h _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Wed, 21 Aug 2019 05:39:33 -0700 Subject: [PATCH v3 11/11] RFC: watchdog: export core symbols in WATCHDOG_CORE namespace In-Reply-To: <20190821114955.12788-12-maennich@google.com> References: <20190813121733.52480-1-maennich@google.com> <20190821114955.12788-1-maennich@google.com> <20190821114955.12788-12-maennich@google.com> Message-ID: <20190821123933.GC4059@kroah.com> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Aug 21, 2019 at 12:49:26PM +0100, Matthias Maennich wrote: > Modules using these symbols are required to explicitly import the > namespace. This patch was generated with the following steps and serves > as a reference to use the symbol namespace feature: > > 1) Use EXPORT_SYMBOL_NS* macros instead of EXPORT_SYMBOL* for symbols > in watchdog_core.c > 2) make (see warnings during modpost about missing imports) > 3) make nsdeps > > I used 'allmodconfig' for the above steps to ensure all occurrences are > patched. > > Defining DEFAULT_SYMBOL_NAMESPACE in the Makefile is not trivial in this > case as not only watchdog_core is defined in drivers/watchdog/Makefile. > Hence this patch uses the variant of using the EXPORT_SYMBOL_NS* macros > to export into a different namespace. > > An alternative to this patch would be a single definition line before > any use of EXPORT_SYMBOL*: > #define DEFAULT_SYMBOL_NAMESPACE WATCHDOG_CORE > > Signed-off-by: Matthias Maennich As we talked in chat, the cc: list for this patch was crazy :) If you end up resending this (as odds are the mailing lists will trash it for too many recipients), feel free to add: Reviewed-by: Greg Kroah-Hartman Great work, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v3 11/11] RFC: watchdog: export core symbols in WATCHDOG_CORE namespace Date: Wed, 21 Aug 2019 05:39:33 -0700 Message-ID: <20190821123933.GC4059@kroah.com> References: <20190813121733.52480-1-maennich@google.com> <20190821114955.12788-1-maennich@google.com> <20190821114955.12788-12-maennich@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20190821114955.12788-12-maennich-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Matthias Maennich Cc: Tomer Maimon , lucas.de.marchi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-stm32-XDFAJ8BFU24N7RejjzZ/Li2xQDfSxrLKVpNB7YpNyf8@public.gmane.org, linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Kevin Hilman , Michal Simek , Ludovic Desroches , mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org, NXP Linux Team , Tomas Winkler , Guenter Roeck , Jean Delvare , Sascha Hauer , tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, michal.lkml-yyZNWGI4GtDR7s880joybQ@public.gmane.org, Scott Branden , Andrew Jeffery , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Pengutronix Kernel Team , Alexandre Belloni , linux-aspeed-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, yamada.masahiro-uWyLwvC0a2jby3iVrkZq2A@public.gmane.org, Thierry Reding List-Id: linux-arch.vger.kernel.org On Wed, Aug 21, 2019 at 12:49:26PM +0100, Matthias Maennich wrote: > Modules using these symbols are required to explicitly import the > namespace. This patch was generated with the following steps and serves > as a reference to use the symbol namespace feature: > > 1) Use EXPORT_SYMBOL_NS* macros instead of EXPORT_SYMBOL* for symbols > in watchdog_core.c > 2) make (see warnings during modpost about missing imports) > 3) make nsdeps > > I used 'allmodconfig' for the above steps to ensure all occurrences are > patched. > > Defining DEFAULT_SYMBOL_NAMESPACE in the Makefile is not trivial in this > case as not only watchdog_core is defined in drivers/watchdog/Makefile. > Hence this patch uses the variant of using the EXPORT_SYMBOL_NS* macros > to export into a different namespace. > > An alternative to this patch would be a single definition line before > any use of EXPORT_SYMBOL*: > #define DEFAULT_SYMBOL_NAMESPACE WATCHDOG_CORE > > Signed-off-by: Matthias Maennich As we talked in chat, the cc: list for this patch was crazy :) If you end up resending this (as odds are the mailing lists will trash it for too many recipients), feel free to add: Reviewed-by: Greg Kroah-Hartman Great work, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=linuxfoundation.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="TupyVj17"; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46D6gF2K6zzDqLf; Wed, 21 Aug 2019 22:39:37 +1000 (AEST) Received: from localhost (unknown [12.166.174.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 81D002341E; Wed, 21 Aug 2019 12:39:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566391173; bh=9bKz63tfFMpFQqEEIloPUowFJ5JwR4y30ptvJscL/Iw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TupyVj17ES+TfT+ew5wxVn8/RoB+TY3kzi7v4OUpPABmXN54r5OmVi6tbiKQX/bZY 5gCzoLUZziA2oHRwBivvPBaJ3vxbNxMmuKTqKq08ygNvwKx22cXMo1ObY0kyFKURpq clArw0ZdRLuq6XCWIqAV2EpnFRwl4GNUZtxnjD1Y= Date: Wed, 21 Aug 2019 05:39:33 -0700 From: Greg KH To: Matthias Maennich Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, arnd@arndb.de, geert@linux-m68k.org, hpa@zytor.com, jeyu@kernel.org, joel@joelfernandes.org, kstewart@linuxfoundation.org, linux-arch@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-modules@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, lucas.de.marchi@gmail.com, maco@android.com, maco@google.com, michal.lkml@markovi.net, mingo@redhat.com, oneukum@suse.com, pombredanne@nexb.com, sam@ravnborg.org, sspatil@google.com, stern@rowland.harvard.edu, tglx@linutronix.de, usb-storage@lists.one-eyed-alien.net, x86@kernel.org, yamada.masahiro@socionext.com, Jean Delvare , Guenter Roeck , Alessandro Zummo , Alexandre Belloni , Wim Van Sebroeck , Joel Stanley , Andrew Jeffery , Nicolas Ferre , Ludovic Desroches , Eric Anholt , Stefan Wahren , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Support Opensource , Baruch Siach , William Breathitt Gray , Jerry Hoemann , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Tomas Winkler , Johannes Thumshirn , Andreas Werner , Kevin Hilman , Matthias Brugger , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Michal Simek , Andy Gross , Kukjin Kim , Krzysztof Kozlowski , Barry Song , Orson Zhai , Baolin Wang , Chunyan Zhang , Patrice Chotard , Maxime Coquelin , Alexandre Torgue , Maxime Ripard , Chen-Yu Tsai , Marc Gonzalez , Mans Rullgard , Thierry Reding , Jonathan Hunter , linux-hwmon@vger.kernel.org, linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, openbmc@lists.ozlabs.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org, patches@opensource.cirrus.com Subject: Re: [PATCH v3 11/11] RFC: watchdog: export core symbols in WATCHDOG_CORE namespace Message-ID: <20190821123933.GC4059@kroah.com> References: <20190813121733.52480-1-maennich@google.com> <20190821114955.12788-1-maennich@google.com> <20190821114955.12788-12-maennich@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190821114955.12788-12-maennich@google.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Mailman-Approved-At: Mon, 02 Sep 2019 10:34:53 +1000 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Aug 2019 12:39:39 -0000 On Wed, Aug 21, 2019 at 12:49:26PM +0100, Matthias Maennich wrote: > Modules using these symbols are required to explicitly import the > namespace. This patch was generated with the following steps and serves > as a reference to use the symbol namespace feature: > > 1) Use EXPORT_SYMBOL_NS* macros instead of EXPORT_SYMBOL* for symbols > in watchdog_core.c > 2) make (see warnings during modpost about missing imports) > 3) make nsdeps > > I used 'allmodconfig' for the above steps to ensure all occurrences are > patched. > > Defining DEFAULT_SYMBOL_NAMESPACE in the Makefile is not trivial in this > case as not only watchdog_core is defined in drivers/watchdog/Makefile. > Hence this patch uses the variant of using the EXPORT_SYMBOL_NS* macros > to export into a different namespace. > > An alternative to this patch would be a single definition line before > any use of EXPORT_SYMBOL*: > #define DEFAULT_SYMBOL_NAMESPACE WATCHDOG_CORE > > Signed-off-by: Matthias Maennich As we talked in chat, the cc: list for this patch was crazy :) If you end up resending this (as odds are the mailing lists will trash it for too many recipients), feel free to add: Reviewed-by: Greg Kroah-Hartman Great work, greg k-h