From: Florian Westphal <fw@strlen.de>
To: Todd Seidelmann <tseidelmann@linode.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: xt_physdev: Fix spurious error message in physdev_mt_check
Date: Wed, 21 Aug 2019 17:52:04 +0200 [thread overview]
Message-ID: <20190821155204.GC13057@breakpoint.cc> (raw)
In-Reply-To: <88b305fb-ebb9-5e81-f8ef-55a18609c5fc@linode.com>
Todd Seidelmann <tseidelmann@linode.com> wrote:
> Simplify the check in physdev_mt_check() to emit an error message
> only when passed an invalid chain (ie, NF_INET_LOCAL_OUT).
> This avoids cluttering up the log with errors against valid rules.
>
> For large/heavily modified rulesets, current behavior can quickly
> overwhelm the ring buffer, because this function gets called on
> every change, regardless of the rule that was changed.
Agreed, we've had this notice long enough, better to only
print it when we reject the rule.
Acked-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2019-08-21 15:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 15:47 [PATCH] netfilter: xt_physdev: Fix spurious error message in physdev_mt_check Todd Seidelmann
2019-08-21 15:52 ` Florian Westphal [this message]
2019-08-27 11:00 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821155204.GC13057@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=tseidelmann@linode.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.