From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/4] drm/shmem: Use mutex_trylock in drm_gem_shmem_purge Date: Wed, 21 Aug 2019 18:32:41 +0200 Message-ID: <20190821163241.GP11147@phenom.ffwll.local> References: <20190819161204.3106-1-robh@kernel.org> <20190819161204.3106-3-robh@kernel.org> <20190820090543.GE11147@phenom.ffwll.local> <20190821082343.GJ11147@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by gabe.freedesktop.org (Postfix) with ESMTPS id 37BCE6E975 for ; Wed, 21 Aug 2019 16:32:46 +0000 (UTC) Received: by mail-ed1-x544.google.com with SMTP id f22so3673359edt.4 for ; Wed, 21 Aug 2019 09:32:46 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Herring Cc: Maxime Ripard , Tomeu Vizoso , David Airlie , Sean Paul , dri-devel , Steven Price , Boris Brezillon , Robin Murphy List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBBdWcgMjEsIDIwMTkgYXQgMTE6MDM6NTVBTSAtMDUwMCwgUm9iIEhlcnJpbmcgd3Jv dGU6Cj4gT24gV2VkLCBBdWcgMjEsIDIwMTkgYXQgMzoyMyBBTSBEYW5pZWwgVmV0dGVyIDxkYW5p ZWxAZmZ3bGwuY2g+IHdyb3RlOgo+ID4KPiA+IE9uIFR1ZSwgQXVnIDIwLCAyMDE5IGF0IDA3OjM1 OjQ3QU0gLTA1MDAsIFJvYiBIZXJyaW5nIHdyb3RlOgo+ID4gPiBPbiBUdWUsIEF1ZyAyMCwgMjAx OSBhdCA0OjA1IEFNIERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4gd3JvdGU6Cj4gPiA+ ID4KPiA+ID4gPiBPbiBNb24sIEF1ZyAxOSwgMjAxOSBhdCAxMToxMjowMkFNIC0wNTAwLCBSb2Ig SGVycmluZyB3cm90ZToKPiA+ID4gPiA+IExvY2tkZXAgcmVwb3J0cyBhIGNpcmN1bGFyIGxvY2tp bmcgZGVwZW5kZW5jeSB3aXRoIHBhZ2VzX2xvY2sgdGFrZW4gaW4KPiA+ID4gPiA+IHRoZSBzaHJp bmtlciBjYWxsYmFjay4gVGhlIGRlYWRsb2NrIGNhbid0IGFjdHVhbGx5IGhhcHBlbiB3aXRoIGN1 cnJlbnQKPiA+ID4gPiA+IHVzZXJzIGF0IGxlYXN0IGFzIGEgQk8gd2lsbCBuZXZlciBiZSBwdXJn ZWFibGUgd2hlbiBwYWdlc19sb2NrIGlzIGhlbGQuCj4gPiA+ID4gPiBUbyBiZSBzYWZlLCBsZXQn cyB1c2UgbXV0ZXhfdHJ5bG9jaygpIGluc3RlYWQgYW5kIGJhaWwgaWYgYSBCTyBpcyBsb2NrZWQK PiA+ID4gPiA+IGFscmVhZHkuCj4gCj4gWy4uLl0KPiAKPiA+ID4gPiA+IC12b2lkIGRybV9nZW1f c2htZW1fcHVyZ2Uoc3RydWN0IGRybV9nZW1fb2JqZWN0ICpvYmopCj4gPiA+ID4gPiArYm9vbCBk cm1fZ2VtX3NobWVtX3B1cmdlKHN0cnVjdCBkcm1fZ2VtX29iamVjdCAqb2JqKQo+ID4gPiA+ID4g IHsKPiA+ID4gPiA+ICAgICAgIHN0cnVjdCBkcm1fZ2VtX3NobWVtX29iamVjdCAqc2htZW0gPSB0 b19kcm1fZ2VtX3NobWVtX29iaihvYmopOwo+ID4gPiA+ID4KPiA+ID4gPiA+IC0gICAgIG11dGV4 X2xvY2soJnNobWVtLT5wYWdlc19sb2NrKTsKPiA+ID4gPiA+ICsgICAgIGlmICghbXV0ZXhfdHJ5 bG9jaygmc2htZW0tPnBhZ2VzX2xvY2spKQo+ID4gPiA+Cj4gPiA+ID4gRGlkIHlvdSBzZWUgbXkg cGluZyBhYm91dCBjdXR0aW5nIGFsbCB0aGUgbG9ja2luZyBvdmVyIHRvIGRtYV9yZXN2Pwo+ID4g Pgo+ID4gPiBZZXMsIGJ1dCB5b3UgZGlkbid0IHJlcGx5IHRvIFJvYiBDLiBhYm91dCBpdC4gSSBn dWVzcyBJJ2xsIGhhdmUgdG8gZ28KPiA+ID4gZmlndXJlIG91dCBob3cgcmVzZXJ2YXRpb24gb2Jq ZWN0cyB3b3JrLi4uCj4gPgo+ID4gbXNtIHdhcyB0aGUgbGFzdCBkcml2ZXIgdGhhdCBzdGlsbCB1 c2VkIHN0cnVjdF9tdXRleC4gSXQncyBhIGxvbmctdGVybQo+ID4gZGVhZC1lbmQsIGFuZCBJIHRo aW5rIHdpdGggYWxsIHRoZSBlZmZvcnQgcmVjZW50bHkgdG8gY3JlYXRlIGhlbHBlcnMgZm9yCj4g PiByZW5kZXJpbmcgZHJpdmVycyAoc2htZW0sIHZyYW0sIHR0bSByZWZhY3RvcmluZykgd2Ugc2hv dWxkIG1ha2UgYSBzb2xpZAo+ID4gYXR0ZW1wdCB0byBnZXQgYWxpZ25lZC4gT3IgZGlkIHlvdSBt ZWFuIHRoYXQgUm9iIENsYXJrIGhhZCBzb21lCj4gPiByZXBseS9xdWVzdGlvbnMgdGhhdCBJIGRp ZG4nIHJlc3BvbmQgdG8gYmVjYXVzZSBpdCBmZWxsIHRocm91Z2ggY3JhY2tzPwo+IAo+IEknbSBu b3QgdXNpbmcgc3RydWN0X211dGV4LCBzbyBJJ20gY29uZnVzZWQgYXMgdG8gd2h5IHlvdSBrZWVw Cj4gbWVudGlvbmluZyBpdC4gVGhlIGxpc3Qgb2YgQk9zIGZvciB0aGUgc2hyaW5rZXIgaXMgcHJv dGVjdGVkIHdpdGggYQo+IG11dGV4IGZvciB0aGUgbGlzdC4gVGhhdCBsaXN0IGhlYWQsIGxpc3Qg bXV0ZXgsIGFuZCB0aGUgc2hyaW5rZXIKPiBpbnN0YW5jZSBhbGwgaGF2ZSB0byBsaXZlIGF0IHRo ZSBkcml2ZXIgbGV2ZWwsIHNvIHRoZXkgY2FuJ3QgYmUgbW92ZWQKPiBpbnRvIHNobWVtIGFzIHlv dSBzdWdnZXN0ZWQuIEFncmVlZD8KCnN0cnVjdF9tdXRleCBpcyBqdXN0IHRoZSBoaXN0b3JpY2Fs IGJhZ2dhZ2UuCgpXcnQgc2hyaW5rZXIvbHJ1LCB3aHkgbm90PyBXZSd2ZSB0YWxrZWQgYWJvdXQg bWF5YmUgbW92aW5nIHRoYXQgdG8gbWFrZSBpdAplYXNpZXIgdG8gc2hhcmUgLi4uCgo+IFRoZW4g dGhlcmUgaXMgdGhlIHBhZ2VzX2xvY2sgd2l0aGluIHRoZSBzaG1lbSBCTy4gSSBhc3N1bWUgdGhh dCBpcwo+IHdoYXQgeW91IGFyZSBzdWdnZXN0aW5nIGNvbnZlcnRpbmcgdG8gZG1hX3Jlc3Y/IEkn bSBub3QgcmVhbGx5IHN1cmUKPiB3aGF0IHRoYXQgd291bGQgbG9vayBsaWtlLiBZb3UncmUgZ29p bmcgdG8gaGF2ZSB0byBzcGVsbCBpdCBvdXQgZm9yCj4gbWUuIEluIG15IGJyaWVmIGxvb2sgYXQg aXQsIGl0IHNlZW1zIGxpa2UgYWRkZWQgY29tcGxleGl0eSBhbmQgaXQncwo+IG5vdCBjbGVhciB0 byBtZSB3aGF0IHRoYXQgYnV5cy4gQWxzbywgSSB0aGluayBpdCB3b3VsZCBtb3N0bHkgYmUgYW4K PiBpbnRlcm5hbCBpbXBsZW1lbnRhdGlvbiBkZXRhaWwgb2Ygc2htZW0gaGVscGVycywgdGhvdWdo IHRoZXJlIGlzIG9uZQo+IHNwb3QgaW4gcGFuZnJvc3QgdGhhdCB0YWtlcyB0aGUgbG9jayAoMiBi ZWZvcmUgdGhpcyBzZXJpZXMpLiBTbyBpdCdzCj4ga2luZCBvZiBvcnRob2dvbmFsIHRvIHRoaXMg c2VyaWVzLgoKVGhlIGlzc3VlIHJvdWdobHkgaXMgdGhhdCBoYXZpbmcgbXVsdGlwbGUgcGVyLWJv IGxvY2tzIGdldHMgZnVuLCBvbmNlIHlvdQphZGQgaW4gbXVsdGlwbGUgZHJpdmVycyBhbmQgZHlu YW1pYyBkbWEtYnVmIHNoYXJpbmcuIE1heWJlIHRoYXQncyBuZXZlcgpnb2luZyB0byBiZSBhbiBp c3N1ZSBmb3IgZHJpdmVycyB1c2luZyBzaG1lbSBoZWxwZXJzLCBidXQgd2hvIGtub3dzLiBUaGUK Y3Jvc3MtZHJpdmVyIHBlci1ibyBsb2NrIHRvIHVudGFuZ2xlIHRoYXQgbWF6ZSBpcyBkbWFfcmVz diwgYW5kIGlmIHlvdQp0aGVuIGFsc28gaGF2ZSB5b3VyIG93biBwZXItYm8gbG9ja3MgaXQgY2Fu IGdldCByYXRoZXIgaW50ZXJlc3RpbmcuIEJlc3QKY2FzZSB5b3UgZW5kIHVwIHdpdGggdHdvIGxv Y2tzIG5lc3RpbmcsIGFuZCB5b3VyIG93biBwZXItYm8gbG9jayBiZWluZwpmdWxseSByZWR1bmRh bnQuIFdvcnN0IGNhc2UgeW91IGdldCBkaWZmZXJlbnQgbmVzdGluZyBkZXBlbmRpbmcgd2hldGhl cgp5b3UgaW1wb3J0IG9yIGV4cG9ydC4gU28gdGhhdCdzIHJvdWdobHkgdGhlIGNvbnRleHQuCgpP ZiBjb3Vyc2UgZml4aW5nIGxvY2tpbmcgaXMgZ29pbmcgdG8gYmUgZWFzaWVyIHRoZSBmZXdlciB1 c2VycyB5b3UgaGF2ZS4KT25jZSB0aGVyZSdzIGxvdHMgb2YgY29kZSBhbmQgdXNlcnMgb2YgaXQg b3V0IHRoZXJlLCBpdCdzIHByZXR0eSBtdWNoCmltcG9zc2libGUuCgpTbyB5ZWFoIGl0IHdvdWxk IGJlIGEgMToxIHJlcGxhY2VtZW50IHdpdGggYWxsIHRoZSBwZXItYm8gbG9ja3MgeW91IGhhdmUK bm93LCBhbmQgc2VlaW5nIGhvdyBiYWRseSBpdCBiaXRlcy4KCj4gQWxzbywgSSB0aGluayBnZXR0 aW5nIG1vcmUgZHJpdmVycyB1c2luZyBzaG1lbSBpcyBtb3JlIGJlbmVmaWNpYWwgdGhhbgo+IGFs aWduaW5nIHRoZSBpbXBsZW1lbnRhdGlvbnMgb2YgdGhlIEdFTSBoZWxwZXJzLiBXZSBzaG91bGQg YXQgbGVhc3QgYmUKPiBhYmxlIHRvIGNvbnZlcnQgdmdlbSBhbmQgdmttcyBJIHdvdWxkIHRoaW5r LiBWYXJpb3VzIEtNUyBkcml2ZXJzIHRvbywKPiBidXQgdGhlcmUncyBhbiBpc3N1ZSBhcm91bmQg a2VybmVsIG1hcHBpbmdzIChvciBsYWNrIG9mKS4gVGhlcmUgcmVhbGx5Cj4gc2hvdWxkIGJlIGxp dHRsZSByZWFzb24gZm9yIG1vc3QgS01TIGRyaXZlcnMgdG8gaGF2ZSBhIGN1c3RvbSBCTyBhcwo+ IENNQSBvciBzaG1lbSBoZWxwZXJzIHNob3VsZCB3b3JrLgoKWWVhaCBhZ3JlZWQgb24gdGhpcywg SSBqdXN0IHdhbnQgdG8gbWFrZSBzdXJlIHdlJ3JlIG5vdCBkb2luZyB0aGlzCm11bHRpcGxlIHRp bWVzIC4uLgotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRl bCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWw=