From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BC06C3A59E for ; Wed, 21 Aug 2019 18:57:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B13A22CE3 for ; Wed, 21 Aug 2019 18:57:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="4+I01uoy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729253AbfHUS5W (ORCPT ); Wed, 21 Aug 2019 14:57:22 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:49774 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727959AbfHUS5W (ORCPT ); Wed, 21 Aug 2019 14:57:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vFX90YRsBTJK5AWhBMwuW2ac3NGFvVKSagxrVlHCSC4=; b=4+I01uoyADD27LQ/mt2GEBa42Y HbuAEganfQyti5Uyxbt1dwaEQJZoXKHtwdpYz5CtuSBCFxQlu/c8juqgI1QyrIciBjofrSemh+cSI a8qz9fC1h24ok064o74smCEVH86GnLus30Mi+BW+s10gxj859SXSSII/L0TZ3r+BUSf8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1i0VnH-0007Ea-II; Wed, 21 Aug 2019 20:57:15 +0200 Date: Wed, 21 Aug 2019 20:57:15 +0200 From: Andrew Lunn To: Heiner Kallweit Cc: Christian Herber , "davem@davemloft.net" , Florian Fainelli , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [EXT] Re: [PATCH net-next 0/1] Add BASE-T1 PHY support Message-ID: <20190821185715.GA16401@lunn.ch> References: <20190815153209.21529-1-christian.herber@nxp.com> <8c15b855-6947-9930-c3df-71a64fbff33b@gmail.com> <13e65051-fe4f-5964-30b3-75285e6d2eee@gmail.com> <5c920846-b8f5-d087-cea4-a8ca3f816127@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5c920846-b8f5-d087-cea4-a8ca3f816127@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The current patch set IMO is a little bit hacky. I'm not 100% happy > with the implicit assumption that there can't be devices supporting > T1 and classic BaseT modes or fiber modes. > > Andrew: Do you have an opinion on that? Hi Heiner I would also like cleaner integration. I doubt here is anything in the standard which says you cannot combine these modes. It is more a marketing question if anybody would build such a device. Maybe not directly into a vehicle, but you could imaging a mobile test device which uses T1 to talk to the car and T4 to connect to the garage network? So i don't think we should limit ourselves. phylib should provide a clean, simple set of helpers to perform standard operations for various modes. Drivers can make use of those helpers. That much should be clear. If we try to make genphy support them all simultaneously, is less clear. Andrew