From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH RFC 14/19] drm/bridge: Add the necessary bits to support bus format negotiation Date: Wed, 21 Aug 2019 20:31:48 +0200 Message-ID: <20190821203148.0b21cbab@collabora.com> References: <20190808151150.16336-1-boris.brezillon@collabora.com> <20190808151150.16336-15-boris.brezillon@collabora.com> <02dd5985-e816-e69c-d179-4de584c21af7@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2037C6E96C for ; Wed, 21 Aug 2019 18:31:54 +0000 (UTC) In-Reply-To: <02dd5985-e816-e69c-d179-4de584c21af7@baylibre.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Neil Armstrong Cc: Jernej Skrabec , Laurent Pinchart , Jonas Karlman , Seung-Woo Kim , dri-devel@lists.freedesktop.org, Kyungmin Park , Thierry Reding , Chris Healy , kernel@collabora.com, Sam Ravnborg List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAxNCBBdWcgMjAxOSAwOTo1MTowNyArMDIwMApOZWlsIEFybXN0cm9uZyA8bmFybXN0 cm9uZ0BiYXlsaWJyZS5jb20+IHdyb3RlOgoKPiBPbiAwOC8wOC8yMDE5IDE3OjExLCBCb3JpcyBC cmV6aWxsb24gd3JvdGU6Cj4gPiBUaGlzIHRha2VzIHRoZSBmb3JtIG9mIHZhcmlvdXMgaGVscGVy cywgcGx1cyB0aGUgYWRkaXRpb24gb2YgMiBuZXcKPiA+IHN0cnVjdHM6Cj4gPiAqIGRybV9idXNf Y2FwczogZGVzY3JpYmUgdGhlIGJ1cyBjYXBhYmlsaXRpZXMgb2YgYSBicmlkZ2UvZW5jb2Rlci4g Rm9yCj4gPiAgIGJyaWRnZXMgd2UgaGF2ZSBvbmUgZm9yIHRoZSBpbnB1dCBwb3J0IGFuZCBvbmUg Zm9yIHRoZSBvdXRwdXQgcG9ydC4KPiA+ICAgRW5jb2RlcnMganVzdCBoYXZlIG9uZSBvdXRwdXQg cG9ydC4KPiA+ICogZHJtX2J1c19jZmc6IGFkZGVkIHRvIHRoZSBkcm1fYnJpZGdlX3N0YXRlLiBJ dCdzIHN1cHBvc2VkIHRvIHN0b3JlCj4gPiAgIGJ1cyBjb25maWd1cmF0aW9uIGluZm9ybWF0aW9u LiBGb3Igbm93IHdlIGp1c3QgaGF2ZSBmb3JtYXQgYW5kIGZsYWdzCj4gPiAgIGJ1dCBtb3JlIGZp ZWxkcyBtaWdodCBiZSBhZGRlZCBpbiB0aGUgZnV0dXJlLiBBZ2FpbiwgZWFjaAo+ID4gICBkcm1f YnJpZGdlX3N0YXRlIGNvbnRhaW5zIDIgZHJtX2J1c19jZmcgZWxlbWVudHM6IG9uZSBmb3IgdGhl IG91dHB1dAo+ID4gICBwb3J0IGFuZCBvbmUgZm9yIHRoZSBpbnB1dCBwb3J0Cj4gPiAKPiA+IEhl bHBlcnMgY2FuIGJlIHVzZWQgZnJvbSBicmlkZ2UgZHJpdmVycycgLT5hdG9taWNfY2hlY2soKSBp bXBsZW1lbnRhdGlvbgo+ID4gdG8gbmVnb3RpYXRlIHRoZSBidXMgZm9ybWF0IHRvIHVzZS4gTmVn b3RpYXRpb24gaGFwcGVucyBpbiByZXNlcnZlIG9yZGVyLAo+ID4gc3RhcnRpbmcgZnJvbSB0aGUg bGFzdCBlbGVtZW50IG9mIHRoZSBicmlkZ2UgY2hhaW4gKHRoZSBvbmUgZGlyZWN0bHkKPiA+IGNv bm5lY3RlZCB0byB0aGUgZGlzcGxheSkgdG8gdGhlIGZpcnN0IGVsZW1lbnQgb2YgdGhlIGNoYWlu ICh0aGUgb25lCj4gPiBjb25uZWN0ZWQgdG8gdGhlIGVuY29kZXIpLgo+ID4gCj4gPiBOZWdvdGlh dGlvbiB1c3VhbGx5IHRha2VzIHBsYWNlIGluIDIgc3RlcHM6Cj4gPiAqIG1ha2Ugc3VyZSB0aGUg aW5wdXQgZW5kIG9mIHRoZSBuZXh0IGVsZW1lbnQgaW4gdGhlIGNoYWluIHBpY2tlZCBhCj4gPiAg IGZvcm1hdCB0aGF0J3Mgc3VwcG9ydGVkIGJ5IHRoZSBvdXRwdXQgZW5kIG9mIG91ciBicmlkZ2Uu IFRoYXQncyBkb25lCj4gPiAgIHdpdGggZHJtX2F0b21pY19icmlkZ2VfY2hvb3NlX291dHB1dF9i dXNfY2ZnKCkuCj4gPiAqIGNob29zZSBhIGZvcm1hdCBmb3IgdGhlIGlucHV0IGVuZCBvZiBvdXIg YnJpZGdlIGJhc2VkIG9uIHdoYXQncwo+ID4gICBzdXBwb3J0ZWQgYnkgdGhlIHByZXZpb3VzIGJy aWRnZSBpbiB0aGUgY2hhaW4uIFRoaXMgaXMgYWNoaWV2ZWQgYnkKPiA+ICAgY2FsbGluZyBkcm1f YXRvbWljX2JyaWRnZV9jaG9vc2VfaW5wdXRfYnVzX2NmZygpCj4gPiAKPiA+IE5vdGUgdGhhdCB0 aG9zZSBoZWxwZXJzIGFyZSBhIGJpdCBsYXggd2hlbiBpdCBjb21lcyB0byB1bml0aWFsaXplZAo+ ID4gYnVzIGZvcm1hdCB2YWxpZGF0aW9uLiBUaGF0J3MgaW50ZW50aW9uYWwuIElmIHdlIGRvbid0 IGRvIHRoYXQgd2UnbGwKPiA+IGJhc2ljYWxseSBicmVhayB0aGluZ3MgaWYgd2Ugc3RhcnQgYWRk aW5nIHN1cHBvcnQgZm9yIGJ1cyBmb3JtYXQKPiA+IG5lZ290aWF0aW9uIHRvIHNvbWUgZWxlbWVu dHMgb2YgdGhlIHBpcGVsaW5lIGxlYXZpbmcgb3RoZXJzIG9uIHRoZQo+ID4gc2lkZSwgYW5kIHRo YXQncyBsaWtlbHkgdG8gaGFwcGVuIGZvciBhbGwgZXh0ZXJuYWwgYnJpZGdlcyBzaW5jZSB3ZQo+ ID4gY2FuJ3QgbmVjZXNzYXJpbHkgdGVsbCB3aGVyZSB0aGV5IGFyZSB1c2VkLgo+ID4gCj4gPiBT aWduZWQtb2ZmLWJ5OiBCb3JpcyBCcmV6aWxsb24gPGJvcmlzLmJyZXppbGxvbkBjb2xsYWJvcmEu Y29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2RybV9icmlkZ2UuYyB8IDE4NyArKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ID4gIGluY2x1ZGUvZHJtL2RybV9icmlk Z2UuaCAgICAgfCAgNDYgKysrKysrKysrCj4gPiAgaW5jbHVkZS9kcm0vZHJtX2VuY29kZXIuaCAg ICB8ICAgNiArKwo+ID4gIDMgZmlsZXMgY2hhbmdlZCwgMjM5IGluc2VydGlvbnMoKykKPiA+IAo+ ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYnJpZGdlLmMgYi9kcml2ZXJzL2dw dS9kcm0vZHJtX2JyaWRnZS5jCj4gPiBpbmRleCA5ZWZiMjcwODdlNzAuLmVmMDcyZGY0MjQyMiAx MDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYnJpZGdlLmMKPiA+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9kcm1fYnJpZGdlLmMKPiA+IEBAIC02MDIsNiArNjAyLDE5MyBAQCB2b2lk IGRybV9hdG9taWNfYnJpZGdlX2NoYWluX2VuYWJsZShzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29k ZXIsCj4gPiAgfQo+ID4gIEVYUE9SVF9TWU1CT0woZHJtX2F0b21pY19icmlkZ2VfY2hhaW5fZW5h YmxlKTsKPiA+ICAKPiA+ICtpbnQgZHJtX2ZpbmRfYmVzdF9idXNfZm9ybWF0KGNvbnN0IHN0cnVj dCBkcm1fYnVzX2NhcHMgKmEsCj4gPiArCQkJICAgICBjb25zdCBzdHJ1Y3QgZHJtX2J1c19jYXBz ICpiLAo+ID4gKwkJCSAgICAgY29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUsCj4g PiArCQkJICAgICB1MzIgKnNlbGVjdGVkX2J1c19mbXQpCj4gPiArewo+ID4gKwl1bnNpZ25lZCBp bnQgaSwgajsKPiA+ICsKPiA+ICsJLyoKPiA+ICsJICogU29tZSBkcm1fYnJpZGdlL2RybV9lbmNv ZGVyIGRvbid0IGNhcmUgYWJvdXQgdGhlIGlucHV0L291dHB1dCBidXMKPiA+ICsJICogZm9ybWF0 LCBsZXQncyBzZXQgdGhlIGZvcm1hdCB0byB6ZXJvIGluIHRoYXQgY2FzZSAodGhpcyBpcyBvbmx5 Cj4gPiArCSAqIHZhbGlkIGlmIGJvdGggc2lkZSBvZiB0aGUgbGluayBkb24ndCBjYXJlKS4KPiA+ ICsJICovCj4gPiArCWlmICghYS0+bnVtX3N1cHBvcnRlZF9mbXRzICYmICFiLT5udW1fc3VwcG9y dGVkX2ZtdHMpIHsKPiA+ICsJCSpzZWxlY3RlZF9idXNfZm10ID0gMDsKPiA+ICsJCXJldHVybiAw Owo+ID4gKwl9IGVsc2UgaWYgKGItPm51bV9zdXBwb3J0ZWRfZm10cyA+IDEgJiYgYi0+c3VwcG9y dGVkX2ZtdHMpIHsKPiA+ICsJCSpzZWxlY3RlZF9idXNfZm10ID0gYi0+c3VwcG9ydGVkX2ZtdHNb MF07Cj4gPiArCQlyZXR1cm4gMDsgIAo+IAo+IEhlcmUsIGAhYS0+bnVtX3N1cHBvcnRlZF9mbXRz ICYmYCBpcyBtaXNzaW5nIG90aGVyd2lzZSB0aGlzIGNvZGUgd2lsbAo+IHNlbGVjdCBiLT5zdXBw b3J0ZWRfZm10c1swXSB3aGF0ZXZlciB0aGUgc3VwcG9ydGVkIGZvcm1hdHMgb2YgYS4KPiAKPiA+ ICsJfSBlbHNlIGlmIChhLT5udW1fc3VwcG9ydGVkX2ZtdHMgPiAxICYmIGEtPnN1cHBvcnRlZF9m bXRzKSB7Cj4gPiArCQkqc2VsZWN0ZWRfYnVzX2ZtdCA9IGEtPnN1cHBvcnRlZF9mbXRzWzBdOwo+ ID4gKwkJcmV0dXJuIDA7ICAKPiAKPiBIZXJlLCBgIWItPm51bV9zdXBwb3J0ZWRfZm10cyAmJmAg aXMgbWlzc2luZyBvdGhlcndpc2UgdGhpcyBjb2RlIHdpbGwKPiBzZWxlY3QgYS0+c3VwcG9ydGVk X2ZtdHNbMF0gd2hhdGV2ZXIgdGhlIHN1cHBvcnRlZCBmb3JtYXRzIG9mIGIuCj4gCj4gPiArCX0g ZWxzZSBpZiAoIWEtPm51bV9zdXBwb3J0ZWRfZm10cyB8fCAhYS0+c3VwcG9ydGVkX2ZtdHMgfHwK PiA+ICsJCSAgICFiLT5udW1fc3VwcG9ydGVkX2ZtdHMgfHwgIWItPnN1cHBvcnRlZF9mbXRzKSB7 Cj4gPiArCQlyZXR1cm4gLUVJTlZBTDsKPiA+ICsJfQo+ID4gKwo+ID4gKwkvKgo+ID4gKwkgKiBU T0RPOgo+ID4gKwkgKiBEdW1teSBhbGdvIHBpY2tpbmcgdGhlIGZpcnN0IG1hdGNoLiBXZSBwcm9i YWJseSB3YW50IHNvbWV0aGluZwo+ID4gKwkgKiBzbWFydGVyIHdoZXJlIHRoZSBuYXJyb3dlc3Qg Zm9ybWF0IChpbiB0ZXJtIG9mIGJ1cyB3aWR0aCkgdGhhdAo+ID4gKwkgKiBkb2VzIG5vdCBpbmN1 ciBkYXRhIGxvc3MgaXMgcGlja2VkLCBhbmQgaWYgYWxsIHBvc3NpYmxlIGZvcm1hdHMKPiA+ICsJ ICogYXJlIGxvc3N5LCBwaWNrIHRoZSBvbmUgdGhhdCdzIGxlc3MgbG9zc3kgYW1vbmcgYWxsIHRo ZSBjaG9pY2VzCj4gPiArCSAqIHdlIGhhdmUuIEluIG9yZGVyIHRvIGRvIHRoYXQgd2UnZCBuZWVk IHRvIGNvbnZlcnQgTUVESUFfQlVTX0ZNVF8KPiA+ICsJICogbW9kZXMgaW50byBzb21ldGhpbmcg bGlrZSBkcm1fZm9ybWF0X2luZm8uCj4gPiArCSAqLwo+ID4gKwlmb3IgKGkgPSAwOyBpIDwgYS0+ bnVtX3N1cHBvcnRlZF9mbXRzOyBpKyspIHsKPiA+ICsJCWZvciAoaiA9IDA7IGogPCBiLT5udW1f c3VwcG9ydGVkX2ZtdHM7IGorKykgewo+ID4gKwkJCWlmIChhLT5zdXBwb3J0ZWRfZm10c1tpXSA9 PSBiLT5zdXBwb3J0ZWRfZm10c1tqXSkgewo+ID4gKwkJCQkqc2VsZWN0ZWRfYnVzX2ZtdCA9IGEt PnN1cHBvcnRlZF9mbXRzW2ldOwo+ID4gKwkJCQlyZXR1cm4gMDsKPiA+ICsJCQl9Cj4gPiArCQl9 Cj4gPiArCX0KPiA+ICsKPiA+ICsJcmV0dXJuIC1FSU5WQUw7Cj4gPiArfQo+ID4gK0VYUE9SVF9T WU1CT0woZHJtX2ZpbmRfYmVzdF9idXNfZm9ybWF0KTsgIAo+IAo+IFsuLi5dCj4gCj4gV2l0aCB0 aGF0IGZpeGVkLCB0aGlzIHdvcmtzIHdpdGggYmFzaWMgbmVnb2NpYXRpb24gb2YgdGhlIHNpbmds ZSBNRURJQV9CVVNfRk1UX1lVVjhfMVgyNAo+IGV4cG9zZWQgYnkgdGhlIG1lc29uIGhkbWkgZW5j b2Rlciwgb3RoZXJ3aXNlIGl0IHRha2VzIHRoZSBmaXJzdCBkZWZhdWx0IE1FRElBX0JVU19GTVRf UkdCODg4XzFYMjQKPiBmb3JtYXQgZXhwb3NlZCBieSBkdy1oZG1pLgoKVGhhbmtzIGZvciB0aGUg cmVwb3J0LiBXaWxsIGJlIGZpeGVkIGluIHYyLgoKQm9yaXMKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVs