From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7456CC3A59E for ; Wed, 21 Aug 2019 18:37:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 468E1214DA for ; Wed, 21 Aug 2019 18:37:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qyfKQ9ss" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 468E1214DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Sw6MZMucOnrE4ZAnmO4jh/VNFEMYA5rF3tZd1XJpDHY=; b=qyfKQ9ssq/sJ9c G+B9fNMBHaVakKRATMdR4FD7NO/B3mW5Hit6eMuxQNSf6GpKokm0VtKtQOPmkHAij9mJkHijR7/qs +va2uLc6afKLkonZFjd9lwPGI/sA+V1OnpsvcQRG2scmU7A3IwCnN/CMrf6SMr4xAB/oEj3DnV6dP KQSv5pKzc71YkIOsUR9LhpAVaRyL4bqjF5fxlRqF1IyBEiQk0q8THpMKUKMqbZFEgW5W5ZRn32CXS MyZOlot8myDN1/B0VZOT+PE5ywO5sjPn/ZysJ0l9JVoLhpCV4PHSPu4iw63j5i1Yz0143rUvQ21/5 8v/pDd5A201M3h0Q0E2Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i0VU3-0002OI-8E; Wed, 21 Aug 2019 18:37:23 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i0VPS-0004VQ-9H for linux-amlogic@lists.infradead.org; Wed, 21 Aug 2019 18:32:39 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:b93f:9fae:b276:a89a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 94D802699FC; Wed, 21 Aug 2019 19:32:36 +0100 (BST) Date: Wed, 21 Aug 2019 20:32:33 +0200 From: Boris Brezillon To: Neil Armstrong Subject: Re: [RFC 02/11] drm/meson: venc: make drm_display_mode const Message-ID: <20190821203233.47137f57@collabora.com> In-Reply-To: <20190820084109.24616-3-narmstrong@baylibre.com> References: <20190820084109.24616-1-narmstrong@baylibre.com> <20190820084109.24616-3-narmstrong@baylibre.com> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190821_113238_515618_BEE27646 X-CRM114-Status: GOOD ( 12.73 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jernej.skrabec@siol.net, jonas@kwiboo.se, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, a.hajda@samsung.com, Laurent.pinchart@ideasonboard.com, linux-amlogic@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Tue, 20 Aug 2019 10:41:00 +0200 Neil Armstrong wrote: > Before switching to bridge funcs, make sure drm_display_mode is passed > as const to the venc functions. > > Signed-off-by: Neil Armstrong Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/meson/meson_venc.c | 2 +- > drivers/gpu/drm/meson/meson_venc.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c > index 3d4791798ae0..c8e9840ad450 100644 > --- a/drivers/gpu/drm/meson/meson_venc.c > +++ b/drivers/gpu/drm/meson/meson_venc.c > @@ -946,7 +946,7 @@ bool meson_venc_hdmi_venc_repeat(int vic) > EXPORT_SYMBOL_GPL(meson_venc_hdmi_venc_repeat); > > void meson_venc_hdmi_mode_set(struct meson_drm *priv, int vic, > - struct drm_display_mode *mode) > + const struct drm_display_mode *mode) > { > union meson_hdmi_venc_mode *vmode = NULL; > union meson_hdmi_venc_mode vmode_dmt; > diff --git a/drivers/gpu/drm/meson/meson_venc.h b/drivers/gpu/drm/meson/meson_venc.h > index 576768bdd08d..1abdcbdf51c0 100644 > --- a/drivers/gpu/drm/meson/meson_venc.h > +++ b/drivers/gpu/drm/meson/meson_venc.h > @@ -60,7 +60,7 @@ extern struct meson_cvbs_enci_mode meson_cvbs_enci_ntsc; > void meson_venci_cvbs_mode_set(struct meson_drm *priv, > struct meson_cvbs_enci_mode *mode); > void meson_venc_hdmi_mode_set(struct meson_drm *priv, int vic, > - struct drm_display_mode *mode); > + const struct drm_display_mode *mode); > unsigned int meson_venci_get_field(struct meson_drm *priv); > > void meson_venc_enable_vsync(struct meson_drm *priv); _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [RFC 02/11] drm/meson: venc: make drm_display_mode const Date: Wed, 21 Aug 2019 20:32:33 +0200 Message-ID: <20190821203233.47137f57@collabora.com> References: <20190820084109.24616-1-narmstrong@baylibre.com> <20190820084109.24616-3-narmstrong@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by gabe.freedesktop.org (Postfix) with ESMTPS id E28CB6E998 for ; Wed, 21 Aug 2019 18:32:37 +0000 (UTC) In-Reply-To: <20190820084109.24616-3-narmstrong@baylibre.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Neil Armstrong Cc: jernej.skrabec@siol.net, jonas@kwiboo.se, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Laurent.pinchart@ideasonboard.com, linux-amlogic@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAyMCBBdWcgMjAxOSAxMDo0MTowMCArMDIwMApOZWlsIEFybXN0cm9uZyA8bmFybXN0 cm9uZ0BiYXlsaWJyZS5jb20+IHdyb3RlOgoKPiBCZWZvcmUgc3dpdGNoaW5nIHRvIGJyaWRnZSBm dW5jcywgbWFrZSBzdXJlIGRybV9kaXNwbGF5X21vZGUgaXMgcGFzc2VkCj4gYXMgY29uc3QgdG8g dGhlIHZlbmMgZnVuY3Rpb25zLgo+IAo+IFNpZ25lZC1vZmYtYnk6IE5laWwgQXJtc3Ryb25nIDxu YXJtc3Ryb25nQGJheWxpYnJlLmNvbT4KClJldmlld2VkLWJ5OiBCb3JpcyBCcmV6aWxsb24gPGJv cmlzLmJyZXppbGxvbkBjb2xsYWJvcmEuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL21l c29uL21lc29uX3ZlbmMuYyB8IDIgKy0KPiAgZHJpdmVycy9ncHUvZHJtL21lc29uL21lc29uX3Zl bmMuaCB8IDIgKy0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRp b25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tZXNvbi9tZXNvbl92ZW5j LmMgYi9kcml2ZXJzL2dwdS9kcm0vbWVzb24vbWVzb25fdmVuYy5jCj4gaW5kZXggM2Q0NzkxNzk4 YWUwLi5jOGU5ODQwYWQ0NTAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21lc29uL21l c29uX3ZlbmMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tZXNvbi9tZXNvbl92ZW5jLmMKPiBA QCAtOTQ2LDcgKzk0Niw3IEBAIGJvb2wgbWVzb25fdmVuY19oZG1pX3ZlbmNfcmVwZWF0KGludCB2 aWMpCj4gIEVYUE9SVF9TWU1CT0xfR1BMKG1lc29uX3ZlbmNfaGRtaV92ZW5jX3JlcGVhdCk7Cj4g IAo+ICB2b2lkIG1lc29uX3ZlbmNfaGRtaV9tb2RlX3NldChzdHJ1Y3QgbWVzb25fZHJtICpwcml2 LCBpbnQgdmljLAo+IC0JCQkgICAgICBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSkKPiAr CQkJICAgICAgY29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUpCj4gIHsKPiAgCXVu aW9uIG1lc29uX2hkbWlfdmVuY19tb2RlICp2bW9kZSA9IE5VTEw7Cj4gIAl1bmlvbiBtZXNvbl9o ZG1pX3ZlbmNfbW9kZSB2bW9kZV9kbXQ7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9t ZXNvbi9tZXNvbl92ZW5jLmggYi9kcml2ZXJzL2dwdS9kcm0vbWVzb24vbWVzb25fdmVuYy5oCj4g aW5kZXggNTc2NzY4YmRkMDhkLi4xYWJkY2JkZjUxYzAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL21lc29uL21lc29uX3ZlbmMuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tZXNvbi9t ZXNvbl92ZW5jLmgKPiBAQCAtNjAsNyArNjAsNyBAQCBleHRlcm4gc3RydWN0IG1lc29uX2N2YnNf ZW5jaV9tb2RlIG1lc29uX2N2YnNfZW5jaV9udHNjOwo+ICB2b2lkIG1lc29uX3ZlbmNpX2N2YnNf bW9kZV9zZXQoc3RydWN0IG1lc29uX2RybSAqcHJpdiwKPiAgCQkJICAgICAgIHN0cnVjdCBtZXNv bl9jdmJzX2VuY2lfbW9kZSAqbW9kZSk7Cj4gIHZvaWQgbWVzb25fdmVuY19oZG1pX21vZGVfc2V0 KHN0cnVjdCBtZXNvbl9kcm0gKnByaXYsIGludCB2aWMsCj4gLQkJCSAgICAgIHN0cnVjdCBkcm1f ZGlzcGxheV9tb2RlICptb2RlKTsKPiArCQkJICAgICAgY29uc3Qgc3RydWN0IGRybV9kaXNwbGF5 X21vZGUgKm1vZGUpOwo+ICB1bnNpZ25lZCBpbnQgbWVzb25fdmVuY2lfZ2V0X2ZpZWxkKHN0cnVj dCBtZXNvbl9kcm0gKnByaXYpOwo+ICAKPiAgdm9pZCBtZXNvbl92ZW5jX2VuYWJsZV92c3luYyhz dHJ1Y3QgbWVzb25fZHJtICpwcml2KTsKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BC4BC3A59E for ; Wed, 21 Aug 2019 18:32:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3810A233A2 for ; Wed, 21 Aug 2019 18:32:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729951AbfHUScn (ORCPT ); Wed, 21 Aug 2019 14:32:43 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:52306 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729898AbfHUSci (ORCPT ); Wed, 21 Aug 2019 14:32:38 -0400 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:b93f:9fae:b276:a89a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 94D802699FC; Wed, 21 Aug 2019 19:32:36 +0100 (BST) Date: Wed, 21 Aug 2019 20:32:33 +0200 From: Boris Brezillon To: Neil Armstrong Cc: a.hajda@samsung.com, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@siol.net, linux-amlogic@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 02/11] drm/meson: venc: make drm_display_mode const Message-ID: <20190821203233.47137f57@collabora.com> In-Reply-To: <20190820084109.24616-3-narmstrong@baylibre.com> References: <20190820084109.24616-1-narmstrong@baylibre.com> <20190820084109.24616-3-narmstrong@baylibre.com> Organization: Collabora X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Aug 2019 10:41:00 +0200 Neil Armstrong wrote: > Before switching to bridge funcs, make sure drm_display_mode is passed > as const to the venc functions. > > Signed-off-by: Neil Armstrong Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/meson/meson_venc.c | 2 +- > drivers/gpu/drm/meson/meson_venc.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c > index 3d4791798ae0..c8e9840ad450 100644 > --- a/drivers/gpu/drm/meson/meson_venc.c > +++ b/drivers/gpu/drm/meson/meson_venc.c > @@ -946,7 +946,7 @@ bool meson_venc_hdmi_venc_repeat(int vic) > EXPORT_SYMBOL_GPL(meson_venc_hdmi_venc_repeat); > > void meson_venc_hdmi_mode_set(struct meson_drm *priv, int vic, > - struct drm_display_mode *mode) > + const struct drm_display_mode *mode) > { > union meson_hdmi_venc_mode *vmode = NULL; > union meson_hdmi_venc_mode vmode_dmt; > diff --git a/drivers/gpu/drm/meson/meson_venc.h b/drivers/gpu/drm/meson/meson_venc.h > index 576768bdd08d..1abdcbdf51c0 100644 > --- a/drivers/gpu/drm/meson/meson_venc.h > +++ b/drivers/gpu/drm/meson/meson_venc.h > @@ -60,7 +60,7 @@ extern struct meson_cvbs_enci_mode meson_cvbs_enci_ntsc; > void meson_venci_cvbs_mode_set(struct meson_drm *priv, > struct meson_cvbs_enci_mode *mode); > void meson_venc_hdmi_mode_set(struct meson_drm *priv, int vic, > - struct drm_display_mode *mode); > + const struct drm_display_mode *mode); > unsigned int meson_venci_get_field(struct meson_drm *priv); > > void meson_venc_enable_vsync(struct meson_drm *priv);