From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ACD1C3A59E for ; Wed, 21 Aug 2019 21:04:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 25D002332A for ; Wed, 21 Aug 2019 21:04:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730396AbfHUVEU (ORCPT ); Wed, 21 Aug 2019 17:04:20 -0400 Received: from Chamillionaire.breakpoint.cc ([193.142.43.52]:43108 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727629AbfHUVEU (ORCPT ); Wed, 21 Aug 2019 17:04:20 -0400 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1i0XmD-00072L-I4; Wed, 21 Aug 2019 23:04:17 +0200 Date: Wed, 21 Aug 2019 23:04:17 +0200 From: Florian Westphal To: Pablo Neira Ayuso Cc: Florian Westphal , Ander Juaristi , netfilter-devel@vger.kernel.org Subject: Re: [PATCH nft v8 2/2] meta: Introduce new conditions 'time', 'day' and 'hour' Message-ID: <20190821210417.GD20113@breakpoint.cc> References: <20190821151802.6849-1-a@juaristi.eus> <20190821151802.6849-2-a@juaristi.eus> <20190821162341.GB20113@breakpoint.cc> <20190821205055.dss3wfiv4pogyhjl@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190821205055.dss3wfiv4pogyhjl@salvia> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Pablo Neira Ayuso wrote: > On Wed, Aug 21, 2019 at 06:23:41PM +0200, Florian Westphal wrote: > > Ander Juaristi wrote: > > > These keywords introduce new checks for a timestamp, an absolute date (which is converted to a timestamp), > > > an hour in the day (which is converted to the number of seconds since midnight) and a day of week. > > > > > > When converting an ISO date (eg. 2019-06-06 17:00) to a timestamp, > > > we need to substract it the GMT difference in seconds, that is, the value > > > of the 'tm_gmtoff' field in the tm structure. This is because the kernel > > > doesn't know about time zones. And hence the kernel manages different timestamps > > > than those that are advertised in userspace when running, for instance, date +%s. > > > > > > The same conversion needs to be done when converting hours (e.g 17:00) to seconds since midnight > > > as well. > > > > > > The result needs to be computed modulo 86400 in case GMT offset (difference in seconds from UTC) > > > is negative. > > > > > > We also introduce a new command line option (-t, --seconds) to show the actual > > > timestamps when printing the values, rather than the ISO dates, or the hour. > > > > Pablo, please see this "-t" option -- should be just re-use -n instead? > > > > Other than this, this patch looks good and all tests pass for me. > > this should be printed numerically with -n (global switch to disable > literal printing). > > Then, -t could be added for disabling literal in a more fine grain, as > Phil suggest time ago with other existing options that are similar to > this one. Ander, would you mind respinning this once more and excluding the -t option? You can reuse -n (OPT_NUMERIC) to print raw time values for the time being.