All of lore.kernel.org
 help / color / mirror / Atom feed
From: stephen@brennan.io
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Colin Ian King <colin.king@canonical.com>,
	devel@driverdev.osuosl.org,
	Jerry Chuang <jerry-chuang@realtek.com>,
	linux-kernel@vger.kernel.org,
	John Whitmore <johnfwhitmore@gmail.com>
Subject: Re: Added Realtek rtl8192u driver to staging - static analysis report.
Date: Wed, 21 Aug 2019 14:56:53 -0700	[thread overview]
Message-ID: <20190821215653.GA8199@pride> (raw)
In-Reply-To: <20190821205531.GC17415@kroah.com>

> > Either way, it's not clear to me and I think the code needs cleaning 
> > up.
> > Any ideas?
> 
> 10+ year old code, yeah!!!
> 
> Just guess, who knows, no one seems to care :(

I'm at least interested in helping with cleaning the code and learning 
about the driver, maybe fixing up logical errors like this at some point.  
But I have had some trouble finding the hardware to test on. Maybe that's 
part of the issue?


  reply	other threads:[~2019-08-21 21:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-21 18:18 Added Realtek rtl8192u driver to staging - static analysis report Colin Ian King
2019-08-21 20:55 ` Greg Kroah-Hartman
2019-08-21 21:56   ` stephen [this message]
2019-08-22  8:08 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190821215653.GA8199@pride \
    --to=stephen@brennan.io \
    --cc=colin.king@canonical.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jerry-chuang@realtek.com \
    --cc=johnfwhitmore@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.