From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E3AB420212CA7 for ; Wed, 21 Aug 2019 18:32:12 -0700 (PDT) Date: Thu, 22 Aug 2019 09:31:00 +0800 From: Baoquan He Subject: Re: devm_memremap_pages() triggers a kasan_add_zero_shadow() warning Message-ID: <20190822013100.GC2588@MiWiFi-R3L-srv> References: <1565991345.8572.28.camel@lca.pw> <0FB85A78-C2EE-4135-9E0F-D5623CE6EA47@lca.pw> <0AC959D7-5BCB-4A81-BBDC-990E9826EB45@lca.pw> <1566421927.5576.3.camel@lca.pw> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1566421927.5576.3.camel@lca.pw> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Qian Cai Cc: linux-nvdimm , Linux Kernel Mailing List , kasan-dev@googlegroups.com, Linux MM , Andrey Ryabinin , Thomas Gleixner List-ID: T24gMDgvMjEvMTkgYXQgMDU6MTJwbSwgUWlhbiBDYWkgd3JvdGU6Cj4gPiA+IERvZXMgZGlzYWJs aW5nIENPTkZJR19SQU5ET01JWkVfQkFTRSBoZWxwPyBNYXliZSB0aGF0IHdvcmthcm91bmQgaGFz Cj4gPiA+IHJlZ3Jlc3NlZC4gRWZmZWN0aXZlbHkgd2UgbmVlZCB0byBmaW5kIHdoYXQgaXMgY2F1 c2luZyB0aGUga2VybmVsIHRvCj4gPiA+IHNvbWV0aW1lcyBiZSBwbGFjZWQgaW4gdGhlIG1pZGRs ZSBvZiBhIGN1c3RvbSByZXNlcnZlZCBtZW1tYXA9IHJhbmdlLgo+ID4gCj4gPiBZZXMsIGRpc2Fi bGluZyBLQVNMUiB3b3JrcyBnb29kIHNvIGZhci4gQXNzdW1pbmcgdGhlIHdvcmthcm91bmQsIGku ZS4sCj4gPiBmMjg0NDI0OTdiNWMKPiA+ICjigJx4ODYvYm9vdDogRml4IEtBU0xSIGFuZCBtZW1t YXA9IGNvbGxpc2lvbuKAnSkgaXMgY29ycmVjdC4KPiA+IAo+ID4gVGhlIG9ubHkgb3RoZXIgY29t bWl0IHRoYXQgbWlnaHQgcmVncmVzcyBpdCBmcm9tIG15IHJlc2VhcmNoIHNvIGZhciBpcywKPiA+ IAo+ID4gZDUyZTdkNWE5NTJjICgieDg2L0tBU0xSOiBQYXJzZSBhbGwgJ21lbW1hcD0nIGJvb3Qg b3B0aW9uIGVudHJpZXPigJ0pCj4gPiAKPiAKPiBJdCB0dXJucyBvdXQgdGhhdCB0aGUgb3JpZ2lu IGNvbW1pdCBmMjg0NDI0OTdiNWMgKOKAnHg4Ni9ib290OiBGaXggS0FTTFIgYW5kCj4gbWVtbWFw PSBjb2xsaXNpb27igJ0pIGhhcyBhIGJ1ZyB0aGF0IGlzIHVuYWJsZSB0byBoYW5kbGUgIm1lbW1h cD0iIGluCj4gQ09ORklHX0NNRExJTkUgaW5zdGVhZCBvZiBhIHBhcmFtZXRlciBpbiBib290bG9h ZGVyIGJlY2F1c2Ugd2hlbiBpdCAoYXMgd2VsbCBhcwo+IHRoZSBjb21taXQgZDUyZTdkNWE5NTJj KSBjYWxscyBnZXRfY21kX2xpbmVfcHRyKCkgaW4gb3JkZXIgdG8gcnVuCj4gbWVtX2F2b2lkX21l bW1hcCgpLCAiYm9vdF9wYXJhbXMiIGhhcyBubyBrbm93bGVkZ2Ugb2YgQ09ORklHX0NNRExJTkUu IE9ubHkgbGF0ZXIKPiBpbiBzZXR1cF9hcmNoKCksIHRoZSBrZXJuZWwgd2lsbCBkZWFsIHdpdGgg cGFyYW1ldGVycyBvdmVyIHRoZXJlLgoKWWVzLCB3ZSBkaWRuJ3QgY29uc2lkZXIgQ09ORklHX0NN RExJTkUgZHVyaW5nIGJvb3QgY29tcHJlc3Npbmcgc3RhZ2UuIEl0CnNob3VsZCBiZSBhIGdlbmVy aWMgaXNzdWUgc2luY2Ugb3RoZXIgcGFyYW1ldGVycyBmcm9tIENPTkZJR19DTURMSU5FIGNvdWxk CmJlIGlnbm9yZWQgdG9vLCBub3Qgb25seSBLQVNMUiBoYW5kbGluZy4gV291bGQgeW91IGxpa2Ug dG8gY2FzdCBhIHBhdGNoCnRvIGZpeCBpdD8gT3IgSSBjYW4gZml4IGl0IGxhdGVyLCBtYXliZSBu ZXh0IHdlZWsuCgpUaGFua3MKQmFvcXVhbgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpMaW51eC1udmRpbW0gbWFpbGluZyBsaXN0CkxpbnV4LW52ZGltbUBs aXN0cy4wMS5vcmcKaHR0cHM6Ly9saXN0cy4wMS5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1u dmRpbW0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 419ABC3A59E for ; Thu, 22 Aug 2019 01:31:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0ECEC22DD3 for ; Thu, 22 Aug 2019 01:31:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0ECEC22DD3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9C43A6B02C5; Wed, 21 Aug 2019 21:31:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 94D806B02C6; Wed, 21 Aug 2019 21:31:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8149F6B02C7; Wed, 21 Aug 2019 21:31:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0191.hostedemail.com [216.40.44.191]) by kanga.kvack.org (Postfix) with ESMTP id 5A6CD6B02C5 for ; Wed, 21 Aug 2019 21:31:07 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id F22C6180AD7C3 for ; Thu, 22 Aug 2019 01:31:06 +0000 (UTC) X-FDA: 75848335332.07.roll49_43d24e05ceb40 X-HE-Tag: roll49_43d24e05ceb40 X-Filterd-Recvd-Size: 3404 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Thu, 22 Aug 2019 01:31:05 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A3BE710F23EC; Thu, 22 Aug 2019 01:31:04 +0000 (UTC) Received: from localhost (ovpn-12-48.pek2.redhat.com [10.72.12.48]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C02EA3DB3; Thu, 22 Aug 2019 01:31:03 +0000 (UTC) Date: Thu, 22 Aug 2019 09:31:00 +0800 From: Baoquan He To: Qian Cai Cc: Dan Williams , Linux MM , linux-nvdimm , Linux Kernel Mailing List , Andrey Ryabinin , kasan-dev@googlegroups.com, Dave Jiang , Thomas Gleixner Subject: Re: devm_memremap_pages() triggers a kasan_add_zero_shadow() warning Message-ID: <20190822013100.GC2588@MiWiFi-R3L-srv> References: <1565991345.8572.28.camel@lca.pw> <0FB85A78-C2EE-4135-9E0F-D5623CE6EA47@lca.pw> <0AC959D7-5BCB-4A81-BBDC-990E9826EB45@lca.pw> <1566421927.5576.3.camel@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1566421927.5576.3.camel@lca.pw> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.66]); Thu, 22 Aug 2019 01:31:04 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08/21/19 at 05:12pm, Qian Cai wrote: > > > Does disabling CONFIG_RANDOMIZE_BASE help? Maybe that workaround ha= s > > > regressed. Effectively we need to find what is causing the kernel t= o > > > sometimes be placed in the middle of a custom reserved memmap=3D ra= nge. > >=20 > > Yes, disabling KASLR works good so far. Assuming the workaround, i.e.= , > > f28442497b5c > > (=E2=80=9Cx86/boot: Fix KASLR and memmap=3D collision=E2=80=9D) is co= rrect. > >=20 > > The only other commit that might regress it from my research so far i= s, > >=20 > > d52e7d5a952c ("x86/KASLR: Parse all 'memmap=3D' boot option entries=E2= =80=9D) > >=20 >=20 > It turns out that the origin commit f28442497b5c (=E2=80=9Cx86/boot: Fi= x KASLR and > memmap=3D collision=E2=80=9D) has a bug that is unable to handle "memma= p=3D" in > CONFIG_CMDLINE instead of a parameter in bootloader because when it (as= well as > the commit d52e7d5a952c) calls get_cmd_line_ptr() in order to run > mem_avoid_memmap(), "boot_params" has no knowledge of CONFIG_CMDLINE. O= nly later > in setup_arch(), the kernel will deal with parameters over there. Yes, we didn't consider CONFIG_CMDLINE during boot compressing stage. It should be a generic issue since other parameters from CONFIG_CMDLINE coul= d be ignored too, not only KASLR handling. Would you like to cast a patch to fix it? Or I can fix it later, maybe next week. Thanks Baoquan