All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Kadlecsik József" <kadlec@blackhole.kfki.hu>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
	Jozsef Kadlecsik <kadlec@netfilter.org>,
	Florian Westphal <fw@strlen.de>,
	Florent Fourcot <florent.fourcot@wifirst.fr>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	Allison Randal <allison@lohutok.net>,
	Aditya Pakki <pakki001@umn.edu>, Qian Cai <cai@gmx.us>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Johannes Berg <johannes.berg@intel.com>,
	Stefano Brivio <sbrivio@redhat.com>,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] netfilter: ipset: Fix an error code in ip_set_sockfn_get()
Date: Thu, 22 Aug 2019 09:41:52 +0000	[thread overview]
Message-ID: <20190822094152.GJ3964@kadam> (raw)
In-Reply-To: <alpine.DEB.2.20.1908221109390.11879@blackhole.kfki.hu>

On Thu, Aug 22, 2019 at 11:11:56AM +0200, Kadlecsik József wrote:
> Hi Dan,
> 
> On Wed, 21 Aug 2019, Dan Carpenter wrote:
> 
> > The copy_to_user() function returns the number of bytes remaining to be
> > copied.  In this code, that positive return is checked at the end of the
> > function and we return zero/success.  What we should do instead is
> > return -EFAULT.
> 
> Yes, you are right. There's another usage of copy_to_user() in this 
> function, could you fix it as well?
> 

Yes, of course.  Thanks for the review.

regards,
dan carpenter

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Kadlecsik József" <kadlec@blackhole.kfki.hu>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
	Jozsef Kadlecsik <kadlec@netfilter.org>,
	Florian Westphal <fw@strlen.de>,
	Florent Fourcot <florent.fourcot@wifirst.fr>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	Allison Randal <allison@lohutok.net>,
	Aditya Pakki <pakki001@umn.edu>, Qian Cai <cai@gmx.us>,
	Andrey Ryabinin <aryabinin@virtuozzo.com>,
	Johannes Berg <johannes.berg@intel.com>,
	Stefano Brivio <sbrivio@redhat.com>,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] netfilter: ipset: Fix an error code in ip_set_sockfn_get()
Date: Thu, 22 Aug 2019 12:41:52 +0300	[thread overview]
Message-ID: <20190822094152.GJ3964@kadam> (raw)
In-Reply-To: <alpine.DEB.2.20.1908221109390.11879@blackhole.kfki.hu>

On Thu, Aug 22, 2019 at 11:11:56AM +0200, Kadlecsik József wrote:
> Hi Dan,
> 
> On Wed, 21 Aug 2019, Dan Carpenter wrote:
> 
> > The copy_to_user() function returns the number of bytes remaining to be
> > copied.  In this code, that positive return is checked at the end of the
> > function and we return zero/success.  What we should do instead is
> > return -EFAULT.
> 
> Yes, you are right. There's another usage of copy_to_user() in this 
> function, could you fix it as well?
> 

Yes, of course.  Thanks for the review.

regards,
dan carpenter


  reply	other threads:[~2019-08-22  9:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-21  7:18 [PATCH] netfilter: ipset: Fix an error code in ip_set_sockfn_get() Dan Carpenter
2019-08-21  7:18 ` Dan Carpenter
2019-08-22  9:11 ` Kadlecsik József
2019-08-22  9:11   ` Kadlecsik József
2019-08-22  9:41   ` Dan Carpenter [this message]
2019-08-22  9:41     ` Dan Carpenter
2019-08-24 14:49   ` [PATCH v2] " Dan Carpenter
2019-08-24 14:49     ` Dan Carpenter
2019-08-27 18:21     ` Kadlecsik József
2019-08-27 18:21       ` Kadlecsik József

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190822094152.GJ3964@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=allison@lohutok.net \
    --cc=aryabinin@virtuozzo.com \
    --cc=cai@gmx.us \
    --cc=coreteam@netfilter.org \
    --cc=florent.fourcot@wifirst.fr \
    --cc=fw@strlen.de \
    --cc=johannes.berg@intel.com \
    --cc=kadlec@blackhole.kfki.hu \
    --cc=kadlec@netfilter.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=pakki001@umn.edu \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.