From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E217C3A59D for ; Thu, 22 Aug 2019 10:51:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EF82F206DD for ; Thu, 22 Aug 2019 10:51:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732378AbfHVKvC (ORCPT ); Thu, 22 Aug 2019 06:51:02 -0400 Received: from stargate.chelsio.com ([12.32.117.8]:1420 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731964AbfHVKvC (ORCPT ); Thu, 22 Aug 2019 06:51:02 -0400 Received: from localhost (budha.blr.asicdesigners.com [10.193.185.4]) by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id x7MAoer0007835; Thu, 22 Aug 2019 03:50:41 -0700 Date: Thu, 22 Aug 2019 16:20:39 +0530 From: Krishnamraju Eraparaju To: Bernard Metzler Cc: Doug Ledford , "jgg@ziepe.ca" , "linux-rdma@vger.kernel.org" , Potnuri Bharat Teja , Nirranjan Kirubaharan Subject: Re: Re: [PATCH for-rc] siw: fix for 'is_kva' flag issue in siw_tx_hdt() Message-ID: <20190822105037.GA18600@chelsio.com> References: <20190819111338.9366-1-krishna2@chelsio.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.3 (20180206.02d571c2) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wednesday, August 08/21/19, 2019 at 19:13:18 +0530, Bernard Metzler wrote: > -----"Doug Ledford" wrote: ----- > > >To: "Bernard Metzler" , "Krishnamraju Eraparaju" > > > >From: "Doug Ledford" > >Date: 08/20/2019 07:56PM > >Cc: jgg@ziepe.ca, linux-rdma@vger.kernel.org, bharat@chelsio.com, > >nirranjan@chelsio.com > >Subject: [EXTERNAL] Re: [PATCH for-rc] siw: fix for 'is_kva' flag > >issue in siw_tx_hdt() > > > >On Mon, 2019-08-19 at 21:44 +0000, Bernard Metzler wrote: > >> Hi Krishna, > >> That is a good catch. I was not aware of the possibility of mixed > >> PBL and kernel buffer addresses in one SQE. > >> > >> A correct fix must also handle the un-mapping of any kmap()'d > >> buffers. The current TX code expects all buffers be either kmap()'d > >or > >> all not kmap()'d. So the fix is a little more complex, if we must > >> handle mixed SGL's during un-mapping. I think I can provide it by > >> tomorrow. It's almost midnight ;) > > > >I'll wait for a proper fix. Dropping this patch. Thanks. > > > Thanks Doug! > > I have a fix ready but still have to test it with iSER. > Unfortunately I have a hard time to test iSER with siw, since > both iSCSI-TCP target and iSER want to bind to the same > TCP port. While this may be considered a bug in that code, > siw is the first RDMA provider to take notice (since using > kernel sockets and not offloaded, hitting a TCP port > already bound). Not sure if this will become a serious problem when a iSCSI target is configured to serve both iSCSI-TCP & iSER connections simultaniously. Because, offloaded iSER CM handles all the TCP SYN packets that were destined to iSCSI-TCP. > > I sent the patch to Chelsio folks and hope for > the best. They know the trick to make it working. I have tested your patch, it's working fine. > > Thanks > Bernard. >