From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amadeusz =?UTF-8?B?U8WCYXdpxYRza2k=?= Subject: Re: [PATCH] ALSA: usb-audio: Check mixer unit bitmap yet more strictly Date: Thu, 22 Aug 2019 11:01:44 +0200 Message-ID: <20190822110144.46bb14d6@xxx> References: <20190822073207.8696-1-tiwai@suse.de> <20190822073207.8696-2-tiwai@suse.de> <20190822103148.0f947980@xxx> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C8E1AF80147 for ; Thu, 22 Aug 2019 10:57:17 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Takashi Iwai Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org T24gVGh1LCAyMiBBdWcgMjAxOSAxMDozNTowMSArMDIwMApUYWthc2hpIEl3YWkgPHRpd2FpQHN1 c2UuZGU+IHdyb3RlOgoKPiBPbiBUaHUsIDIyIEF1ZyAyMDE5IDEwOjMxOjQ4ICswMjAwLAo+IEFt YWRldXN6IFPFgmF3acWEc2tpIHdyb3RlOgo+ID4gCj4gPiBPbiBUaHUsIDIyIEF1ZyAyMDE5IDA5 OjMyOjAzICswMjAwCj4gPiBUYWthc2hpIEl3YWkgPHRpd2FpQHN1c2UuZGU+IHdyb3RlOgo+ID4g ICAKPiA+ID4gVGhlIGJtQ29udHJvbHMgKGZvciBVQUMxKSBvciBibU1peGVyQ29udHJvbHMgKGZv ciBVQUMyLzMpIGJpdG1hcCBoYXMgYQo+ID4gPiB2YXJpYWJsZSBzaXplIGRlcGVuZGluZyBvbiBi b3RoIGlucHV0IGFuZCBvdXRwdXQgcGlucy4gIEl0cyBzaXplIGlzIHRvCj4gPiA+IGZpdCB3aXRo IGlucHV0ICogb3V0cHV0IGJpdHMuICBUaGUgcHJvYmxlbSBpcyB0aGF0IHRoZSBpbnB1dCBzaXpl Cj4gPiA+IGNhbid0IGJlIGRldGVybWluZWQgc2ltcGx5IGZyb20gdGhlIHVuaXQgZGVzY3JpcHRv ciBpdHNlbGYgYnV0IGl0Cj4gPiA+IG5lZWRzIHRvIHBhcnNlIHRoZSB3aG9sZSBjb25uZWN0ZWQg c291cmNlcy4gIEFsdGhvdWdoIHRoZQo+ID4gPiB1YWNfbWl4ZXJfdW5pdF9nZXRfY2hhbm5lbHMo KSB0cmllcyB0byBjaGVjayBzb21lIHBvc3NpYmxlIG92ZXJmbG93IG9mCj4gPiA+IHRoaXMgYml0 bWFwLCBpdCdzIGluY29tcGxldGUgZHVlIHRvIHRoZSBsYWNrIG9mIHRoZSAgZXZhbHVhdGlvbiBv Zgo+ID4gPiBpbnB1dCBwaW5zLgo+ID4gPiAKPiA+ID4gRm9yIGNvdmVyaW5nIHBvc3NpYmxlIG92 ZXJmbG93cywgdGhpcyBwYXRjaCBhZGRzIHRoZSBiaXRtYXAgb3ZlcmZsb3cKPiA+ID4gY2hlY2sg aW4gdGhlIGxvb3Agb2YgaW5wdXQgcGlucyBpbiBwYXJzZV9hdWRpb19taXhlcl91bml0KCkuCj4g PiA+IAo+ID4gPiBGaXhlczogMGJmZTVlNDM0ZTY2ICgiQUxTQTogdXNiLWF1ZGlvOiBDaGVjayBt aXhlciB1bml0IGRlc2NyaXB0b3JzCj4gPiA+IG1vcmUgc3RyaWN0bHkiKSBDYzogPHN0YWJsZUB2 Z2VyLmtlcm5lbC5vcmc+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IFRha2FzaGkgSXdhaSA8dGl3YWlA c3VzZS5kZT4KPiA+ID4gLS0tCj4gPiA+ICBzb3VuZC91c2IvbWl4ZXIuYyB8IDM0ICsrKysrKysr KysrKysrKysrKysrKysrKysrLS0tLS0tLS0KPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAyNiBpbnNl cnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBhL3NvdW5k L3VzYi9taXhlci5jIGIvc291bmQvdXNiL21peGVyLmMKPiA+ID4gaW5kZXggYjU5MjdjM2Q1YmMw Li4yN2VlNjhhNTA3YTIgMTAwNjQ0Cj4gPiA+IC0tLSBhL3NvdW5kL3VzYi9taXhlci5jCj4gPiA+ ICsrKyBiL3NvdW5kL3VzYi9taXhlci5jCj4gPiA+IEBAIC03MzksNyArNzM5LDYgQEAgc3RhdGlj IGludCB1YWNfbWl4ZXJfdW5pdF9nZXRfY2hhbm5lbHMoc3RydWN0Cj4gPiA+IG1peGVyX2J1aWxk ICpzdGF0ZSwgc3RydWN0IHVhY19taXhlcl91bml0X2Rlc2NyaXB0b3IgKmRlc2MpCj4gPiA+ICB7 Cj4gPiA+ICAJaW50IG11X2NoYW5uZWxzOwo+ID4gPiAtCXZvaWQgKmM7Cj4gPiA+ICAKPiA+ID4g IAlpZiAoZGVzYy0+Ykxlbmd0aCA8IHNpemVvZigqZGVzYykpCj4gPiA+ICAJCXJldHVybiAtRUlO VkFMOwo+ID4gPiBAQCAtNzYyLDEzICs3NjEsNiBAQCBzdGF0aWMgaW50IHVhY19taXhlcl91bml0 X2dldF9jaGFubmVscyhzdHJ1Y3QKPiA+ID4gbWl4ZXJfYnVpbGQgKnN0YXRlLCBicmVhazsKPiA+ ID4gIAl9Cj4gPiA+ICAKPiA+ID4gLQlpZiAoIW11X2NoYW5uZWxzKQo+ID4gPiAtCQlyZXR1cm4g MDsKPiA+ID4gLQo+ID4gPiAtCWMgPSB1YWNfbWl4ZXJfdW5pdF9ibUNvbnRyb2xzKGRlc2MsIHN0 YXRlLT5taXhlci0+cHJvdG9jb2wpOwo+ID4gPiAtCWlmIChjIC0gKHZvaWQgKilkZXNjICsgKG11 X2NoYW5uZWxzIC0gMSkgLyA4ID49Cj4gPiA+IGRlc2MtPmJMZW5ndGgpCj4gPiA+IC0JCXJldHVy biAwOyAvKiBubyBibUNvbnRyb2xzIC0+IHNraXAgKi8KPiA+ID4gLQo+ID4gPiAgCXJldHVybiBt dV9jaGFubmVsczsKPiA+ID4gIH0KPiA+ID4gIAo+ID4gPiBAQCAtMjAwOSw2ICsyMDAxLDI5IEBA IHN0YXRpYyBpbnQgcGFyc2VfYXVkaW9fZmVhdHVyZV91bml0KHN0cnVjdAo+ID4gPiBtaXhlcl9i dWlsZCAqc3RhdGUsIGludCB1bml0aWQsCj4gPiA+ICAgKiBNaXhlciBVbml0Cj4gPiA+ICAgKi8K PiA+ID4gIAo+ID4gPiArLyogY2hlY2sgd2hldGhlciB0aGUgZ2l2ZW4gaW4vb3V0IG92ZXJmbG93 cyBibU1peGVyQ29udHJvbHMgbWF0cml4ICovCj4gPiA+ICtzdGF0aWMgYm9vbCBtaXhlcl9iaXRt YXBfb3ZlcmZsb3coc3RydWN0IHVhY19taXhlcl91bml0X2Rlc2NyaXB0b3IKPiA+ID4gKmRlc2Ms Cj4gPiA+ICsJCQkJICBpbnQgcHJvdG9jb2wsIGludCBudW1faW5zLCBpbnQKPiA+ID4gbnVtX291 dHMpICt7Cj4gPiA+ICsJdTggKmhkciA9ICh1OCAqKWRlc2M7Cj4gPiA+ICsJdTggKmMgPSB1YWNf bWl4ZXJfdW5pdF9ibUNvbnRyb2xzKGRlc2MsIHByb3RvY29sKTsKPiA+ID4gKwlzaXplX3QgcmVz dDsgLyogcmVtYWluaW5nIGJ5dGVzIGFmdGVyIGJtTWl4ZXJDb250cm9scyAqLwo+ID4gPiArCj4g PiA+ICsJc3dpdGNoIChwcm90b2NvbCkgewo+ID4gPiArCWNhc2UgVUFDX1ZFUlNJT05fMToKPiA+ ID4gKwlkZWZhdWx0OiAgCj4gPiAKPiA+IFdvbid0IHRoaXMgdHJpZ2dlciBpbXBsaWNpdCBmYWxs IHRocm91Z2ggd2FybmluZz8gIAo+IAo+IEFoIGluZGVlZCwgSSBzZWVtIHRvIGhhdmUgYnVpbHQg d2l0aCBhIGxpdHRsZSBiaXQgb2xkZXIga2VybmVsLgo+IFRoYW5rcyBmb3IgY2F0Y2hpbmcgaXQu Cj4gCj4gVGhlIHJldmlzZWQgcGF0Y2ggaXMgYmVsb3cuCj4gCgpPaC4uLiBkaWRuJ3QgZXZlbiBu b3RpY2UgdGhlIG1pc3NpbmcgYnJlYWtzIDspCkkgd2FzIGFza2luZyBhYm91dDoKPiArCWNhc2Ug VUFDX1ZFUlNJT05fMToKPiArCWRlZmF1bHQ6ClVubGVzcyBkZWZhdWx0IGlzIGhhbmRsZWQgc3Bl Y2lhbGx5IGl0IHdpbGwgcHJvYmFibHkgd2FybiBvbgpVQUNfVkVSU0lPTl8xIGxpbmUuCgo+IAo+ IFRha2FzaGkKPiAKPiAtLSA4PCAtLQo+IEZyb206IFRha2FzaGkgSXdhaSA8dGl3YWlAc3VzZS5k ZT4KPiBTdWJqZWN0OiBbUEFUQ0ggdjJdIEFMU0E6IHVzYi1hdWRpbzogQ2hlY2sgbWl4ZXIgdW5p dCBiaXRtYXAgeWV0IG1vcmUgc3RyaWN0bHkKPiAKPiBUaGUgYm1Db250cm9scyAoZm9yIFVBQzEp IG9yIGJtTWl4ZXJDb250cm9scyAoZm9yIFVBQzIvMykgYml0bWFwIGhhcyBhCj4gdmFyaWFibGUg c2l6ZSBkZXBlbmRpbmcgb24gYm90aCBpbnB1dCBhbmQgb3V0cHV0IHBpbnMuICBJdHMgc2l6ZSBp cyB0bwo+IGZpdCB3aXRoIGlucHV0ICogb3V0cHV0IGJpdHMuICBUaGUgcHJvYmxlbSBpcyB0aGF0 IHRoZSBpbnB1dCBzaXplCj4gY2FuJ3QgYmUgZGV0ZXJtaW5lZCBzaW1wbHkgZnJvbSB0aGUgdW5p dCBkZXNjcmlwdG9yIGl0c2VsZiBidXQgaXQKPiBuZWVkcyB0byBwYXJzZSB0aGUgd2hvbGUgY29u bmVjdGVkIHNvdXJjZXMuICBBbHRob3VnaCB0aGUKPiB1YWNfbWl4ZXJfdW5pdF9nZXRfY2hhbm5l bHMoKSB0cmllcyB0byBjaGVjayBzb21lIHBvc3NpYmxlIG92ZXJmbG93IG9mCj4gdGhpcyBiaXRt YXAsIGl0J3MgaW5jb21wbGV0ZSBkdWUgdG8gdGhlIGxhY2sgb2YgdGhlICBldmFsdWF0aW9uIG9m Cj4gaW5wdXQgcGlucy4KPiAKPiBGb3IgY292ZXJpbmcgcG9zc2libGUgb3ZlcmZsb3dzLCB0aGlz IHBhdGNoIGFkZHMgdGhlIGJpdG1hcCBvdmVyZmxvdwo+IGNoZWNrIGluIHRoZSBsb29wIG9mIGlu cHV0IHBpbnMgaW4gcGFyc2VfYXVkaW9fbWl4ZXJfdW5pdCgpLgo+IAo+IEZpeGVzOiAwYmZlNWU0 MzRlNjYgKCJBTFNBOiB1c2ItYXVkaW86IENoZWNrIG1peGVyIHVuaXQgZGVzY3JpcHRvcnMgbW9y ZSBzdHJpY3RseSIpCj4gQ2M6IDxzdGFibGVAdmdlci5rZXJuZWwub3JnPgo+IFNpZ25lZC1vZmYt Ynk6IFRha2FzaGkgSXdhaSA8dGl3YWlAc3VzZS5kZT4KPiAtLS0KPiBWMS0+djI6IEZpeCB0aGUg bWlzc2luZyBicmVhayBpbiBtaXhlcl9iaXRtYXBfb3ZlcmZsb3coKS4KPiAKPiAgc291bmQvdXNi L21peGVyLmMgfCAzNiArKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0KPiAgMSBm aWxlIGNoYW5nZWQsIDI4IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL3NvdW5kL3VzYi9taXhlci5jIGIvc291bmQvdXNiL21peGVyLmMKPiBpbmRleCBiNTky N2MzZDViYzAuLmVjZWFiMTk3NjZkYiAxMDA2NDQKPiAtLS0gYS9zb3VuZC91c2IvbWl4ZXIuYwo+ ICsrKyBiL3NvdW5kL3VzYi9taXhlci5jCj4gQEAgLTczOSw3ICs3MzksNiBAQCBzdGF0aWMgaW50 IHVhY19taXhlcl91bml0X2dldF9jaGFubmVscyhzdHJ1Y3QgbWl4ZXJfYnVpbGQgKnN0YXRlLAo+ ICAJCQkJICAgICAgIHN0cnVjdCB1YWNfbWl4ZXJfdW5pdF9kZXNjcmlwdG9yICpkZXNjKQo+ICB7 Cj4gIAlpbnQgbXVfY2hhbm5lbHM7Cj4gLQl2b2lkICpjOwo+ICAKPiAgCWlmIChkZXNjLT5iTGVu Z3RoIDwgc2l6ZW9mKCpkZXNjKSkKPiAgCQlyZXR1cm4gLUVJTlZBTDsKPiBAQCAtNzYyLDEzICs3 NjEsNiBAQCBzdGF0aWMgaW50IHVhY19taXhlcl91bml0X2dldF9jaGFubmVscyhzdHJ1Y3QgbWl4 ZXJfYnVpbGQgKnN0YXRlLAo+ICAJCWJyZWFrOwo+ICAJfQo+ICAKPiAtCWlmICghbXVfY2hhbm5l bHMpCj4gLQkJcmV0dXJuIDA7Cj4gLQo+IC0JYyA9IHVhY19taXhlcl91bml0X2JtQ29udHJvbHMo ZGVzYywgc3RhdGUtPm1peGVyLT5wcm90b2NvbCk7Cj4gLQlpZiAoYyAtICh2b2lkICopZGVzYyAr IChtdV9jaGFubmVscyAtIDEpIC8gOCA+PSBkZXNjLT5iTGVuZ3RoKQo+IC0JCXJldHVybiAwOyAv KiBubyBibUNvbnRyb2xzIC0+IHNraXAgKi8KPiAtCj4gIAlyZXR1cm4gbXVfY2hhbm5lbHM7Cj4g IH0KPiAgCj4gQEAgLTIwMDksNiArMjAwMSwzMSBAQCBzdGF0aWMgaW50IHBhcnNlX2F1ZGlvX2Zl YXR1cmVfdW5pdChzdHJ1Y3QgbWl4ZXJfYnVpbGQgKnN0YXRlLCBpbnQgdW5pdGlkLAo+ICAgKiBN aXhlciBVbml0Cj4gICAqLwo+ICAKPiArLyogY2hlY2sgd2hldGhlciB0aGUgZ2l2ZW4gaW4vb3V0 IG92ZXJmbG93cyBibU1peGVyQ29udHJvbHMgbWF0cml4ICovCj4gK3N0YXRpYyBib29sIG1peGVy X2JpdG1hcF9vdmVyZmxvdyhzdHJ1Y3QgdWFjX21peGVyX3VuaXRfZGVzY3JpcHRvciAqZGVzYywK PiArCQkJCSAgaW50IHByb3RvY29sLCBpbnQgbnVtX2lucywgaW50IG51bV9vdXRzKQo+ICt7Cj4g Kwl1OCAqaGRyID0gKHU4ICopZGVzYzsKPiArCXU4ICpjID0gdWFjX21peGVyX3VuaXRfYm1Db250 cm9scyhkZXNjLCBwcm90b2NvbCk7Cj4gKwlzaXplX3QgcmVzdDsgLyogcmVtYWluaW5nIGJ5dGVz IGFmdGVyIGJtTWl4ZXJDb250cm9scyAqLwo+ICsKPiArCXN3aXRjaCAocHJvdG9jb2wpIHsKPiAr CWNhc2UgVUFDX1ZFUlNJT05fMToKPiArCWRlZmF1bHQ6Cj4gKwkJcmVzdCA9IDE7IC8qIGlNaXhl ciAqLwo+ICsJCWJyZWFrOwo+ICsJY2FzZSBVQUNfVkVSU0lPTl8yOgo+ICsJCXJlc3QgPSAyOyAv KiBibUNvbnRyb2xzICsgaU1peGVyICovCj4gKwkJYnJlYWs7Cj4gKwljYXNlIFVBQ19WRVJTSU9O XzM6Cj4gKwkJcmVzdCA9IDY7IC8qIGJtQ29udHJvbHMgKyB3TWl4ZXJEZXNjclN0ciAqLwo+ICsJ CWJyZWFrOwo+ICsJfQo+ICsKPiArCS8qIG92ZXJmbG93PyAqLwo+ICsJcmV0dXJuIGMgKyAobnVt X2lucyAqIG51bV9vdXRzICsgNykgLyA4ICsgcmVzdCA+IGhkciArIGhkclswXTsKPiArfQo+ICsK PiAgLyoKPiAgICogYnVpbGQgYSBtaXhlciB1bml0IGNvbnRyb2wKPiAgICoKPiBAQCAtMjEzNyw2 ICsyMTU0LDkgQEAgc3RhdGljIGludCBwYXJzZV9hdWRpb19taXhlcl91bml0KHN0cnVjdCBtaXhl cl9idWlsZCAqc3RhdGUsIGludCB1bml0aWQsCj4gIAkJaWYgKGVyciA8IDApCj4gIAkJCXJldHVy biBlcnI7Cj4gIAkJbnVtX2lucyArPSBpdGVybS5jaGFubmVsczsKPiArCQlpZiAobWl4ZXJfYml0 bWFwX292ZXJmbG93KGRlc2MsIHN0YXRlLT5taXhlci0+cHJvdG9jb2wsCj4gKwkJCQkJICBudW1f aW5zLCBudW1fb3V0cykpCj4gKwkJCWJyZWFrOwo+ICAJCWZvciAoOyBpY2ggPCBudW1faW5zOyBp Y2grKykgewo+ICAJCQlpbnQgb2NoLCBpY2hfaGFzX2NvbnRyb2xzID0gMDsKPiAgCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBbHNhLWRldmVsIG1haWxp bmcgbGlzdApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0cHM6Ly9tYWlsbWFuLmFsc2Et cHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbHNhLWRldmVsCg==