From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 10/10] dma-buf/resv: add other operations Date: Thu, 22 Aug 2019 15:28:38 +0300 Message-ID: <20190822122838.GN5942@intel.com> References: <20190821123147.110736-1-christian.koenig@amd.com> <20190821123147.110736-11-christian.koenig@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8D0D56EB54 for ; Thu, 22 Aug 2019 14:20:57 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190821123147.110736-11-christian.koenig@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBBdWcgMjEsIDIwMTkgYXQgMDI6MzE6NDdQTSArMDIwMCwgQ2hyaXN0aWFuIEvDtm5p ZyB3cm90ZToKPiBBZGRpdGlvbmFsIHRvIHJlYWRlcnMgYW5kIHdyaXRlcnMgYWRkIGFub3RoZXIg Y2xhc3Mgb2Ygb3BlcmF0aW9ucwo+IHdoaWNoIG5ldmVyIHBhcnRpY2lwYXRlIGluIGltcGxpY2l0 IHN5bmNocm9uaXphdGlvbi4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpc3RpYW4gS8O2bmlnIDxj aHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZG1hLWJ1Zi9kbWEtcmVz di5jIHwgMjcgKysrKysrKysrKysrKysrKysrKysrKysrLS0tCj4gIGluY2x1ZGUvbGludXgvZG1h LXJlc3YuaCAgIHwgIDIgKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCspLCAz IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2RtYS1idWYvZG1hLXJlc3Yu YyBiL2RyaXZlcnMvZG1hLWJ1Zi9kbWEtcmVzdi5jCj4gaW5kZXggOGVmN2RiYzdmZDhlLi5jNmRk NmMzNmRiYTIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9kbWEtYnVmL2RtYS1yZXN2LmMKPiArKysg Yi9kcml2ZXJzL2RtYS1idWYvZG1hLXJlc3YuYwo+IEBAIC0yODAsNiArMjgwLDcgQEAgdm9pZCBk bWFfcmVzdl9pbml0KHN0cnVjdCBkbWFfcmVzdiAqb2JqKQo+ICAKPiAgCWRtYV9yZXN2X2ZlbmNl c19pbml0KCZvYmotPndyaXRlcnMpOwo+ICAJZG1hX3Jlc3ZfZmVuY2VzX2luaXQoJm9iai0+cmVh ZGVycyk7Cj4gKwlkbWFfcmVzdl9mZW5jZXNfaW5pdCgmb2JqLT5vdGhlcnMpOwo+ICB9Cj4gIEVY UE9SVF9TWU1CT0woZG1hX3Jlc3ZfaW5pdCk7Cj4gIAo+IEBAIC0yOTUsNiArMjk2LDcgQEAgdm9p ZCBkbWFfcmVzdl9maW5pKHN0cnVjdCBkbWFfcmVzdiAqb2JqKQo+ICAJICovCj4gIAlkbWFfcmVz dl9mZW5jZXNfZmluaSgmb2JqLT53cml0ZXJzKTsKPiAgCWRtYV9yZXN2X2ZlbmNlc19maW5pKCZv YmotPnJlYWRlcnMpOwo+ICsJZG1hX3Jlc3ZfZmVuY2VzX2ZpbmkoJm9iai0+b3RoZXJzKTsKPiAg CXd3X211dGV4X2Rlc3Ryb3koJm9iai0+bG9jayk7Cj4gIH0KPiAgRVhQT1JUX1NZTUJPTChkbWFf cmVzdl9maW5pKTsKPiBAQCAtMzM0LDYgKzMzNiwxMCBAQCB2b2lkIGRtYV9yZXN2X3BydW5lX2Zl bmNlcyhzdHJ1Y3QgZG1hX3Jlc3YgKm9iaikKPiAgCWZlbmNlID0gZG1hX3Jlc3ZfZmVuY2VzX2Rl cmVmKG9iaiwgJm9iai0+cmVhZGVycyk7Cj4gIAlpZiAoZG1hX2ZlbmNlX2lzX3NpZ25hbGVkKGZl bmNlKSkKPiAgCQlkbWFfcmVzdl9mZW5jZXNfc2V0KG9iaiwgJm9iai0+cmVhZGVycywgTlVMTCk7 Cj4gKwo+ICsJZmVuY2UgPSBkbWFfcmVzdl9mZW5jZXNfZGVyZWYob2JqLCAmb2JqLT5vdGhlcnMp Owo+ICsJaWYgKGRtYV9mZW5jZV9pc19zaWduYWxlZChmZW5jZSkpCj4gKwkJZG1hX3Jlc3ZfZmVu Y2VzX3NldChvYmosICZvYmotPm90aGVycywgTlVMTCk7Cj4gIH0KPiAgRVhQT1JUX1NZTUJPTChk bWFfcmVzdl9wcnVuZV9mZW5jZXMpOwo+ICAKPiBAQCAtMzQ2LDE3ICszNTIsMTkgQEAgRVhQT1JU X1NZTUJPTChkbWFfcmVzdl9wcnVuZV9mZW5jZXMpOwo+ICAqLwo+ICBpbnQgZG1hX3Jlc3ZfY29w eV9mZW5jZXMoc3RydWN0IGRtYV9yZXN2ICpkc3QsIHN0cnVjdCBkbWFfcmVzdiAqc3JjKQo+ICB7 Cj4gLQlzdHJ1Y3QgZG1hX2ZlbmNlICp3cml0ZXJzLCAqcmVhZGVyczsKPiArCXN0cnVjdCBkbWFf ZmVuY2UgKndyaXRlcnMsICpyZWFkZXJzLCAqb3RoZXJzOwo+ICAKPiAgCWRtYV9yZXN2X2Fzc2Vy dF9oZWxkKGRzdCk7Cj4gIAo+ICAJcmN1X3JlYWRfbG9jaygpOwo+ICAJd3JpdGVycyA9IGRtYV9y ZXN2X2ZlbmNlc19nZXRfcmN1KCZzcmMtPndyaXRlcnMpOwo+ICAJcmVhZGVycyA9IGRtYV9yZXN2 X2ZlbmNlc19nZXRfcmN1KCZzcmMtPnJlYWRlcnMpOwo+ICsJb3RoZXJzID0gZG1hX3Jlc3ZfZmVu Y2VzX2dldF9yY3UoJnNyYy0+b3RoZXJzKTsKPiAgCXJjdV9yZWFkX3VubG9jaygpOwo+ICAKPiAg CWRtYV9yZXN2X2ZlbmNlc19zZXQoZHN0LCAmZHN0LT53cml0ZXJzLCB3cml0ZXJzKTsKPiAgCWRt YV9yZXN2X2ZlbmNlc19zZXQoZHN0LCAmZHN0LT5yZWFkZXJzLCByZWFkZXJzKTsKPiArCWRtYV9y ZXN2X2ZlbmNlc19zZXQoZHN0LCAmZHN0LT5yZWFkZXJzLCBvdGhlcnMpOwogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBeXl5eXl5eCgpvdGhlcnM/CgoKLS0gClZpbGxlIFN5 cmrDpGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1D6DC3A5A1 for ; Thu, 22 Aug 2019 12:28:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB0E1206BB for ; Thu, 22 Aug 2019 12:28:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731393AbfHVM2n (ORCPT ); Thu, 22 Aug 2019 08:28:43 -0400 Received: from mga07.intel.com ([134.134.136.100]:17884 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726332AbfHVM2n (ORCPT ); Thu, 22 Aug 2019 08:28:43 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Aug 2019 05:28:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,416,1559545200"; d="scan'208";a="190566346" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga002.jf.intel.com with SMTP; 22 Aug 2019 05:28:39 -0700 Received: by stinkbox (sSMTP sendmail emulation); Thu, 22 Aug 2019 15:28:38 +0300 Date: Thu, 22 Aug 2019 15:28:38 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: dri-devel@lists.freedesktop.org, chris@chris-wilson.co.uk, daniel.vetter@ffwll.ch, sumit.semwal@linaro.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH 10/10] dma-buf/resv: add other operations Message-ID: <20190822122838.GN5942@intel.com> References: <20190821123147.110736-1-christian.koenig@amd.com> <20190821123147.110736-11-christian.koenig@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190821123147.110736-11-christian.koenig@amd.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Wed, Aug 21, 2019 at 02:31:47PM +0200, Christian König wrote: > Additional to readers and writers add another class of operations > which never participate in implicit synchronization. > > Signed-off-by: Christian König > --- > drivers/dma-buf/dma-resv.c | 27 ++++++++++++++++++++++++--- > include/linux/dma-resv.h | 2 ++ > 2 files changed, 26 insertions(+), 3 deletions(-) > > diff --git a/drivers/dma-buf/dma-resv.c b/drivers/dma-buf/dma-resv.c > index 8ef7dbc7fd8e..c6dd6c36dba2 100644 > --- a/drivers/dma-buf/dma-resv.c > +++ b/drivers/dma-buf/dma-resv.c > @@ -280,6 +280,7 @@ void dma_resv_init(struct dma_resv *obj) > > dma_resv_fences_init(&obj->writers); > dma_resv_fences_init(&obj->readers); > + dma_resv_fences_init(&obj->others); > } > EXPORT_SYMBOL(dma_resv_init); > > @@ -295,6 +296,7 @@ void dma_resv_fini(struct dma_resv *obj) > */ > dma_resv_fences_fini(&obj->writers); > dma_resv_fences_fini(&obj->readers); > + dma_resv_fences_fini(&obj->others); > ww_mutex_destroy(&obj->lock); > } > EXPORT_SYMBOL(dma_resv_fini); > @@ -334,6 +336,10 @@ void dma_resv_prune_fences(struct dma_resv *obj) > fence = dma_resv_fences_deref(obj, &obj->readers); > if (dma_fence_is_signaled(fence)) > dma_resv_fences_set(obj, &obj->readers, NULL); > + > + fence = dma_resv_fences_deref(obj, &obj->others); > + if (dma_fence_is_signaled(fence)) > + dma_resv_fences_set(obj, &obj->others, NULL); > } > EXPORT_SYMBOL(dma_resv_prune_fences); > > @@ -346,17 +352,19 @@ EXPORT_SYMBOL(dma_resv_prune_fences); > */ > int dma_resv_copy_fences(struct dma_resv *dst, struct dma_resv *src) > { > - struct dma_fence *writers, *readers; > + struct dma_fence *writers, *readers, *others; > > dma_resv_assert_held(dst); > > rcu_read_lock(); > writers = dma_resv_fences_get_rcu(&src->writers); > readers = dma_resv_fences_get_rcu(&src->readers); > + others = dma_resv_fences_get_rcu(&src->others); > rcu_read_unlock(); > > dma_resv_fences_set(dst, &dst->writers, writers); > dma_resv_fences_set(dst, &dst->readers, readers); > + dma_resv_fences_set(dst, &dst->readers, others); ^^^^^^^ others? -- Ville Syrjälä Intel