From: Richard Cochran <richardcochran@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
Hubert Feurstein <h.feurstein@gmail.com>,
Miroslav Lichvar <mlichvar@redhat.com>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
linux-spi@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH spi for-5.4 0/5] Deterministic SPI latency with NXP DSPI driver
Date: Thu, 22 Aug 2019 07:16:41 -0700 [thread overview]
Message-ID: <20190822141641.GB1437@localhost> (raw)
In-Reply-To: <CA+h21hrtzU1XL-0m+BG5TYZvVh8WN6hgcM7CV5taHyq2MsR5dw@mail.gmail.com>
On Wed, Aug 21, 2019 at 11:17:23PM +0300, Vladimir Oltean wrote:
> Of course PPS with a dedicated hardware receiver that can take input
> compare timestamps is always preferable. However non-Ethernet
> synchronization in the field looks to me like "make do with whatever
> you can". I'm not sure a plain GPIO that raises an interrupt is better
> than an interrupt-driven serial protocol controller - it's (mostly)
> the interrupts that throw off the precision of the software timestamp.
> And use Miroslav's pps-gpio-poll module and you're back from where you
> started (try to make a sw timestamp as precise as possible).
Right, it might be better, might not. You can consider hacking a
local time stamp into the ISR. Also, if one of your MACs has a input
event pin, you can feed the switch's PPS output in there.
> wouldn't be my first choice. But DSA could have that built-in, and
> with the added latency benefit of a MAC-to-MAC connection.
> Too bad the mv88e6xxx driver can't do loopback timestamping, that's
> already 50% of the DSA drivers that support PTP at all. An embedded
> solution for this is less compelling now.
Let me back track on my statement about mv88e6xxx. At the time, I
didn't see any practical way to use the CPU port for synchronization,
but I forget exactly the details. Maybe it is indeed possible,
somehow. If you can find a way that will work on your switch and on
the Marvell, then I'd like to hear about it.
Thinking back...
One problem is this. PTP requires a delay measurement. You can send
a delay request from the host, but there will never be a reply.
Another problem is this. A Sync message arriving on an external port
is time stamped there, but then it is encapsulated as a tagged DSA
management message and delivered out the CPU port. At this point, it
is no longer a PTP frame and will not be time stamped at the CPU port
on egress.
Thanks,
Richard
next prev parent reply other threads:[~2019-08-22 14:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-18 18:25 [PATCH spi for-5.4 0/5] Deterministic SPI latency with NXP DSPI driver Vladimir Oltean
2019-08-18 18:25 ` [PATCH spi for-5.4 1/5] spi: Use an abbreviated pointer to ctlr->cur_msg in __spi_pump_messages Vladimir Oltean
2019-08-20 18:21 ` Mark Brown
2019-08-20 19:36 ` Vladimir Oltean
2019-08-21 11:01 ` Mark Brown
2019-08-18 18:25 ` [PATCH spi for-5.4 2/5] spi: Add a PTP system timestamp to the transfer structure Vladimir Oltean
2019-08-22 17:11 ` Mark Brown
2019-08-24 12:38 ` Vladimir Oltean
2019-08-27 19:01 ` Mark Brown
2019-08-18 18:25 ` [PATCH spi for-5.4 3/5] spi: spi-fsl-dspi: Use poll mode in case the platform IRQ is missing Vladimir Oltean
2019-08-22 17:38 ` Mark Brown
2019-08-18 18:25 ` [PATCH spi for-5.4 4/5] spi: spi-fsl-dspi: Implement the PTP system timestamping for TCFQ mode Vladimir Oltean
2019-08-18 18:26 ` [PATCH spi for-5.4 5/5] spi: spi-fsl-dspi: Disable interrupts and preemption during poll mode transfer Vladimir Oltean
2019-08-20 15:57 ` [PATCH spi for-5.4 0/5] Deterministic SPI latency with NXP DSPI driver Vladimir Oltean
2019-08-20 16:57 ` Andrew Lunn
2019-08-21 4:38 ` Richard Cochran
2019-08-21 14:08 ` Richard Cochran
2019-08-21 20:17 ` Vladimir Oltean
2019-08-22 14:16 ` Richard Cochran [this message]
2019-08-22 14:56 ` Andrew Lunn
2019-08-22 14:58 ` Vladimir Oltean
2019-08-22 16:05 ` Richard Cochran
2019-08-22 16:13 ` Vladimir Oltean
2019-08-23 5:22 ` Richard Cochran
2019-08-24 12:13 ` Vladimir Oltean
2019-08-22 16:10 ` Richard Cochran
2019-08-21 4:42 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190822141641.GB1437@localhost \
--to=richardcochran@gmail.com \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=h.feurstein@gmail.com \
--cc=linux-spi@vger.kernel.org \
--cc=mlichvar@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.