From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAE11C3A5A1 for ; Thu, 22 Aug 2019 14:24:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CBD88233FE for ; Thu, 22 Aug 2019 14:24:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387939AbfHVOY1 (ORCPT ); Thu, 22 Aug 2019 10:24:27 -0400 Received: from mga09.intel.com ([134.134.136.24]:58859 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728042AbfHVOY1 (ORCPT ); Thu, 22 Aug 2019 10:24:27 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Aug 2019 07:24:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,416,1559545200"; d="scan'208";a="203429235" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.41]) by fmsmga004.fm.intel.com with ESMTP; 22 Aug 2019 07:24:21 -0700 Date: Thu, 22 Aug 2019 07:24:21 -0700 From: Sean Christopherson To: Jarkko Sakkinen Cc: linux-sgx@vger.kernel.org, Andy Lutomirski Subject: Re: [PATCH for_v22 v2 4/8] x86/sgx: Set SGX_ENCL_PAGE_TCS when allocating encl_page Message-ID: <20190822142421.GB25467@linux.intel.com> References: <20190813011252.4121-1-sean.j.christopherson@intel.com> <20190813011252.4121-5-sean.j.christopherson@intel.com> <20190822125613.4a36bg3ujoexzj27@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190822125613.4a36bg3ujoexzj27@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-sgx-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-sgx@vger.kernel.org On Thu, Aug 22, 2019 at 03:56:43PM +0300, Jarkko Sakkinen wrote: > On Mon, Aug 12, 2019 at 06:12:48PM -0700, Sean Christopherson wrote: > > Set SGX_ENCL_PAGE_TCS when encl_page->desc is initialized in > > sgx_encl_page_alloc() to improve readability, and so that the code > > isn't affected when the bulk of __sgx_encl_add_page() is rewritten > > to remove the EADD worker in a future patch. > > > > Signed-off-by: Sean Christopherson > > I don't mean to be impolite but this change only decreases readability, > and in no possible way improves it. Clear semantics and such things > improve readability No worries, it's not the first time my interpretation of what's readable has deviated from the norm :-)