From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 22 Aug 2019 16:29:58 +0100 From: John Levon Subject: Re: noreturn attribute doesn't work in smatch Message-ID: <20190822152958.GA12745@movementarian.org> References: <20190815005328.GA8004@movementarian.org> <20190815111237.GA20100@movementarian.org> <20190822132800.GJ4451@kadam> <20190822134603.GB9904@movementarian.org> <20190822150528.GL3964@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190822150528.GL3964@kadam> Sender: linux-sparse-owner@vger.kernel.org To: Dan Carpenter Cc: smatch@vger.kernel.org, linux-sparse@vger.kernel.org, yuri.pankov@nexenta.com List-ID: On Thu, Aug 22, 2019 at 06:05:29PM +0300, Dan Carpenter wrote: > On Thu, Aug 22, 2019 at 02:46:03PM +0100, John Levon wrote: > > On Thu, Aug 22, 2019 at 04:30:34PM +0300, Dan Carpenter wrote: > > > The code to handle that is really ancient. You need to do: > > > ./smatch --info test.c | tee warns.txt > > > grep no_return_funcs warns.txt || echo FAIL > > > ./smatch_scripts/gen_no_return_funcs.sh warns.txt -p=levon > > > mv levon.no_return_funcs smatch_data/ > > > > > > Then pass -p=levon to smatch on the next run. > > > > OK, thanks. That doesn't match too well with the way we use smatch, but > > this is much less of a big deal (I only needed to annotate this in a > > couple of places). > > It should be the the DB, right? Would that work for you? There's few enough that it's preferable to just explicitly mark the source as noreturn too, rather than keep a separate list. regards john