All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Alexander Viro <viro@zeniv.linux.org.uk>, linux-fsdevel@vger.kernel.org
Subject: [PATCH RESEND] fs/buffer.c: include fs/internal.h for missing prototypes
Date: Thu, 22 Aug 2019 08:39:26 -0700	[thread overview]
Message-ID: <20190822153926.14294-1-ebiggers@kernel.org> (raw)

From: Eric Biggers <ebiggers@google.com>

Include fs/internal.h to address the following 'sparse' warnings:

    fs/buffer.c:1930:5: warning: symbol '__block_write_begin_int' was not declared. Should it be static?
    fs/buffer.c:2089:6: warning: symbol '__generic_write_end' was not declared. Should it be static?
    fs/buffer.c:2998:6: warning: symbol 'guard_bio_eod' was not declared. Should it be static?

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 fs/buffer.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/buffer.c b/fs/buffer.c
index 0faa41fb4c88..95d08807863b 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -47,6 +47,8 @@
 #include <linux/sched/mm.h>
 #include <trace/events/block.h>
 
+#include "internal.h"
+
 static int fsync_buffers_list(spinlock_t *lock, struct list_head *list);
 static int submit_bh_wbc(int op, int op_flags, struct buffer_head *bh,
 			 enum rw_hint hint, struct writeback_control *wbc);
-- 
2.22.1


             reply	other threads:[~2019-08-22 15:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-22 15:39 Eric Biggers [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-01-10 20:40 [PATCH RESEND] fs/buffer.c: include fs/internal.h for missing prototypes Eric Biggers
2019-02-07 23:40 ` Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190822153926.14294-1-ebiggers@kernel.org \
    --to=ebiggers@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.