From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D708CC3A5A1 for ; Thu, 22 Aug 2019 17:39:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AFC4C20856 for ; Thu, 22 Aug 2019 17:39:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566495593; bh=fdh0V3NNj3S3TWTYIMZKPF+xDNg3aU1Dr7sFJazM2QI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=04PmwYAZnS4oz+Clah4a+tZvnmpu4f4UbrTRCXe0BcAQ1J26EBz2d5e8pWkO0tsUT ELXftM0kmICaXfixTMz5kwrEWUDDWehp8hRVpzH8DKDWeNy8ewtFSQdGy/6htIDYSY 5FmmHzf2d02DqG/1PHasQ1lMSI0Oq70DMQjLpVy0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392438AbfHVRjr (ORCPT ); Thu, 22 Aug 2019 13:39:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:46198 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404215AbfHVRYb (ORCPT ); Thu, 22 Aug 2019 13:24:31 -0400 Received: from localhost (wsip-184-188-36-2.sd.sd.cox.net [184.188.36.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C22AD23407; Thu, 22 Aug 2019 17:24:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566494670; bh=fdh0V3NNj3S3TWTYIMZKPF+xDNg3aU1Dr7sFJazM2QI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W7Cv9wfdHunnDXLx6XEg6H/vvcYdiLJT2Udbzp/tAERTjlguWAbK2pyfJyAQ5mX+/ 5++Ryu/CVLL2FaOn5jUQHnzjUbCM+dfbzhfNfR+cOCKOH1S9IJ58e4JgPOxn7NOAds RCD5YrVbNwJMLRPndEMtMsiQ/0qkNZUuVgipWoOg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hui Wang , Takashi Iwai Subject: [PATCH 4.14 13/71] ALSA: hda - Let all conexant codec enter D3 when rebooting Date: Thu, 22 Aug 2019 10:18:48 -0700 Message-Id: <20190822171727.654559000@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190822171726.131957995@linuxfoundation.org> References: <20190822171726.131957995@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hui Wang commit 401714d9534aad8c24196b32600da683116bbe09 upstream. We have 3 new lenovo laptops which have conexant codec 0x14f11f86, these 3 laptops also have the noise issue when rebooting, after letting the codec enter D3 before rebooting or poweroff, the noise disappers. Instead of adding a new ID again in the reboot_notify(), let us make this function apply to all conexant codec. In theory make codec enter D3 before rebooting or poweroff is harmless, and I tested this change on a couple of other Lenovo laptops which have different conexant codecs, there is no side effect so far. Cc: stable@vger.kernel.org Signed-off-by: Hui Wang Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/patch_conexant.c | 9 --------- 1 file changed, 9 deletions(-) --- a/sound/pci/hda/patch_conexant.c +++ b/sound/pci/hda/patch_conexant.c @@ -210,15 +210,6 @@ static void cx_auto_reboot_notify(struct { struct conexant_spec *spec = codec->spec; - switch (codec->core.vendor_id) { - case 0x14f12008: /* CX8200 */ - case 0x14f150f2: /* CX20722 */ - case 0x14f150f4: /* CX20724 */ - break; - default: - return; - } - /* Turn the problematic codec into D3 to avoid spurious noises from the internal speaker during (and after) reboot */ cx_auto_turn_eapd(codec, spec->num_eapds, spec->eapds, false);