From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 732A2C3A5A1 for ; Thu, 22 Aug 2019 17:35:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 40B4720856 for ; Thu, 22 Aug 2019 17:35:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566495338; bh=Lqhqryb78B7k7zekpbzy+H9JJH5FFlViKcIlItaGoIA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=sAIGU44oDkBRz7JzXUvH3gspGWgwFD9Qp2uUcMYK29y1c2xUBjmZ3k+tuUPt+f7su 3MCWkqzLl3hA3eE8EaUh1qb5iXLFlozEymn0ARR7g281bo9QlKJg5sMXcBqGAn+WxP S6agYwQLwzX7TyW7HF3Csbl6AohQ3cHeKxVmmTB4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392425AbfHVRfh (ORCPT ); Thu, 22 Aug 2019 13:35:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:47942 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391829AbfHVRZF (ORCPT ); Thu, 22 Aug 2019 13:25:05 -0400 Received: from localhost (wsip-184-188-36-2.sd.sd.cox.net [184.188.36.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8F97E2341F; Thu, 22 Aug 2019 17:25:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566494704; bh=Lqhqryb78B7k7zekpbzy+H9JJH5FFlViKcIlItaGoIA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kpSCT1O8GueukkbN8FeDUCIt5uaKhwxBSLwzrYw6gS3WaPLMuLj+YM6BrduJbFslI qAr5wc/1J685clEpz86CCVJJK0EcpQxv58lQcda1qMYBNa6/FV46yJKu0p00i9FLHo al4uQ3d3I2za0tcH9GMRO8gFGTv5/qFHsbY9mnNI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , YueHaibing , Dmitry Torokhov , Hui Wang Subject: [PATCH 4.14 59/71] Input: psmouse - fix build error of multiple definition Date: Thu, 22 Aug 2019 10:19:34 -0700 Message-Id: <20190822171730.332203555@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190822171726.131957995@linuxfoundation.org> References: <20190822171726.131957995@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: YueHaibing commit 49e6979e7e92cf496105b5636f1df0ac17c159c0 upstream. trackpoint_detect() should be static inline while CONFIG_MOUSE_PS2_TRACKPOINT is not set, otherwise, we build fails: drivers/input/mouse/alps.o: In function `trackpoint_detect': alps.c:(.text+0x8e00): multiple definition of `trackpoint_detect' drivers/input/mouse/psmouse-base.o:psmouse-base.c:(.text+0x1b50): first defined here Reported-by: Hulk Robot Fixes: 55e3d9224b60 ("Input: psmouse - allow disabing certain protocol extensions") Signed-off-by: YueHaibing Signed-off-by: Dmitry Torokhov Cc: Hui Wang Signed-off-by: Greg Kroah-Hartman --- drivers/input/mouse/trackpoint.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/input/mouse/trackpoint.h +++ b/drivers/input/mouse/trackpoint.h @@ -161,7 +161,8 @@ struct trackpoint_data { #ifdef CONFIG_MOUSE_PS2_TRACKPOINT int trackpoint_detect(struct psmouse *psmouse, bool set_properties); #else -inline int trackpoint_detect(struct psmouse *psmouse, bool set_properties) +static inline int trackpoint_detect(struct psmouse *psmouse, + bool set_properties) { return -ENOSYS; }