From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v2 15/50] drm/bridge: tfp410: Replace manual connector handling with bridge Date: Thu, 22 Aug 2019 18:36:45 +0200 Message-ID: <20190822183645.0672b546@collabora.com> References: <20190820011721.30136-1-laurent.pinchart@ideasonboard.com> <20190820011721.30136-16-laurent.pinchart@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4374C6E532 for ; Thu, 22 Aug 2019 16:36:50 +0000 (UTC) In-Reply-To: <20190820011721.30136-16-laurent.pinchart@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: Maxime Ripard , Tomi Valkeinen , Sean Paul , Sebastian Reichel , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAyMCBBdWcgMjAxOSAwNDoxNjo0NiArMDMwMApMYXVyZW50IFBpbmNoYXJ0IDxsYXVy ZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+IHdyb3RlOgoKPiBOb3cgdGhhdCBhIGRyaXZl ciBpcyBhdmFpbGFibGUgZm9yIGRpc3BsYXkgY29ubmVjdG9ycywgcmVwbGFjZSB0aGUKPiBtYW51 YWwgY29ubmVjdG9yIGhhbmRsaW5nIGNvZGUgd2l0aCB1c2FnZSBvZiB0aGUgRFJNIGJyaWRnZSBB UEkuIFRoZQo+IHRmcDQxMCBkcml2ZXIgZG9lc24ndCBkZWFsIHdpdGggdGhlIGRpc3BsYXkgY29u bmVjdG9yIGRpcmVjdGx5IGFueW1vcmUsCj4gYnV0IHN0aWxsIGRlbGVnYXRlcyBkcm1fY29ubmVj dG9yIG9wZXJhdGlvbnMgdG8gdGhlIG5leHQgYnJpZGdlLiBUaGlzCj4gYnJpbmdzIHVzIG9uZSBz dGVwIGNsb3NlciB0byBoYXZpbmcgdGhlIHRmcDQxMCBkcml2ZXIgaGFuZGxpbmcgdGhlCj4gVEZQ NDEwIG9ubHkuCj4gCj4gU2lnbmVkLW9mZi1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5w aW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdl L3RpLXRmcDQxMC5jIHwgMTk1ICsrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmls ZSBjaGFuZ2VkLCA2OCBpbnNlcnRpb25zKCspLCAxMjcgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvdGktdGZwNDEwLmMgYi9kcml2ZXJzL2dwdS9k cm0vYnJpZGdlL3RpLXRmcDQxMC5jCj4gaW5kZXggNGE0NjhmNDRlZjY5Li42NTY1MWFlNmM1NTMg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS90aS10ZnA0MTAuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvdGktdGZwNDEwLmMKPiBAQCAtNCwxNCArNCwxMiBAQAo+ ICAgKiBBdXRob3I6IEp5cmkgU2FyaGEgPGpzYXJoYUB0aS5jb20+Cj4gICAqLwo+ICAKPiAtI2lu Y2x1ZGUgPGxpbnV4L2RlbGF5Lmg+Cj4gLSNpbmNsdWRlIDxsaW51eC9md25vZGUuaD4KPiAgI2lu Y2x1ZGUgPGxpbnV4L2dwaW8vY29uc3VtZXIuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L2kyYy5oPgo+ IC0jaW5jbHVkZSA8bGludXgvaXJxLmg+Cj4gICNpbmNsdWRlIDxsaW51eC9tb2R1bGUuaD4KPiAg I2luY2x1ZGUgPGxpbnV4L29mX2dyYXBoLmg+Cj4gICNpbmNsdWRlIDxsaW51eC9wbGF0Zm9ybV9k ZXZpY2UuaD4KPiArI2luY2x1ZGUgPGxpbnV4L3dvcmtxdWV1ZS5oPgo+ICAKPiAgI2luY2x1ZGUg PGRybS9kcm1fYXRvbWljX2hlbHBlci5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9icmlkZ2UuaD4K PiBAQCAtMjQsMTYgKzIyLDEzIEBACj4gIHN0cnVjdCB0ZnA0MTAgewo+ICAJc3RydWN0IGRybV9i cmlkZ2UJYnJpZGdlOwo+ICAJc3RydWN0IGRybV9jb25uZWN0b3IJY29ubmVjdG9yOwo+IC0JdW5z aWduZWQgaW50CQljb25uZWN0b3JfdHlwZTsKPiAgCj4gIAl1MzIJCQlidXNfZm9ybWF0Owo+IC0J c3RydWN0IGkyY19hZGFwdGVyCSpkZGM7Cj4gLQlzdHJ1Y3QgZ3Bpb19kZXNjCSpocGQ7Cj4gLQlp bnQJCQlocGRfaXJxOwo+ICAJc3RydWN0IGRlbGF5ZWRfd29yawlocGRfd29yazsKPiAgCXN0cnVj dCBncGlvX2Rlc2MJKnBvd2VyZG93bjsKPiAgCj4gIAlzdHJ1Y3QgZHJtX2JyaWRnZV90aW1pbmdz IHRpbWluZ3M7Cj4gKwlzdHJ1Y3QgZHJtX2JyaWRnZQkqbmV4dF9icmlkZ2U7Cj4gIAo+ICAJc3Ry dWN0IGRldmljZSAqZGV2Owo+ICB9Owo+IEBAIC01NiwxMCArNTEsMTAgQEAgc3RhdGljIGludCB0 ZnA0MTBfZ2V0X21vZGVzKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IpCj4gIAlzdHJ1 Y3QgZWRpZCAqZWRpZDsKPiAgCWludCByZXQ7Cj4gIAo+IC0JaWYgKCFkdmktPmRkYykKPiArCWlm ICghKGR2aS0+bmV4dF9icmlkZ2UtPm9wcyAmIERSTV9CUklER0VfT1BfRURJRCkpCj4gIAkJZ290 byBmYWxsYmFjazsKPiAgCj4gLQllZGlkID0gZHJtX2dldF9lZGlkKGNvbm5lY3RvciwgZHZpLT5k ZGMpOwo+ICsJZWRpZCA9IGR2aS0+bmV4dF9icmlkZ2UtPmZ1bmNzLT5nZXRfZWRpZChkdmktPm5l eHRfYnJpZGdlLCBjb25uZWN0b3IpOwoKQ2FuIHdlIGNyZWF0ZSBhIGRybV9icmlkZ2VfZ2V0X2Vk aWQoKSB3cmFwcGVyIGZvciB0aGF0PwpTb21ldGhpbmcgbGlrZToKCmludCBkcm1fYnJpZGdlX2dl dF9lZGlkKHN0cnVjdCBkcm1fYnJpZGdlICpicmlkZ2UsCgkJCXN0cnVjdCBkcm1fY29ubmVjdG9y ICpjb25uKQp7CglpZiAoIShkdmktPm5leHRfYnJpZGdlLT5vcHMgJiBEUk1fQlJJREdFX09QX0VE SUQpKQoJCXJldHVybiAtRU5PVFNVUFA7CgoJcmV0dXJuIGJyaWRnZS0+ZnVuY3MtPmdldF9lZGlk KGJyaWRnZSwgY29ubmVjdG9yKTsKfQoKPiAgCWlmICghZWRpZCkgewo+ICAJCWRldl9pbmZvKGR2 aS0+ZGV2LAo+ICAJCQkgIkVESUQgcmVhZCBmYWlsZWQuIEZhbGxiYWNrIHRvIHN0YW5kYXJkIG1v ZGVzXG4iKTsKPiBAQCAtOTMsMjEgKzg4LDEwIEBAIHRmcDQxMF9jb25uZWN0b3JfZGV0ZWN0KHN0 cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsIGJvb2wgZm9yY2UpCj4gIHsKPiAgCXN0cnVj dCB0ZnA0MTAgKmR2aSA9IGRybV9jb25uZWN0b3JfdG9fdGZwNDEwKGNvbm5lY3Rvcik7Cj4gIAo+ IC0JaWYgKGR2aS0+aHBkKSB7Cj4gLQkJaWYgKGdwaW9kX2dldF92YWx1ZV9jYW5zbGVlcChkdmkt PmhwZCkpCj4gLQkJCXJldHVybiBjb25uZWN0b3Jfc3RhdHVzX2Nvbm5lY3RlZDsKPiAtCQllbHNl Cj4gLQkJCXJldHVybiBjb25uZWN0b3Jfc3RhdHVzX2Rpc2Nvbm5lY3RlZDsKPiAtCX0KPiArCWlm ICghKGR2aS0+bmV4dF9icmlkZ2UtPm9wcyAmIERSTV9CUklER0VfT1BfREVURUNUKSkKPiArCQly ZXR1cm4gY29ubmVjdG9yX3N0YXR1c191bmtub3duOwo+ICAKPiAtCWlmIChkdmktPmRkYykgewo+ IC0JCWlmIChkcm1fcHJvYmVfZGRjKGR2aS0+ZGRjKSkKPiAtCQkJcmV0dXJuIGNvbm5lY3Rvcl9z dGF0dXNfY29ubmVjdGVkOwo+IC0JCWVsc2UKPiAtCQkJcmV0dXJuIGNvbm5lY3Rvcl9zdGF0dXNf ZGlzY29ubmVjdGVkOwo+IC0JfQo+IC0KPiAtCXJldHVybiBjb25uZWN0b3Jfc3RhdHVzX3Vua25v d247Cj4gKwlyZXR1cm4gZHZpLT5uZXh0X2JyaWRnZS0+ZnVuY3MtPmRldGVjdChkdmktPm5leHRf YnJpZGdlKTsKClNhbWUgaGVyZSBmb3IgdGhlIGRldGVjdCBob29rLgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs