All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Biwen Li <biwen.li@nxp.com>
Cc: a.zummo@towertech.it, leoyang.li@nxp.com, robh+dt@kernel.org,
	linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
	xiaobo.xie@nxp.com, jiafei.pan@nxp.com, ran.wang_1@nxp.com,
	mark.rutland@arm.com, devicetree@vger.kernel.org
Subject: Re: [v7,1/2] rtc/fsl: add FTM alarm driver as the wakeup source
Date: Thu, 22 Aug 2019 23:12:16 +0200	[thread overview]
Message-ID: <20190822211216.GC27031@piout.net> (raw)
In-Reply-To: <20190813030157.48590-1-biwen.li@nxp.com>

On 13/08/2019 11:01:56+0800, Biwen Li wrote:
> For the paltforms including LS1012A, LS1021A, LS1028A, LS1043A,
> LS1046A, LS1088A, LS208xA that has the FlexTimer
> module, implementing alarm functions within RTC subsystem
> to wakeup the system when system going to sleep (work with RCPM driver).
> 
> Signed-off-by: Biwen Li <biwen.li@nxp.com>
> ---
> Change in v7:
>     - None
> 
> Change in v6:
>     - None
> 
> Change in v5:
>     - replace devm_rtc_device_register with devm_rtc_allocate_device
>     and rtc_register_device
> 
> Change in v4:
>     - clean code
>     - correct requesting irq
>     - register as a regular RTC driver
>     - change return value of ftm_rtc_set_alarm from -EINVAL to -ERANGE
>     - replace pr_err with dev_err
>     - sort alphabetically
>     - auto select RCPM driver
>     - correct UTC time in ftm_rtc_read_time
> 
> Change in v3:
> 	- add some comments about clock source and errata
> 	- adjust format
> 	- replace endian with big_endian of struct ftm_rtc
> 	- remove compatible "fsl,ftm-alarm"
> 
> Change in v2:
> 	- remove code about setting rcpm
> 
>  drivers/rtc/Kconfig             |  15 ++
>  drivers/rtc/Makefile            |   1 +
>  drivers/rtc/rtc-fsl-ftm-alarm.c | 336 ++++++++++++++++++++++++++++++++
>  3 files changed, 352 insertions(+)
>  create mode 100644 drivers/rtc/rtc-fsl-ftm-alarm.c
> 
Applied, thanks.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      parent reply	other threads:[~2019-08-22 21:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-13  3:01 [v7,1/2] rtc/fsl: add FTM alarm driver as the wakeup source Biwen Li
2019-08-13  3:01 ` [v7,2/2] dt-bindings: rtc: add bindings for FlexTimer Module Biwen Li
2019-08-22 21:12   ` Alexandre Belloni
2019-08-22 21:12 ` Alexandre Belloni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190822211216.GC27031@piout.net \
    --to=alexandre.belloni@bootlin.com \
    --cc=a.zummo@towertech.it \
    --cc=biwen.li@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jiafei.pan@nxp.com \
    --cc=leoyang.li@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=ran.wang_1@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=xiaobo.xie@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.