From: Ricardo Ribalda Delgado <ribalda@kernel.org>
To: Philipp Zabel <p.zabel@pengutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Jacopo Mondi <jacopo@jmondi.org>
Cc: Ricardo Ribalda Delgado <ribalda@kernel.org>
Subject: [PATCH v3 7/7] imx214: Use v4l2_ctrl_new_area helper
Date: Fri, 23 Aug 2019 14:37:37 +0200 [thread overview]
Message-ID: <20190823123737.7774-7-ribalda@kernel.org> (raw)
In-Reply-To: <20190823123737.7774-1-ribalda@kernel.org>
Instead of creating manually the V4L2_CID_UNIT_CELL_SIZE control, lets
use the helper.
Signed-off-by: Ricardo Ribalda Delgado <ribalda@kernel.org>
---
drivers/media/i2c/imx214.c | 29 ++++++++---------------------
1 file changed, 8 insertions(+), 21 deletions(-)
diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c
index cc0a013ba7da..625617d4c81a 100644
--- a/drivers/media/i2c/imx214.c
+++ b/drivers/media/i2c/imx214.c
@@ -942,26 +942,6 @@ static int __maybe_unused imx214_resume(struct device *dev)
return ret;
}
-static void unit_size_init(const struct v4l2_ctrl *ctrl, u32 idx,
- union v4l2_ctrl_ptr ptr)
-{
- ptr.p_area->width = 1120;
- ptr.p_area->height = 1120;
-}
-
-static const struct v4l2_ctrl_type_ops unit_size_ops = {
- .init = unit_size_init,
-};
-
-static struct v4l2_ctrl *new_unit_size_ctrl(struct v4l2_ctrl_handler *handler)
-{
- static struct v4l2_ctrl_config ctrl = {
- .id = V4L2_CID_UNIT_CELL_SIZE,
- .type_ops = &unit_size_ops,
- };
-
- return v4l2_ctrl_new_custom(handler, &ctrl, NULL);
-}
static int imx214_probe(struct i2c_client *client)
{
struct device *dev = &client->dev;
@@ -969,6 +949,10 @@ static int imx214_probe(struct i2c_client *client)
static const s64 link_freq[] = {
IMX214_DEFAULT_LINK_FREQ,
};
+ struct v4l2_area unit_size = {
+ .width = 1120,
+ .height = 1120,
+ };
int ret;
ret = imx214_parse_fwnode(dev);
@@ -1050,7 +1034,10 @@ static int imx214_probe(struct i2c_client *client)
V4L2_CID_EXPOSURE,
0, 3184, 1, 0x0c70);
- imx214->unit_size = new_unit_size_ctrl(&imx214->ctrls);
+ imx214->unit_size = v4l2_ctrl_new_area(&imx214->ctrls,
+ &imx214_ctrl_ops,
+ V4L2_CID_UNIT_CELL_SIZE,
+ &unit_size);
ret = imx214->ctrls.error;
if (ret) {
--
2.23.0.rc1
next prev parent reply other threads:[~2019-08-23 12:38 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 12:37 [PATCH v3 1/7] media: add V4L2_CID_UNIT_CELL_SIZE control Ricardo Ribalda Delgado
2019-08-23 12:37 ` [PATCH v3 2/7] Documentation: media: Describe V4L2_CID_UNIT_CELL_SIZE Ricardo Ribalda Delgado
2019-08-23 12:56 ` Philipp Zabel
2019-08-23 12:37 ` [PATCH v3 3/7] Documentation: media: Document V4L2_CTRL_TYPE_AREA Ricardo Ribalda Delgado
2019-08-23 12:56 ` Philipp Zabel
2019-08-26 7:40 ` Jacopo Mondi
2019-09-12 10:51 ` Ricardo Ribalda Delgado
2019-09-12 11:00 ` Hans Verkuil
2019-08-23 12:37 ` [PATCH v3 4/7] media: imx214: Add new control with V4L2_CID_UNIT_CELL_SIZE Ricardo Ribalda Delgado
2019-08-23 12:56 ` Philipp Zabel
2019-08-23 12:37 ` [PATCH v3 5/7] media: v4l2-core: Add new helper for area controls Ricardo Ribalda Delgado
2019-08-23 12:56 ` Philipp Zabel
2019-08-23 13:05 ` Ricardo Ribalda Delgado
2019-08-23 13:13 ` Philipp Zabel
2019-08-26 7:43 ` Jacopo Mondi
2019-08-29 10:57 ` Hans Verkuil
2019-08-23 12:37 ` [PATCH v3 6/7] Documentation: Document v4l2_ctrl_new area Ricardo Ribalda Delgado
2019-08-26 7:46 ` Jacopo Mondi
2019-08-23 12:37 ` Ricardo Ribalda Delgado [this message]
2019-08-26 7:54 ` [PATCH v3 7/7] imx214: Use v4l2_ctrl_new_area helper Jacopo Mondi
2019-08-26 7:12 ` [PATCH v3 1/7] media: add V4L2_CID_UNIT_CELL_SIZE control Jacopo Mondi
2019-08-26 7:30 ` Jacopo Mondi
2019-08-29 10:39 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190823123737.7774-7-ribalda@kernel.org \
--to=ribalda@kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo@jmondi.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.