All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Longerbeam <slongerbeam@gmail.com>
To: linux-media@vger.kernel.org
Cc: Steve Longerbeam <slongerbeam@gmail.com>
Subject: [PATCH v2 0/2] media: imx: Fix subdev unregister/register issues
Date: Sat, 24 Aug 2019 09:33:35 -0700	[thread overview]
Message-ID: <20190824163337.8260-1-slongerbeam@gmail.com> (raw)

If the media device module is removed and re-probed without also removing
and re-probing the subdevice modules, .unregister() and .register() ops
are called on the subdevices without the subdevice drivers being removed
and re-probed. This creates two problems:

- the CSI and PRPENCVF subdevices attempt to register a stale video capture
  device resulting in the kobject "tried to init an initialized object"
  backtrace.

- pad graph objects are added to the media device pad list twice, resulting
  in list corruption on the pad list.

The following two patches fix those issues.

History:
v2:
- Add missing local var ic_priv in prp_registered() in first patch.

Steve Longerbeam (2):
  media: imx: Move capture device init to registered
  media: imx: Move pads init to probe

 drivers/staging/media/imx/imx-ic-prp.c        | 25 ++++-----
 drivers/staging/media/imx/imx-ic-prpencvf.c   | 51 ++++++++++---------
 drivers/staging/media/imx/imx-media-capture.c | 15 +++---
 drivers/staging/media/imx/imx-media-csi.c     | 35 +++++++------
 drivers/staging/media/imx/imx-media-vdic.c    | 27 ++++------
 drivers/staging/media/imx/imx6-mipi-csi2.c    | 27 +++++-----
 drivers/staging/media/imx/imx7-media-csi.c    | 38 +++++++-------
 drivers/staging/media/imx/imx7-mipi-csis.c    | 23 +++------
 8 files changed, 114 insertions(+), 127 deletions(-)

-- 
2.17.1


             reply	other threads:[~2019-08-24 16:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-24 16:33 Steve Longerbeam [this message]
2019-08-24 16:33 ` [PATCH v2 1/2] media: imx: Move capture device init to registered Steve Longerbeam
2019-08-24 16:33   ` Steve Longerbeam
2019-08-24 16:33 ` [PATCH v2 2/2] media: imx: Move pads init to probe Steve Longerbeam
2019-08-24 16:33   ` Steve Longerbeam
2019-08-27 10:18 ` [PATCH v2 0/2] media: imx: Fix subdev unregister/register issues Rui Miguel Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190824163337.8260-1-slongerbeam@gmail.com \
    --to=slongerbeam@gmail.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.