From: Marek Behun <marek.behun@nic.cz>
To: Vivien Didelot <vivien.didelot@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>
Subject: Re: [PATCH net-next v2 3/9] net: dsa: mv88e6xxx: fix port hidden register macros
Date: Sat, 24 Aug 2019 22:54:22 +0200 [thread overview]
Message-ID: <20190824225422.06b2aefd@nic.cz> (raw)
In-Reply-To: <20190824153254.GB32555@t480s.localdomain>
On Sat, 24 Aug 2019 15:32:54 -0400
Vivien Didelot <vivien.didelot@gmail.com> wrote:
> You are already using these macros in the previous patch. I guess you meant
> to introduce this patch before. But since you are moving and renaming the
> same code without functional changes, you may squash them together.
Hm, you are right, I accidently created a commit which would not
build. :( I thought that I tried to build after each commit, but it
seems I forgot at least one.
next prev parent reply other threads:[~2019-08-24 20:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 21:25 [PATCH net-next v2 0/9] net: dsa: mv88e6xxx: Peridot/Topaz SERDES changes Marek Behún
2019-08-23 21:25 ` [PATCH net-next v2 1/9] net: dsa: mv88e6xxx: support 2500base-x in SGMII IRQ handler Marek Behún
2019-08-23 21:25 ` [PATCH net-next v2 2/9] net: dsa: mv88e6xxx: move hidden registers operations in own file Marek Behún
2019-08-23 21:25 ` [PATCH net-next v2 3/9] net: dsa: mv88e6xxx: fix port hidden register macros Marek Behún
2019-08-24 19:32 ` Vivien Didelot
2019-08-24 20:54 ` Marek Behun [this message]
2019-08-23 21:25 ` [PATCH net-next v2 4/9] net: dsa: mv88e6xxx: create chip->info->ops->serdes_get_lane method Marek Behún
2019-08-24 19:45 ` Vivien Didelot
2019-08-24 19:52 ` Vivien Didelot
2019-08-23 21:25 ` [PATCH net-next v2 5/9] net: dsa: mv88e6xxx: add serdes_get_lane method for Topaz family Marek Behún
2019-08-23 21:26 ` [PATCH net-next v2 6/9] net: dsa: mv88e6xxx: rename port cmode macro Marek Behún
2019-08-23 21:26 ` [PATCH net-next v2 7/9] net: dsa: mv88e6xxx: simplify SERDES code for Topaz and Peridot Marek Behún
2019-08-23 21:26 ` [PATCH net-next v2 8/9] net: dsa: mv88e6xxx: support Block Address setting in hidden registers Marek Behún
2019-08-24 20:13 ` Vivien Didelot
2019-08-24 20:52 ` Marek Behun
2019-08-24 21:36 ` Vivien Didelot
2019-08-23 21:26 ` [PATCH net-next v2 9/9] net: dsa: mv88e6xxx: fully support SERDES on Topaz family Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190824225422.06b2aefd@nic.cz \
--to=marek.behun@nic.cz \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.