All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Mario Tesi <martepisa@gmail.com>,
	lorenzo.bianconi83@gmail.com, knaack.h@gmx.de, lars@metafoo.de,
	pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org, mario.tesi@st.com
Subject: Re: [PATCH] iio: imu: st_lsm6dsx: Fix FIFO diff mask for tagged fifo
Date: Mon, 26 Aug 2019 09:58:02 +0100	[thread overview]
Message-ID: <20190826095802.7aac9045@archlinux> (raw)
In-Reply-To: <20190826082220.GA5328@localhost.localdomain>

On Mon, 26 Aug 2019 10:22:20 +0200
Lorenzo Bianconi <lorenzo@kernel.org> wrote:

> > On Thu, 22 Aug 2019 15:22:19 +0200
> > Mario Tesi <martepisa@gmail.com> wrote:
> >   
> > > From: mario tesi <mario.tesi@st.com>
> > > 
> > > 	According to the latest version of datasheet the mask
> > > 	for number of unread sensor data in FIFO_STATUS registers
> > > 	has been extended to 10 bits
> > > 
> > > 	The devices involved are:
> > > 	 - LSM6DSO
> > > 	 - LSM6DSOX
> > > 	 - ASM330LHH
> > > 	 - LSM6DSR
> > > 	 - ISM330DHCX
> > > 
> > > Signed-off-by: mario tesi <mario.tesi@st.com>  
> > 
> > Seems straight forward and should be side effect free I think.
> > Hence I won't wait for Lorenzo to take a look (though there
> > is still a small window for comments whilst the autobuilders
> > poke at it!)
> > 
> > Applied to the togreg branch of iio.git and pushed out as testing
> > for the autobuilders to take a look.
> > 
> > Thanks,  
> 
> Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>

Nice. That was fast enough that I haven't applied any patches on
top of Mario's yet so a quick git --amend job ;)

Thanks,

Jonathan

> 
> > 
> > Jonathan
> >   
> > > ---
> > >  drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > index 85824d6..47b77d0 100644
> > > --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c
> > > @@ -497,7 +497,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
> > >  			},
> > >  			.fifo_diff = {
> > >  				.addr = 0x3a,
> > > -				.mask = GENMASK(8, 0),
> > > +				.mask = GENMASK(9, 0),
> > >  			},
> > >  			.th_wl = 1,
> > >  		},
> > > @@ -623,7 +623,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
> > >  			},
> > >  			.fifo_diff = {
> > >  				.addr = 0x3a,
> > > -				.mask = GENMASK(8, 0),
> > > +				.mask = GENMASK(9, 0),
> > >  			},
> > >  			.th_wl = 1,
> > >  		},
> > > @@ -726,7 +726,7 @@ static const struct st_lsm6dsx_settings st_lsm6dsx_sensor_settings[] = {
> > >  			},
> > >  			.fifo_diff = {
> > >  				.addr = 0x3a,
> > > -				.mask = GENMASK(8, 0),
> > > +				.mask = GENMASK(9, 0),
> > >  			},
> > >  			.th_wl = 1,
> > >  		},  
> >   


      reply	other threads:[~2019-08-26  8:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-22 13:22 [PATCH] iio: imu: st_lsm6dsx: Fix FIFO diff mask for tagged fifo Mario Tesi
2019-08-26  8:15 ` Jonathan Cameron
2019-08-26  8:22   ` Lorenzo Bianconi
2019-08-26  8:58     ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190826095802.7aac9045@archlinux \
    --to=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo.bianconi83@gmail.com \
    --cc=lorenzo@kernel.org \
    --cc=mario.tesi@st.com \
    --cc=martepisa@gmail.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.