All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
	Yang Guo <guoyang2@huawei.com>,
	Andreas Dilger <adilger.kernel@dilger.ca>
Subject: Re: [PATCH] ext4: change the type of ext4 cache stats to percpu_counter to improve performance
Date: Mon, 26 Aug 2019 11:57:28 -0400	[thread overview]
Message-ID: <20190826155728.GE4918@mit.edu> (raw)
In-Reply-To: <f0495aa7-8f21-e938-9617-07ac8741acb7@hisilicon.com>

On Mon, Aug 26, 2019 at 04:24:20PM +0800, Shaokun Zhang wrote:
> > The other problem with this patch is that it initializes
> > es_stats_cache_hits and es_stats_cache_miesses too late.  They will
> > get used when the journal inode is loaded.  This is mostly harmless,
> 
> I have checked it again, @es_stats_cache_hits and @es_stats_cache_miesses
> have been initialized before the journal inode is loaded, Maybe I miss
> something else?

No, sorry, that was my mistake.  I misread things when I was looking
over your patch last night.

Please resubmit your patch once you've fixed things up and tested it.

I would recommend that you at least try running your patch using the
kvm-xfstests's smoke test[1] before submitting them.  It will save you
and me time.

[1] https://github.com/tytso/xfstests-bld/blob/master/Documentation/kvm-quickstart.md

Thanks,

					- Ted
					

  reply	other threads:[~2019-08-26 15:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-23  2:47 [PATCH] ext4: change the type of ext4 cache stats to percpu_counter to improve performance Shaokun Zhang
2019-08-25  3:25 ` Theodore Y. Ts'o
2019-08-25 17:28   ` Eric Biggers
2019-08-26  0:47     ` Theodore Y. Ts'o
2019-08-26  8:24       ` Shaokun Zhang
2019-08-26 15:57         ` Theodore Y. Ts'o [this message]
2019-08-27  5:46           ` Shaokun Zhang
2019-08-26  8:12     ` Shaokun Zhang
2019-08-30  3:11 ` [LTP] [ext4] [confidence: ] 2f7f60cf9f: WARNING:at_lib/list_debug.c:#__list_add_valid kernel test robot
2019-08-30  3:11   ` kernel test robot
2019-08-30  3:11   ` kernel test robot
2019-08-30  3:33   ` Shaokun Zhang
2019-08-30  3:33     ` Shaokun Zhang
2019-08-30  3:33     ` [LTP] " Shaokun Zhang
2019-08-30  4:37     ` Oliver Sang
2019-08-30  4:37       ` Oliver Sang
2019-08-30  4:37       ` [LTP] " Oliver Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190826155728.GE4918@mit.edu \
    --to=tytso@mit.edu \
    --cc=adilger.kernel@dilger.ca \
    --cc=guoyang2@huawei.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zhangshaokun@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.