From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] ARM: omap2: move platform-specific asm-offset.h to arch/arm/mach-omap2 Date: Mon, 26 Aug 2019 09:20:21 -0700 Message-ID: <20190826162021.GW52127@atomide.com> References: <20190823025808.11875-1-yamada.masahiro@socionext.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190823025808.11875-1-yamada.masahiro@socionext.com> Sender: linux-kernel-owner@vger.kernel.org To: Masahiro Yamada Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Russell King , linux-kernel@vger.kernel.org List-Id: linux-omap@vger.kernel.org * Masahiro Yamada [190822 19:59]: > is only generated and included by > arch/arm/mach-omap2/, so it does not need to reside in the globally > visible include/generated/. > > I renamed it to arch/arm/mach-omap2/pm-asm-offsets.h since the prefix > 'ti-' is just redundant in mach-omap2/. > > My main motivation of this change is to avoid the race condition for > the parallel build (-j) when CONFIG_IKHEADERS is enabled. > > When it is enabled, all the headers under include/ are archived into > kernel/kheaders_data.tar.xz and exposed in the sysfs. > > In the parallel build, we have no idea in which order files are built. > > - If ti-pm-asm-offsets.h is built before kheaders_data.tar.xz, > the header will be included in the archive. Probably nobody will > use it, but it is harmless except that it will increase the archive > size needlessly. > > - If kheaders_data.tar.xz is built before ti-pm-asm-offsets.h, > the header will not be included in the archive. However, in the next > build, the archive will be re-generated to include the newly-found > ti-pm-asm-offsets.h. This is not nice from the build system point > of view. > > - If ti-pm-asm-offsets.h and kheaders_data.tar.xz are built at the > same time, the corrupted header might be included in the archive, > which does not look nice either. > > This commit fixes the race. > > Signed-off-by: Masahiro Yamada > Tested-by: Keerthy Applying into omap-for-v5.4/soc thanks. The commit is on top of v5.3-rc1 so it can be merged into other branches if needed after it's been sitting in Linux next for few days with no issues. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC9B3C3A59F for ; Mon, 26 Aug 2019 16:20:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF5742173E for ; Mon, 26 Aug 2019 16:20:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="H+gbinO6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF5742173E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pOwsGfXRLXsh8Eyb1Uyu0RDC3gd8/J8s2VuOyY+phB0=; b=H+gbinO6p5jJff LKWa5F69Aiz2fNidGBo24DhF/S2WJxNsdqtE0EQd2ZQuTgVXVxPxXB3cUZb5irGTe0GAm7amereCw EiNWLkB/hcBll/luTkQ2YDXtn+7G8ZfPa1TFaiMqupGumg+tD/mlT1fObZOKJ5YfiJSwOvhrC3wiq LmVycshxUaZN5EPNssMXmDOGjjEdfuKBG2MGUoRDThtqNRcLL+2SY0OO+mJu49B47X7N2WSyvyYf4 V2+93w6jkmDq71OF9pLyHCgzW6Zym+/1+kTzI33N4tJ+OBY30WbHXV8yoTr731qB0MZDohJLGX7h3 yxlhZPaWj0TRGpfRbNig==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i2HjL-00048Q-Bk; Mon, 26 Aug 2019 16:20:31 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i2HjH-00047a-4R for linux-arm-kernel@lists.infradead.org; Mon, 26 Aug 2019 16:20:28 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 6611780AA; Mon, 26 Aug 2019 16:20:53 +0000 (UTC) Date: Mon, 26 Aug 2019 09:20:21 -0700 From: Tony Lindgren To: Masahiro Yamada Subject: Re: [PATCH] ARM: omap2: move platform-specific asm-offset.h to arch/arm/mach-omap2 Message-ID: <20190826162021.GW52127@atomide.com> References: <20190823025808.11875-1-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190823025808.11875-1-yamada.masahiro@socionext.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190826_092027_218195_71BB7357 X-CRM114-Status: GOOD ( 15.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-omap@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Masahiro Yamada [190822 19:59]: > is only generated and included by > arch/arm/mach-omap2/, so it does not need to reside in the globally > visible include/generated/. > > I renamed it to arch/arm/mach-omap2/pm-asm-offsets.h since the prefix > 'ti-' is just redundant in mach-omap2/. > > My main motivation of this change is to avoid the race condition for > the parallel build (-j) when CONFIG_IKHEADERS is enabled. > > When it is enabled, all the headers under include/ are archived into > kernel/kheaders_data.tar.xz and exposed in the sysfs. > > In the parallel build, we have no idea in which order files are built. > > - If ti-pm-asm-offsets.h is built before kheaders_data.tar.xz, > the header will be included in the archive. Probably nobody will > use it, but it is harmless except that it will increase the archive > size needlessly. > > - If kheaders_data.tar.xz is built before ti-pm-asm-offsets.h, > the header will not be included in the archive. However, in the next > build, the archive will be re-generated to include the newly-found > ti-pm-asm-offsets.h. This is not nice from the build system point > of view. > > - If ti-pm-asm-offsets.h and kheaders_data.tar.xz are built at the > same time, the corrupted header might be included in the archive, > which does not look nice either. > > This commit fixes the race. > > Signed-off-by: Masahiro Yamada > Tested-by: Keerthy Applying into omap-for-v5.4/soc thanks. The commit is on top of v5.3-rc1 so it can be merged into other branches if needed after it's been sitting in Linux next for few days with no issues. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel