From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Peter Jones <pjones@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Roberto Sassu <roberto.sassu@huawei.com>,
Matthew Garrett <mjg59@google.com>,
Bartosz Szczepanek <bsz@semihalf.com>,
Lyude Paul <lyude@redhat.com>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] efi+tpm: Don't access event->count when it isn't mapped.
Date: Mon, 26 Aug 2019 19:28:23 +0300 [thread overview]
Message-ID: <20190826162823.4mxkwhd7mbtro3zy@linux.intel.com> (raw)
In-Reply-To: <20190826153028.32639-1-pjones@redhat.com>
On Mon, Aug 26, 2019 at 11:30:27AM -0400, Peter Jones wrote:
> Some machines generate a lot of event log entries. When we're
> iterating over them, the code removes the old mapping and adds a
> new one, so once we cross the page boundary we're unmapping the page
> with the count on it. Hilarity ensues.
>
> This patch keeps the info from the header in local variables so we don't
> need to access that page again or keep track of if it's mapped.
>
> Signed-off-by: Peter Jones <pjones@redhat.com>
> Tested-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
next prev parent reply other threads:[~2019-08-26 16:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 15:30 [PATCH 1/2] efi+tpm: Don't access event->count when it isn't mapped Peter Jones
2019-08-26 15:30 ` [PATCH 2/2] efi+tpm: don't traverse an event log with no events Peter Jones
2019-08-26 16:30 ` Jarkko Sakkinen
2019-08-26 17:45 ` Matthew Garrett
2019-08-31 16:46 ` Ard Biesheuvel
2019-08-26 16:28 ` Jarkko Sakkinen [this message]
2019-08-26 17:44 ` [PATCH 1/2] efi+tpm: Don't access event->count when it isn't mapped Matthew Garrett
2019-08-27 11:03 ` Jarkko Sakkinen
2019-08-27 13:41 ` Jarkko Sakkinen
2019-08-27 16:00 ` Matthew Garrett
2019-08-27 22:11 ` Peter Jones
2019-08-29 13:21 ` Jarkko Sakkinen
2019-08-31 16:11 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826162823.4mxkwhd7mbtro3zy@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=ard.biesheuvel@linaro.org \
--cc=bsz@semihalf.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=mjg59@google.com \
--cc=pjones@redhat.com \
--cc=roberto.sassu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.