From: Greg KH <greg@kroah.com>
To: Mike Marciniszyn <mike.marciniszyn@intel.com>
Cc: stable@vger.kernel.org, linux-rdma@vger.kernel.org,
stable-commits@vger.kernel.org
Subject: Re: [PATCH] IB/hfi1: Drop stale TID RDMA packets
Date: Mon, 26 Aug 2019 18:51:48 +0200 [thread overview]
Message-ID: <20190826165148.GA20925@kroah.com> (raw)
In-Reply-To: <20190826160149.32208.89081.stgit@awfm-01.aw.intel.com>
On Mon, Aug 26, 2019 at 12:01:50PM -0400, Mike Marciniszyn wrote:
> From: Kaike Wan <kaike.wan@intel.com>
>
> Upstream commit d58c1834bf0d218a0bc00f8fb44874551b21da84.
>
> In a congested fabric with adaptive routing enabled, traces show that
> the sender could receive stale TID RDMA NAK packets that contain newer
> KDETH PSNs and older Verbs PSNs. If not dropped, these packets could
> cause the incorrect rewinding of the software flows and the incorrect
> completion of TID RDMA WRITE requests, and eventually leading to memory
> corruption and kernel crash.
>
> The current code drops stale TID RDMA ACK/NAK packets solely based
> on KDETH PSNs, which may lead to erroneous processing. This patch
> fixes the issue by also checking the Verbs PSN. Addition checks are
> added before rewinding the TID RDMA WRITE DATA packets.
>
> [ported to 5.2 from upstream accounting for fspsn replacing flpsn.]
Now applied, thanks.
greg k-h
prev parent reply other threads:[~2019-08-26 16:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 16:01 [PATCH] IB/hfi1: Drop stale TID RDMA packets Mike Marciniszyn
2019-08-26 16:51 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826165148.GA20925@kroah.com \
--to=greg@kroah.com \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.