All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw at strlen.de>
To: mptcp at lists.01.org
Subject: Re: [MPTCP] [PATCH] mptcp: fall back to tcp when dss checksum are requested
Date: Mon, 26 Aug 2019 20:11:32 +0200	[thread overview]
Message-ID: <20190826181132.GX20113@breakpoint.cc> (raw)
In-Reply-To: f08c3a3f262768ef4ce96849900b027cf15e7f8d.camel@linux.intel.com

[-- Attachment #1: Type: text/plain, Size: 661 bytes --]

Peter Krystad <peter.krystad(a)linux.intel.com> wrote:
> 
> Hi Florian -
> 
> My thinking here was that code in mptcp_parse_options() just parses the
> options without having knowledge about configuration. There is existing logic
> for peer requesting checksums in subflow_v4_init_req().

Uh, I don't understand this then.  Can you fix this?

mptcp-next can't talk to mptcp kernel unless one disables checksums on
the mptcp kernel.

mptcp (out of tree) excepts checksums in default settings and will reset
the connection quickly.  I don't see how to fallback to tcp in that case
except with the patch I sent (not setting mp capable).

Thanks.

             reply	other threads:[~2019-08-26 18:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-26 18:11 Florian Westphal [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-08-29 13:11 [MPTCP] [PATCH] mptcp: fall back to tcp when dss checksum are requested Matthieu Baerts
2019-08-27 17:57 Peter Krystad
2019-08-27 16:49 Christoph Paasch
2019-08-27 10:53 Florian Westphal
2019-08-26 17:35 Peter Krystad
2019-08-26 12:48 Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190826181132.GX20113@breakpoint.cc \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.