From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alyssa Rosenzweig Subject: Re: [PATCH v3 0/8] panfrost: Locking and runtime PM fixes Date: Mon, 26 Aug 2019 16:35:31 -0700 Message-ID: <20190826233531.GA29519@kevin> References: <20190826223317.28509-1-robh@kernel.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1263441913==" Return-path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by gabe.freedesktop.org (Postfix) with ESMTPS id 99C286E332 for ; Mon, 26 Aug 2019 23:35:38 +0000 (UTC) In-Reply-To: <20190826223317.28509-1-robh@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Herring Cc: Tomeu Vizoso , David Airlie , dri-devel@lists.freedesktop.org, Steven Price , Robin Murphy List-Id: dri-devel@lists.freedesktop.org --===============1263441913== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HcAYCG3uE/tztfnV" Content-Disposition: inline --HcAYCG3uE/tztfnV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable A-b from me; let's see what others say. On Mon, Aug 26, 2019 at 05:33:09PM -0500, Rob Herring wrote: > With further testing of recent changes with lockdep identified some > locking issues. Avoiding lockdep issues means we need to avoid some > locks in panfrost_mmu_unmap which in turn means avoiding runtime PM > resume. In the process of re-working runtime PM several runtime PM > and locking clean-ups have been identified. >=20 > v3: > - Applied patches 1, 4, 5, and 6 > - Fix race in job timeout handling with ISR > - Remove some no longer needed locks > - Fix panfrost_mmu_unmap when autosuspend delay is > 0 > - Disable AS MMU when freeing page tables >=20 > v2: > - Drop already applied 'drm/panfrost: Fix sleeping while atomic in > panfrost_gem_open' > - Runtime PM clean-ups > - Keep panfrost_gem_purge and use mutex_trylock there > - Rework panfrost_mmu_unmap runtime PM >=20 > Rob >=20 > Rob Herring (8): > drm/panfrost: Rework runtime PM initialization > drm/panfrost: Hold runtime PM reference until jobs complete > drm/panfrost: Remove unnecessary mmu->lock mutex > drm/panfrost: Rework page table flushing and runtime PM interaction > drm/panfrost: Split mmu_hw_do_operation into locked and unlocked > version > drm/panfrost: Add cache/TLB flush before switching address space > drm/panfrost: Flush and disable address space when freeing page tables > drm/panfrost: Remove unnecessary hwaccess_lock spin_lock >=20 > drivers/gpu/drm/panfrost/panfrost_device.c | 10 --- > drivers/gpu/drm/panfrost/panfrost_device.h | 3 - > drivers/gpu/drm/panfrost/panfrost_drv.c | 10 ++- > drivers/gpu/drm/panfrost/panfrost_job.c | 43 ++++++---- > drivers/gpu/drm/panfrost/panfrost_mmu.c | 91 ++++++++++------------ > 5 files changed, 76 insertions(+), 81 deletions(-) >=20 > -- > 2.20.1 --HcAYCG3uE/tztfnV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEQ17gm7CvANAdqvY4/v5QWgr1WA0FAl1kbL4ACgkQ/v5QWgr1 WA3WBQ/+JyCxni0F8yMSGN5Vtzmzjs5aq/DLFS16KghADnVaVAgsW4yukDEiTxjT oQc4NfAxgpgRQ3oIuKrA2mz4MvHYO91tbwGq7sppzF3rUb2LzpyhX3m2LgzK0GyD y92vlGDEvcymea+pGoKGOvs7JuJrRbAzv6N6c0cKiTZzCi2KWzWGZONjCowadzVv O/Sr4npqXPbGE+ejQRfWBaGfv3NNi9Krp4KyJmLSTf+qHNV2i6rz5TXb3YFpTm27 6OPGPFWi0mdy/j47yzQRBh0WZEBXnDBuu3HLlEGr1GQOSw/6z6wAILlGNPmB25OM FbiQx+MmJUTq0TF/zgGkJvy1fiC2dIL0QZkIFwUrK/iz6/5kjfwPe092Tufa5Q34 zZR82DBT0gMJnR5+rvX6n4e7n8LpM36rVcOwZqqSMPrclC+UfFojN5ObXsujFm5V jmyY3q62iG2A4F8hNkAM6CMc9XiALlye1Obnlo8B+F8iZfLx1bWw7xG7RolcEQn2 rqgrC/jKH22GiJqVUccNxtda3UQtL6KleKVS14sVnQxlsWF6SqTuoWiWSTLswqqW J3IEMI/zgM4dWNXE/pHi9wZnrRmXKlbSQ+m5EdoFG9+PThQ3xMAMengy3vpcBl+Z HhZHwxqbYh+nvGhEBAi5qAyyXQ2QcxPVNUIojOp0NfuwJ+JKiOQ= =Dltj -----END PGP SIGNATURE----- --HcAYCG3uE/tztfnV-- --===============1263441913== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1263441913==--