From: Sean Christopherson <sean.j.christopherson@intel.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: linux-sgx@vger.kernel.org, Dave Hansen <dave.hansen@intel.com>,
Andy Lutomirski <luto@kernel.org>,
Serge Ayoun <serge.ayoun@intel.com>
Subject: Re: [PATCH RFC] x86/sgx: Convert sgx_reclaim_pages() to sgx_reclaim_page()
Date: Mon, 26 Aug 2019 18:27:32 -0700 [thread overview]
Message-ID: <20190827012732.GC25260@linux.intel.com> (raw)
In-Reply-To: <20190826063323.22196-1-jarkko.sakkinen@linux.intel.com>
On Mon, Aug 26, 2019 at 09:33:23AM +0300, Jarkko Sakkinen wrote:
> Convert sgx_reclaim_pages() to sgx_reclaim_page(), which reclaims only a
> signle page and returns it back to the caller instead of freeing it.
>
> A simpler flow will allow also simplify sgx_alloc_page() flow and make it
> constant time. With this change it is easer to pin backing storage before
Nit: it doesn't run in constant time, its upper bound is simply lower.
> the pages are blocked, which stabilizes the EBLOCK/EWB/ETRACK flow: only an
> EPCM conflict could cause a EWB to fail.
>
> Because sgx_alloc_page() operations run in parallel on different threads
> ETRACK's will still group multiple EBLOCK operations. ksgxswapd can be
> improved in future with multi-threading (e.g.a work queue).
I won't be able to give this a thorough review for a few days due to other
tasks. We should definitely do some rudimentary performance testing given
the potential impact.
next prev parent reply other threads:[~2019-08-27 1:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 6:33 [PATCH RFC] x86/sgx: Convert sgx_reclaim_pages() to sgx_reclaim_page() Jarkko Sakkinen
2019-08-27 1:27 ` Sean Christopherson [this message]
2019-08-27 11:30 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827012732.GC25260@linux.intel.com \
--to=sean.j.christopherson@intel.com \
--cc=dave.hansen@intel.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-sgx@vger.kernel.org \
--cc=luto@kernel.org \
--cc=serge.ayoun@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.