From: Sam Eiderman via Qemu-devel <qemu-devel@nongnu.org>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, qemu-block@nongnu.org,
Arbel Moshe <arbel.moshe@oracle.com>,
seabios@seabios.org, kevin@koconnor.net, liran.alon@oracle.com,
kraxel@redhat.com, Sam Eiderman <shmuel.eiderman@oracle.com>,
sameid@google.com, karl.heubaum@oracle.com
Subject: [Qemu-devel] [PATCH v6 1/8] block: Refactor macros - fix tabbing
Date: Tue, 27 Aug 2019 11:24:20 +0300 [thread overview]
Message-ID: <20190827082427.64280-2-sameid@google.com> (raw)
In-Reply-To: <20190827082427.64280-1-sameid@google.com>
From: Sam Eiderman <shmuel.eiderman@oracle.com>
Fixing tabbing in block related macros.
Reviewed-by: Karl Heubaum <karl.heubaum@oracle.com>
Reviewed-by: Arbel Moshe <arbel.moshe@oracle.com>
Signed-off-by: Sam Eiderman <shmuel.eiderman@oracle.com>
---
hw/ide/qdev.c | 2 +-
include/hw/block/block.h | 16 ++++++++--------
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c
index 6fba6b62b8..6dd219944f 100644
--- a/hw/ide/qdev.c
+++ b/hw/ide/qdev.c
@@ -290,7 +290,7 @@ static void ide_drive_realize(IDEDevice *dev, Error **errp)
DEFINE_BLOCK_PROPERTIES(IDEDrive, dev.conf), \
DEFINE_BLOCK_ERROR_PROPERTIES(IDEDrive, dev.conf), \
DEFINE_PROP_STRING("ver", IDEDrive, dev.version), \
- DEFINE_PROP_UINT64("wwn", IDEDrive, dev.wwn, 0), \
+ DEFINE_PROP_UINT64("wwn", IDEDrive, dev.wwn, 0), \
DEFINE_PROP_STRING("serial", IDEDrive, dev.serial),\
DEFINE_PROP_STRING("model", IDEDrive, dev.model)
diff --git a/include/hw/block/block.h b/include/hw/block/block.h
index 607539057a..fd55a30bca 100644
--- a/include/hw/block/block.h
+++ b/include/hw/block/block.h
@@ -50,21 +50,21 @@ static inline unsigned int get_physical_block_exp(BlockConf *conf)
_conf.logical_block_size), \
DEFINE_PROP_BLOCKSIZE("physical_block_size", _state, \
_conf.physical_block_size), \
- DEFINE_PROP_UINT16("min_io_size", _state, _conf.min_io_size, 0), \
+ DEFINE_PROP_UINT16("min_io_size", _state, _conf.min_io_size, 0), \
DEFINE_PROP_UINT32("opt_io_size", _state, _conf.opt_io_size, 0), \
- DEFINE_PROP_UINT32("discard_granularity", _state, \
- _conf.discard_granularity, -1), \
- DEFINE_PROP_ON_OFF_AUTO("write-cache", _state, _conf.wce, \
- ON_OFF_AUTO_AUTO), \
+ DEFINE_PROP_UINT32("discard_granularity", _state, \
+ _conf.discard_granularity, -1), \
+ DEFINE_PROP_ON_OFF_AUTO("write-cache", _state, _conf.wce, \
+ ON_OFF_AUTO_AUTO), \
DEFINE_PROP_BOOL("share-rw", _state, _conf.share_rw, false)
#define DEFINE_BLOCK_PROPERTIES(_state, _conf) \
DEFINE_PROP_DRIVE("drive", _state, _conf.blk), \
DEFINE_BLOCK_PROPERTIES_BASE(_state, _conf)
-#define DEFINE_BLOCK_CHS_PROPERTIES(_state, _conf) \
- DEFINE_PROP_UINT32("cyls", _state, _conf.cyls, 0), \
- DEFINE_PROP_UINT32("heads", _state, _conf.heads, 0), \
+#define DEFINE_BLOCK_CHS_PROPERTIES(_state, _conf) \
+ DEFINE_PROP_UINT32("cyls", _state, _conf.cyls, 0), \
+ DEFINE_PROP_UINT32("heads", _state, _conf.heads, 0), \
DEFINE_PROP_UINT32("secs", _state, _conf.secs, 0)
#define DEFINE_BLOCK_ERROR_PROPERTIES(_state, _conf) \
--
2.23.0.187.g17f5b7556c-goog
next prev parent reply other threads:[~2019-08-27 8:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 8:24 [Qemu-devel] [PATCH v6 0/8] Add Qemu to SeaBIOS LCHS interface Sam Eiderman via Qemu-devel
2019-08-27 8:24 ` Sam Eiderman via Qemu-devel [this message]
2019-08-27 8:24 ` [Qemu-devel] [PATCH v6 2/8] block: Support providing LCHS from user Sam Eiderman via Qemu-devel
2019-08-27 8:24 ` [Qemu-devel] [PATCH v6 3/8] bootdevice: Add interface to gather LCHS Sam Eiderman via Qemu-devel
2019-08-27 8:24 ` [Qemu-devel] [PATCH v6 4/8] scsi: Propagate unrealize() callback to scsi-hd Sam Eiderman via Qemu-devel
2019-08-27 8:24 ` [Qemu-devel] [PATCH v6 5/8] bootdevice: Gather LCHS from all relevant devices Sam Eiderman via Qemu-devel
2019-09-23 21:40 ` [Qemu-block] " John Snow
2019-08-27 8:24 ` [Qemu-devel] [PATCH v6 6/8] bootdevice: Refactor get_boot_devices_list Sam Eiderman via Qemu-devel
2019-08-27 8:24 ` [Qemu-devel] [PATCH v6 7/8] bootdevice: FW_CFG interface for LCHS values Sam Eiderman via Qemu-devel
2019-08-27 8:24 ` [Qemu-devel] [PATCH v6 8/8] hd-geo-test: Add tests for lchs override Sam Eiderman via Qemu-devel
2019-08-27 9:37 ` [Qemu-devel] [PATCH v6 0/8] Add Qemu to SeaBIOS LCHS interface no-reply
2019-08-27 10:02 ` no-reply
2019-09-11 14:36 ` Sam Eiderman via Qemu-devel
2019-09-23 8:23 ` Sam Eiderman via
2019-09-23 9:50 ` [Qemu-devel] " Max Reitz
2019-09-24 18:49 ` [Qemu-block] " John Snow
2019-09-25 7:58 ` Thomas Huth
2019-09-25 10:20 ` Sam Eiderman via
2019-09-25 10:22 ` mailer
2019-09-25 13:11 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827082427.64280-2-sameid@google.com \
--to=qemu-devel@nongnu.org \
--cc=arbel.moshe@oracle.com \
--cc=karl.heubaum@oracle.com \
--cc=kevin@koconnor.net \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=liran.alon@oracle.com \
--cc=qemu-block@nongnu.org \
--cc=sameid@google.com \
--cc=seabios@seabios.org \
--cc=shmuel.eiderman@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.