From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
vsementsov@virtuozzo.com,
"open list:Network Block Dev..." <qemu-block@nongnu.org>,
rjones@redhat.com, qemu-devel@nongnu.org,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/2] nbd: Use g_autofree in a few places
Date: Tue, 27 Aug 2019 09:42:50 +0100 [thread overview]
Message-ID: <20190827084250.GA16500@redhat.com> (raw)
In-Reply-To: <20190824172813.29720-2-eblake@redhat.com>
On Sat, Aug 24, 2019 at 12:28:12PM -0500, Eric Blake wrote:
> Thanks to our recent move to use glib's g_autofree, I can join the
> bandwagon. Getting rid of gotos is fun ;)
>
> There are probably more places where we could register cleanup
> functions and get rid of more gotos; this patch just focuses on the
> labels that existed merely to call g_free.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> block/nbd.c | 11 ++++-------
> nbd/client.c | 22 +++++++---------------
> nbd/server.c | 12 ++++--------
> 3 files changed, 15 insertions(+), 30 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2019-08-27 8:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-24 17:28 [Qemu-devel] [PATCH v2 0/2] nbd: tolerate more errors to extension requests Eric Blake
2019-08-24 17:28 ` [Qemu-devel] [PATCH v2 1/2] nbd: Use g_autofree in a few places Eric Blake
2019-08-27 8:42 ` Daniel P. Berrangé [this message]
2019-08-27 13:51 ` Vladimir Sementsov-Ogievskiy
2019-08-24 17:28 ` [Qemu-devel] [PATCH v2 2/2] nbd: Tolerate more errors to structured reply request Eric Blake
2019-08-27 8:47 ` Daniel P. Berrangé
2019-08-27 13:56 ` [Qemu-devel] [PATCH v2 0/2] nbd: tolerate more errors to extension requests Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827084250.GA16500@redhat.com \
--to=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.