From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/2] drm/i915: Allow /2 CD2X divider on gen11+ Date: Tue, 27 Aug 2019 16:52:50 +0300 Message-ID: <20190827135250.GA7482@intel.com> References: <20190826225540.11987-1-matthew.d.roper@intel.com> <20190826225540.11987-2-matthew.d.roper@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3649B8977A for ; Tue, 27 Aug 2019 13:52:54 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190826225540.11987-2-matthew.d.roper@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Matt Roper Cc: intel-gfx@lists.freedesktop.org, Lucas De Marchi List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBBdWcgMjYsIDIwMTkgYXQgMDM6NTU6MzlQTSAtMDcwMCwgTWF0dCBSb3BlciB3cm90 ZToKPiBUaGUgYnNwZWMgaGFzIGp1c3QgcmVjZW50bHkgYmVlbiB1cGRhdGVkIHdpdGggbmV3IGNk Y2xrIHZhbHVlcyB0aGF0Cj4gcmVxdWlyZSB0aGUgdXNlIG9mIGEgLzIgQ0QyWCBkaXZpZGVyIHJh dGhlciB0aGFuIGEgLzEgZGl2aWRlci4gIE9uY2Ugd2UKPiBhZGQgdGhlIGRpdmlkZXIgc2VsZWN0 aW9uIGxvZ2ljIHRvIElDTCsgY2RjbGsgcHJvZ3JhbW1pbmcsIHdlIGhhdmUKPiBwcmV0dHkgbXVj aCB0aGUgc2FtZSBsb2dpYyB3ZSB3ZXJlIGFscmVhZHkgdXNpbmcgb24gQ05MLCBzbyBpdCdzIHNp bXBsZXIKPiB0byBkcm9wIGljbF9zZXRfY2RjbGsoKSBjb21wbGV0ZWx5IGFuZCByZXVzZSBjbmxf c2V0X2NkY2xrKCkgb24gZ2VuMTErCj4gcGxhdGZvcm1zIGFzIHdlbGwuCj4gCj4gQ2M6IEpvc8Op IFJvYmVydG8gZGUgU291emEgPGpvc2Uuc291emFAaW50ZWwuY29tPgo+IENjOiBMdWNhcyBEZSBN YXJjaGkgPGx1Y2FzLmRlbWFyY2hpQGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBNYXR0IFJv cGVyIDxtYXR0aGV3LmQucm9wZXJAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9kaXNwbGF5L2ludGVsX2NkY2xrLmMgfCA5MCArKysrKysrKystLS0tLS0tLS0tLS0tCj4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggICAgICAgICAgICB8ICAxICsKPiAgMiBm aWxlcyBjaGFuZ2VkLCAzNiBpbnNlcnRpb25zKCspLCA1NSBkZWxldGlvbnMoLSkKPiAKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9jZGNsay5jIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9jZGNsay5jCj4gaW5kZXggOTM5MDg4Yzdk ODE0Li5hNTZjY2QwOTMwZTAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlz cGxheS9pbnRlbF9jZGNsay5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9p bnRlbF9jZGNsay5jCj4gQEAgLTE2NTksMTAgKzE2NTksMjMgQEAgc3RhdGljIHZvaWQgY25sX3Nl dF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJY25sX2NkY2xr X3BsbF9lbmFibGUoZGV2X3ByaXYsIHZjbyk7Cj4gIAo+ICAJdmFsID0gZGl2aWRlciB8IHNrbF9j ZGNsa19kZWNpbWFsKGNkY2xrKTsKPiAtCWlmIChwaXBlID09IElOVkFMSURfUElQRSkKPiAtCQl2 YWwgfD0gQlhUX0NEQ0xLX0NEMlhfUElQRV9OT05FOwo+IC0JZWxzZQo+IC0JCXZhbCB8PSBCWFRf Q0RDTEtfQ0QyWF9QSVBFKHBpcGUpOwo+ICsKPiArCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49 IDEyKSB7Cj4gKwkJaWYgKHBpcGUgPT0gSU5WQUxJRF9QSVBFKQo+ICsJCQl2YWwgfD0gSUNMX0NE Q0xLX0NEMlhfUElQRV9OT05FOwo+ICsJCWVsc2UKPiArCQkJdmFsIHw9IEJYVF9DRENMS19DRDJY X1BJUEUocGlwZSk7CgpIbW0uIFNvIHRoZSBtZXNzIG1hZGUgaGVyZSB3aXRoIGljbCBpcyBub3cg Zml4ZWQuIENvb2wuIFNhZCB0aGV5CmRpZG4ndCBmaXggaXQgb24gaWNsIGFzIHdlbGwuCgpIb3dl dmVyIEkgaGF2ZSBhIGZlZWxpbmcgdGhpcyBtYXkgZW5kIHVwIGNvbmZ1c2luZyBwZW9wbGUsIHNv IG1heWJlIHdlCnNob3VsZCBqdXN0IGFkZCBUR0xfQ0RDTEtfQ0QyWF9QSVBFKCk/Cgo+ICsJfSBl bHNlIGlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDExKSB7Cj4gKwkJaWYgKHBpcGUgPT0gSU5W QUxJRF9QSVBFKQo+ICsJCQl2YWwgfD0gSUNMX0NEQ0xLX0NEMlhfUElQRV9OT05FOwo+ICsJCWVs c2UKPiArCQkJdmFsIHw9IElDTF9DRENMS19DRDJYX1BJUEUocGlwZSk7Cj4gKwl9IGVsc2Ugewo+ ICsJCWlmIChwaXBlID09IElOVkFMSURfUElQRSkKPiArCQkJdmFsIHw9IEJYVF9DRENMS19DRDJY X1BJUEVfTk9ORTsKPiArCQllbHNlCj4gKwkJCXZhbCB8PSBCWFRfQ0RDTEtfQ0QyWF9QSVBFKHBp cGUpOwo+ICsJfQo+ICAJSTkxNV9XUklURShDRENMS19DVEwsIHZhbCk7Cj4gIAo+ICAJaWYgKHBp cGUgIT0gSU5WQUxJRF9QSVBFKQo+IEBAIC0xODEzLDUxICsxODI2LDYgQEAgc3RhdGljIGludCBp Y2xfY2FsY19jZGNsa19wbGxfdmNvKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwg aW50IGNkY2xrKQo+ICAJcmV0dXJuIGRldl9wcml2LT5jZGNsay5ody5yZWYgKiByYXRpbzsKPiAg fQo+ICAKPiAtc3RhdGljIHZvaWQgaWNsX3NldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYsCj4gLQkJCSAgY29uc3Qgc3RydWN0IGludGVsX2NkY2xrX3N0YXRlICpjZGNs a19zdGF0ZSwKPiAtCQkJICBlbnVtIHBpcGUgcGlwZSkKPiAtewo+IC0JdW5zaWduZWQgaW50IGNk Y2xrID0gY2RjbGtfc3RhdGUtPmNkY2xrOwo+IC0JdW5zaWduZWQgaW50IHZjbyA9IGNkY2xrX3N0 YXRlLT52Y287Cj4gLQlpbnQgcmV0Owo+IC0KPiAtCXJldCA9IHNrbF9wY29kZV9yZXF1ZXN0KGRl dl9wcml2LCBTS0xfUENPREVfQ0RDTEtfQ09OVFJPTCwKPiAtCQkJCVNLTF9DRENMS19QUkVQQVJF X0ZPUl9DSEFOR0UsCj4gLQkJCQlTS0xfQ0RDTEtfUkVBRFlfRk9SX0NIQU5HRSwKPiAtCQkJCVNL TF9DRENMS19SRUFEWV9GT1JfQ0hBTkdFLCAzKTsKPiAtCWlmIChyZXQpIHsKPiAtCQlEUk1fRVJS T1IoIkZhaWxlZCB0byBpbmZvcm0gUENVIGFib3V0IGNkY2xrIGNoYW5nZSAoJWQpXG4iLAo+IC0J CQkgIHJldCk7Cj4gLQkJcmV0dXJuOwo+IC0JfQo+IC0KPiAtCWlmIChkZXZfcHJpdi0+Y2RjbGsu aHcudmNvICE9IDAgJiYKPiAtCSAgICBkZXZfcHJpdi0+Y2RjbGsuaHcudmNvICE9IHZjbykKPiAt CQljbmxfY2RjbGtfcGxsX2Rpc2FibGUoZGV2X3ByaXYpOwo+IC0KPiAtCWlmIChkZXZfcHJpdi0+ Y2RjbGsuaHcudmNvICE9IHZjbykKPiAtCQljbmxfY2RjbGtfcGxsX2VuYWJsZShkZXZfcHJpdiwg dmNvKTsKPiAtCj4gLQkvKgo+IC0JICogT24gSUNMIENEMlhfRElWIGNhbiBvbmx5IGJlIDEsIHNv IHdlJ2xsIG5ldmVyIGVuZCB1cCBjaGFuZ2luZyB0aGUKPiAtCSAqIGRpdmlkZXIgaGVyZSBzeW5j aHJvbml6ZWQgdG8gYSBwaXBlIHdoaWxlIENEQ0xLIGlzIG9uLCBub3Igd2lsbCB3ZQo+IC0JICog bmVlZCB0aGUgY29ycmVzcG9uZGluZyB2Ymxhbmsgd2FpdC4KPiAtCSAqLwo+IC0JSTkxNV9XUklU RShDRENMS19DVEwsIElDTF9DRENMS19DRDJYX1BJUEVfTk9ORSB8Cj4gLQkJCSAgICAgIHNrbF9j ZGNsa19kZWNpbWFsKGNkY2xrKSk7Cj4gLQo+IC0Jc2FuZHlicmlkZ2VfcGNvZGVfd3JpdGUoZGV2 X3ByaXYsIFNLTF9QQ09ERV9DRENMS19DT05UUk9MLAo+IC0JCQkJY2RjbGtfc3RhdGUtPnZvbHRh Z2VfbGV2ZWwpOwo+IC0KPiAtCWludGVsX3VwZGF0ZV9jZGNsayhkZXZfcHJpdik7Cj4gLQo+IC0J LyoKPiAtCSAqIENhbid0IHJlYWQgb3V0IHRoZSB2b2x0YWdlIGxldmVsIDooCj4gLQkgKiBMZXQn cyBqdXN0IGFzc3VtZSBldmVyeXRoaW5nIGlzIGFzIGV4cGVjdGVkLgo+IC0JICovCj4gLQlkZXZf cHJpdi0+Y2RjbGsuaHcudm9sdGFnZV9sZXZlbCA9IGNkY2xrX3N0YXRlLT52b2x0YWdlX2xldmVs Owo+IC19Cj4gLQo+ICBzdGF0aWMgdTggaWNsX2NhbGNfdm9sdGFnZV9sZXZlbChzdHJ1Y3QgZHJt X2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGludCBjZGNsaykKPiAgewo+ICAJaWYgKElTX0VMS0hB UlRMQUtFKGRldl9wcml2KSkgewo+IEBAIC0xODgxLDYgKzE4NDksNyBAQCBzdGF0aWMgdm9pZCBp Y2xfZ2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQkJICBz dHJ1Y3QgaW50ZWxfY2RjbGtfc3RhdGUgKmNkY2xrX3N0YXRlKQo+ICB7Cj4gIAl1MzIgdmFsOwo+ ICsJaW50IGRpdjsKPiAgCj4gIAljZGNsa19zdGF0ZS0+YnlwYXNzID0gNTAwMDA7Cj4gIAo+IEBA IC0xOTE0LDEwICsxODgzLDIxIEBAIHN0YXRpYyB2b2lkIGljbF9nZXRfY2RjbGsoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAKPiAgCWNkY2xrX3N0YXRlLT52Y28gPSAodmFs ICYgQlhUX0RFX1BMTF9SQVRJT19NQVNLKSAqIGNkY2xrX3N0YXRlLT5yZWY7Cj4gIAo+IC0JdmFs ID0gSTkxNV9SRUFEKENEQ0xLX0NUTCk7Cj4gLQlXQVJOX09OKCh2YWwgJiBCWFRfQ0RDTEtfQ0Qy WF9ESVZfU0VMX01BU0spICE9IDApOwo+ICsJdmFsID0gSTkxNV9SRUFEKENEQ0xLX0NUTCkgJiBC WFRfQ0RDTEtfQ0QyWF9ESVZfU0VMX01BU0s7Cj4gKwlzd2l0Y2ggKHZhbCkgewo+ICsJY2FzZSBC WFRfQ0RDTEtfQ0QyWF9ESVZfU0VMXzE6Cj4gKwkJZGl2ID0gMjsKPiArCQlicmVhazsKPiArCWNh c2UgQlhUX0NEQ0xLX0NEMlhfRElWX1NFTF8yOgo+ICsJCWRpdiA9IDQ7Cj4gKwkJYnJlYWs7Cj4g KwlkZWZhdWx0Ogo+ICsJCU1JU1NJTkdfQ0FTRSh2YWwpOwo+ICsJCWRpdiA9IDI7Cj4gKwkJYnJl YWs7Cj4gKwl9Cj4gIAo+IC0JY2RjbGtfc3RhdGUtPmNkY2xrID0gY2RjbGtfc3RhdGUtPnZjbyAv IDI7Cj4gKwljZGNsa19zdGF0ZS0+Y2RjbGsgPSBjZGNsa19zdGF0ZS0+dmNvIC8gZGl2OwoKY25s IHVzZXMgRElWX1JPVU5EX0NMT1NFU1QoKS4gSW4gZ2VuZXJhbCB0aGlzIGZ1bmN0aW9uIGxvb2tz IHJhdGhlcgpkaWZmZXJlbnQgdG8gY25sX2dldF9jZGNsaygpIGV2ZW4gdGhvdWdoIHRoZSBhY3R1 YWwgZGlmZmVyZW5jZXMgYXJlCm1pbmltYWwuIFNvbWUgdW5pZmljYXRpb24gb2Ygc3R5bGUgbWln aHQgYmUgbmljZS4gTm90IHN1cmUgaWYgcmV1c2luZwp0aGUgY25sIGZ1bmN0aW9uIG9uIGljbCBt aWdodCBhY3R1YWxseSBtYWtlIHNlbnNlLiBXb3VsZCByZXF1aXJlCmEgZmV3IGlmcy4KCj4gIAo+ ICBvdXQ6Cj4gIAkvKgo+IEBAIC0xOTYzLDcgKzE5NDMsNyBAQCBzdGF0aWMgdm9pZCBpY2xfaW5p dF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAkJCQlpY2xfY2Fs Y192b2x0YWdlX2xldmVsKGRldl9wcml2LAo+ICAJCQkJCQkgICAgICAgc2FuaXRpemVkX3N0YXRl LmNkY2xrKTsKPiAgCj4gLQlpY2xfc2V0X2NkY2xrKGRldl9wcml2LCAmc2FuaXRpemVkX3N0YXRl LCBJTlZBTElEX1BJUEUpOwo+ICsJY25sX3NldF9jZGNsayhkZXZfcHJpdiwgJnNhbml0aXplZF9z dGF0ZSwgSU5WQUxJRF9QSVBFKTsKPiAgfQo+ICAKPiAgc3RhdGljIHZvaWQgaWNsX3VuaW5pdF9j ZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gQEAgLTE5NzUsNyArMTk1 NSw3IEBAIHN0YXRpYyB2b2lkIGljbF91bmluaXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2KQo+ICAJY2RjbGtfc3RhdGUudm9sdGFnZV9sZXZlbCA9IGljbF9jYWxjX3Zv bHRhZ2VfbGV2ZWwoZGV2X3ByaXYsCj4gIAkJCQkJCQkgICBjZGNsa19zdGF0ZS5jZGNsayk7Cj4g IAo+IC0JaWNsX3NldF9jZGNsayhkZXZfcHJpdiwgJmNkY2xrX3N0YXRlLCBJTlZBTElEX1BJUEUp Owo+ICsJY25sX3NldF9jZGNsayhkZXZfcHJpdiwgJmNkY2xrX3N0YXRlLCBJTlZBTElEX1BJUEUp Owo+ICB9Cj4gIAo+ICBzdGF0aWMgdm9pZCBjbmxfaW5pdF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYpCj4gQEAgLTI4MTAsNyArMjc5MCw3IEBAIHZvaWQgaW50ZWxfdXBk YXRlX3Jhd2NsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIHZvaWQgaW50 ZWxfaW5pdF9jZGNsa19ob29rcyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4g IHsKPiAgCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDExKSB7Cj4gLQkJZGV2X3ByaXYtPmRp c3BsYXkuc2V0X2NkY2xrID0gaWNsX3NldF9jZGNsazsKPiArCQlkZXZfcHJpdi0+ZGlzcGxheS5z ZXRfY2RjbGsgPSBjbmxfc2V0X2NkY2xrOwo+ICAJCWRldl9wcml2LT5kaXNwbGF5Lm1vZGVzZXRf Y2FsY19jZGNsayA9IGljbF9tb2Rlc2V0X2NhbGNfY2RjbGs7Cj4gIAl9IGVsc2UgaWYgKElTX0NB Tk5PTkxBS0UoZGV2X3ByaXYpKSB7Cj4gIAkJZGV2X3ByaXYtPmRpc3BsYXkuc2V0X2NkY2xrID0g Y25sX3NldF9jZGNsazsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9y ZWcuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiBpbmRleCBhMTQyYWEzZDc0 ZTMuLjk1OGRmZGZiNGUxMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X3JlZy5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+IEBAIC05Njcx LDYgKzk2NzEsNyBAQCBlbnVtIHNrbF9wb3dlcl9nYXRlIHsKPiAgI2RlZmluZSAgQlhUX0NEQ0xL X0NEMlhfUElQRShwaXBlKQkoKHBpcGUpIDw8IDIwKQo+ICAjZGVmaW5lICBDRENMS19ESVZNVVhf Q0RfT1ZFUlJJREUJKDEgPDwgMTkpCj4gICNkZWZpbmUgIEJYVF9DRENMS19DRDJYX1BJUEVfTk9O RQlCWFRfQ0RDTEtfQ0QyWF9QSVBFKDMpCj4gKyNkZWZpbmUgIElDTF9DRENMS19DRDJYX1BJUEUo cGlwZSkJKF9QSUNLKHBpcGUsIDAsIDIsIDYpIDw8IDE5KQoKQ291bGQgYWxzbyBkbyBlZy4KKCgo KHBpcGUpIDw8IDEpIHwgKChwaXBlKSAmIH4xKSkgPDwgMTkpCgppZiB3ZSB3YW50IHRvIGF2b2lk IHRoZSBfUElDSygpLiBEb2Vzbid0IHJlYWxseSBtYXR0ZXIgSSBzdXBwb3NlLgoKUmV2aWV3ZWQt Ynk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cgo+ICAj ZGVmaW5lICBJQ0xfQ0RDTEtfQ0QyWF9QSVBFX05PTkUJKDcgPDwgMTkpCj4gICNkZWZpbmUgIEJY VF9DRENMS19TU0FfUFJFQ0hBUkdFX0VOQUJMRQkoMSA8PCAxNikKPiAgI2RlZmluZSAgQ0RDTEtf RlJFUV9ERUNJTUFMX01BU0sJKDB4N2ZmKQo+IC0tIAo+IDIuMjAuMQo+IAo+IF9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gClZpbGxlIFN5cmrD pGzDpApJbnRlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=