From: Rob Herring <robh@kernel.org>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: devicetree@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: smiapp: Align documentation with current practices
Date: Tue, 27 Aug 2019 10:58:15 -0500 [thread overview]
Message-ID: <20190827155815.GA9693@bogus> (raw)
In-Reply-To: <20190813134518.5640-1-sakari.ailus@linux.intel.com>
On Tue, 13 Aug 2019 16:45:18 +0300, Sakari Ailus wrote:
> - The clock-lanes property is not needed for the sensors do not support
> lane reordering. (The information possibly present in existing clock-lane
> properties is simply not used.)
>
> - There's no need to refer to the sensor device in the DT example, thus
> remove the label.
>
> - Rename the "camera" device node as "camera-sensor".
>
> - Rename the endpoint label as "smiapp_ep" (was: "smiapp_1_1"). There is
> in practice only one anyway.
>
> - Remove the remote-endpoint documentation (it is covered by
> graph.txt to which video-interfaces.txt refers to).
>
> - Add a note on the port and endpoint nodes.
>
> These changes make the smiapp bindings a better example.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> .../devicetree/bindings/media/i2c/nokia,smia.txt | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
Applied, thanks.
Rob
prev parent reply other threads:[~2019-08-27 15:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 13:45 [PATCH 1/1] dt-bindings: smiapp: Align documentation with current practices Sakari Ailus
2019-08-27 15:58 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827155815.GA9693@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.