Re: [MPTCP] [PATCH RFC 00/10] mptcp: refactor token code

[Florian Westphal <fw at strlen.de>]

[-- Attachment #1: Type: text/plain, Size: 1060 bytes --]

Matthieu Baerts <matthieu.baerts(a)tessares.net> wrote:
> For the 'mptcp_' prefix, we made sure to add them to all functions
> exposed outside net/mptcp and Peter got the excellent idea to move all
> functions only needed in net/mptcp into net/mptcp/protocol.h. We didn't
> add 'mptcp_' prefix for all these "internal" functions but it certainly
> makes sense to do that. I guess it is useful when debugging if you see
> these functions in a call trace or in the list of functions available
> for tracing.
> 
> Do you think we should do the same for "crypto" and "subflow" and "pm"?
> I guess "pm" and "subflow" are keywords mainly used in "mptcp" but it is
> maybe not clear for everybody.

Yes.  Subflow is maybe fine though.

pm is 'power mangement', so I think it makes sense to prefix mptcp_
there.

> The patches look very good to me, just a few questions and one or two
> typos, nothing important. I guess other people will also have a look at
> them :)

Thanks a lot for the review, I will respin a new version later this
week.