From: Florian Westphal <fw at strlen.de>
To: mptcp at lists.01.org
Subject: Re: [MPTCP] [PATCH RFC 09/10] mptcp: token: fold destroy_token helper
Date: Tue, 27 Aug 2019 20:08:38 +0200 [thread overview]
Message-ID: <20190827180838.GD20113@breakpoint.cc> (raw)
In-Reply-To: ebf2bdc7-8133-664e-c4d0-bb68c33e566c@tessares.net
[-- Attachment #1: Type: text/plain, Size: 838 bytes --]
Matthieu Baerts <matthieu.baerts(a)tessares.net> wrote:
> > -void token_destroy_request(u32 token)
> > +/**
> > + * mptcp_token_destroy_request - remove mptcp connection/token
> > + * @token - token of mptcp connection to remove
> > + *
> > + * Remove the not-yey-fully-established incoming connection identified
>
> yey? or "yay!!!"? maybe more "yet" I guess :-D
Right. I'll run aspell on the series next time.
> > + * by @token. If the connection isn't found, no action is taken.
>
> Is it to explain why we don't do anything with *cur?
Right, I'll remove cur.
> > spin_lock_bh(&token_tree_lock);
> > - conn = destroy_token(token);
> > + conn = radix_tree_delete(&token_tree, token);
> > if (conn)
>
> Is it no longer needed to check "conn != &token_used" here?
Right, I'll add it back -- thanks!
next reply other threads:[~2019-08-27 18:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 18:08 Florian Westphal [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-08-28 0:13 [MPTCP] [PATCH RFC 09/10] mptcp: token: fold destroy_token helper Peter Krystad
2019-08-27 17:00 Matthieu Baerts
2019-08-25 18:59 Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827180838.GD20113@breakpoint.cc \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.