From: Stephen Boyd <sboyd@kernel.org>
To: Brendan Higgins <brendanhiggins@google.com>, shuah@kernel.org
Cc: kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, frowand.list@gmail.com,
Brendan Higgins <brendanhiggins@google.com>,
Randy Dunlap <rdunlap@infradead.org>,
Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH v1] kunit: fix failure to build without printk
Date: Tue, 27 Aug 2019 14:46:12 -0700 [thread overview]
Message-ID: <20190827214613.9B896206E0@mail.kernel.org> (raw)
In-Reply-To: <20190827174932.44177-1-brendanhiggins@google.com>
Quoting Brendan Higgins (2019-08-27 10:49:32)
> Previously KUnit assumed that printk would always be present, which is
> not a valid assumption to make. Fix that by ifdefing out functions which
> directly depend on printk core functions similar to what dev_printk
> does.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Link: https://lore.kernel.org/linux-kselftest/0352fae9-564f-4a97-715a-fabe016259df@kernel.org/T/#t
> Cc: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
> ---
Does kunit itself have any meaning if printk doesn't work? Why not just
depend on CONFIG_PRINTK for now?
next prev parent reply other threads:[~2019-08-27 21:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 17:49 [PATCH v1] kunit: fix failure to build without printk Brendan Higgins
2019-08-27 18:58 ` Randy Dunlap
2019-08-27 20:21 ` shuah
2019-08-27 20:53 ` Randy Dunlap
2019-08-27 21:16 ` shuah
2019-08-27 21:03 ` Brendan Higgins
2019-08-27 21:09 ` Brendan Higgins
2019-08-27 21:36 ` Brendan Higgins
2019-08-27 22:00 ` shuah
2019-08-27 22:16 ` Brendan Higgins
2019-08-27 22:37 ` Tim.Bird
2019-08-27 22:51 ` Brendan Higgins
2019-08-27 22:55 ` shuah
2019-08-27 23:11 ` Brendan Higgins
2019-08-27 21:46 ` Stephen Boyd [this message]
2019-08-27 21:51 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190827214613.9B896206E0@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=brendanhiggins@google.com \
--cc=frowand.list@gmail.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.