From: Shmulik Ladkani <shmulik.ladkani@gmail.com>
To: Florian Westphal <fw@strlen.de>, Pablo Neira Ayuso <pablo@netfilter.org>
Cc: <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH nf] netfilter: conntrack: make sysctls per-namespace again
Date: Wed, 28 Aug 2019 10:40:30 +0300 [thread overview]
Message-ID: <20190828104030.134f38ec@pixies> (raw)
In-Reply-To: <20190827112452.31479-1-fw@strlen.de>
On Tue, 27 Aug 2019 13:24:52 +0200
Florian Westphal <fw@strlen.de> wrote:
> When I merged the extension sysctl tables with the main one I forgot to
> reset them on netns creation. They currently read/write init_net settings.
>
> Fixes: d912dec12428 ("netfilter: conntrack: merge acct and helper sysctl table with main one")
> Fixes: cb2833ed0044 ("netfilter: conntrack: merge ecache and timestamp sysctl tables with main one")
> Reported-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
> Shmulik, could you please check if this fixes the bug for you?
> Thanks!
Tested-by: Shmulik Ladkani <shmulik.ladkani@gmail.com>
prev parent reply other threads:[~2019-08-28 7:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 10:57 [REGRESSION] netfilter: conntrack: Unable to change conntrack accounting of a net namespace via 'nf_conntrack_acct' sysfs Shmulik Ladkani
2019-08-27 11:18 ` Florian Westphal
2019-08-27 11:24 ` [PATCH nf] netfilter: conntrack: make sysctls per-namespace again Florian Westphal
2019-08-27 11:49 ` Shmulik Ladkani
2019-08-27 15:45 ` Pablo Neira Ayuso
2019-08-28 7:40 ` Shmulik Ladkani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828104030.134f38ec@pixies \
--to=shmulik.ladkani@gmail.com \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.