From: Leon Romanovsky <leon@kernel.org>
To: Bernard Metzler <bmt@zurich.ibm.com>
Cc: linux-rdma@vger.kernel.org, bvanassche@acm.org, jgg@ziepe.ca,
dledford@redhat.com
Subject: Re: [PATCH v3] RDMA/siw: Fix IPv6 addr_list locking
Date: Wed, 28 Aug 2019 13:47:38 +0300 [thread overview]
Message-ID: <20190828104738.GF4725@mtr-leonro.mtl.com> (raw)
In-Reply-To: <20190828093841.21993-1-bmt@zurich.ibm.com>
On Wed, Aug 28, 2019 at 11:38:41AM +0200, Bernard Metzler wrote:
> Walking the address list of an inet6_dev requires
> appropriate locking. Since the called function
> siw_listen_address() may sleep, we have to use
> rtnl_lock() instead of read_lock_bh().
>
> Also introduces sanity checks if we got a device
> from in_dev_get() or in6_dev_get().
>
> Changes from v2:
> - Use plain version of list_for_each_entry
> in exchange of list_for_each_entry_rcu.
>
> Changes from v1:
> - Remove rcu_read_lock()/_unlock().
> - Add check for IFA_F_TENTATIVE and
> IFA_F_DEPRECATED flags.
You need to add changelogs after "---" line, they will be trimmed
automatically while applying to git.
Latest example:
https://lore.kernel.org/linux-rdma/26ae8c4006cb31ee8c26fb821451d43732c7a35a.camel@redhat.com/T/#m75d9725823fd3f437298528c427dcfc3a0fe9050
Thanks
next prev parent reply other threads:[~2019-08-28 10:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 9:38 [PATCH v3] RDMA/siw: Fix IPv6 addr_list locking Bernard Metzler
2019-08-28 10:47 ` Leon Romanovsky [this message]
2019-08-28 12:59 ` Bernard Metzler
-- strict thread matches above, loose matches on Subject: below --
2019-08-28 13:03 Bernard Metzler
2019-08-28 14:38 ` Doug Ledford
2019-08-27 22:07 Bernard Metzler
2019-08-28 5:02 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828104738.GF4725@mtr-leonro.mtl.com \
--to=leon@kernel.org \
--cc=bmt@zurich.ibm.com \
--cc=bvanassche@acm.org \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.