From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 828C2C3A5A6 for ; Wed, 28 Aug 2019 18:01:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 599D722DA7 for ; Wed, 28 Aug 2019 18:01:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ASkY1rUl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726763AbfH1SBN (ORCPT ); Wed, 28 Aug 2019 14:01:13 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:34845 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726619AbfH1SBM (ORCPT ); Wed, 28 Aug 2019 14:01:12 -0400 Received: by mail-pg1-f196.google.com with SMTP id n4so146710pgv.2 for ; Wed, 28 Aug 2019 11:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=BFJvddMVdRzlLg4JaQXTPKjXHEos9ALpLQhTxwQRgB0=; b=ASkY1rUlh5uPsHc6yy1UDllwaGq7eHHaqrx9mHH1JQk+Juc6hS4cevD9XTNCDZesbH Mmo9mFrqYcCia1Ti/2PSg9CY+Q8KpxUS8DMx9XHSfqZZ6kXEF39+pefIA2AvUzXJi4+i 2z/Sepk/beKs+aXtnAYFGTpIHKCQHRn848/5Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=BFJvddMVdRzlLg4JaQXTPKjXHEos9ALpLQhTxwQRgB0=; b=tf+O36Z4/6bT27yVyQt85S2bXVPb/hnL+6g6yw2qLskMgeBRocINzs75M8lG/Y2tZx JU3VkkVAS04DrrQO8BCHPCx5pSwiyKii7MhEUgOIIR5JZs4rqkCF9GHdeh+XdnDLfsvJ lvA0ecu/+crlQuSdoihSZjQ8WzhUXBI2pFdzoISyxa4i0zNUkvZhuVKZRGxFv68WsZs0 6AZPkXWJpOmCUUB7X+wO+7JDW4JSCtuYua5ewmU8ENdA8AGAOfF4I44ssu6FzN2UcT4t sTsvW7ThCJlNHVhrS81n70t/YOGeimn/EjCuJaisANNdeMbWxJkWDV3Lqq5vAbXoBy9R qsMA== X-Gm-Message-State: APjAAAV61LbtHDyV5aPhiqNvJZ8UoO/85INfhTXd4g3ZgrGh3ciMZhJV nmn7loraofiecU34q7HHMikCKQ== X-Google-Smtp-Source: APXvYqxl9ldGbN+Y6p7HIDBEFutfmUjTW+7dVVdP5QoMG/5a9Fx5qHPh4AtBUYcTgv24Hatkm1LSYw== X-Received: by 2002:a17:90a:6581:: with SMTP id k1mr5476919pjj.47.1567015272079; Wed, 28 Aug 2019 11:01:12 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z4sm3347892pfg.166.2019.08.28.11.01.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 11:01:11 -0700 (PDT) Date: Wed, 28 Aug 2019 11:01:10 -0700 From: Kees Cook To: Andy Lutomirski Cc: David Abdurachmanov , Paul Walmsley , Palmer Dabbelt , Albert Ou , Oleg Nesterov , Will Drewry , Shuah Khan , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , David Abdurachmanov , Thomas Gleixner , Allison Randal , Alexios Zavras , Anup Patel , Vincent Chen , Alan Kao , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, me@carlosedp.com Subject: Re: [PATCH v2] riscv: add support for SECCOMP and SECCOMP_FILTER Message-ID: <201908281100.D78277FD@keescook> References: <20190822205533.4877-1-david.abdurachmanov@sifive.com> <201908251451.73C6812E8@keescook> <419CB0D1-E51C-49D5-9745-7771C863462F@amacapital.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <419CB0D1-E51C-49D5-9745-7771C863462F@amacapital.net> Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, Aug 28, 2019 at 10:52:05AM -0700, Andy Lutomirski wrote: > > > > On Aug 25, 2019, at 2:59 PM, Kees Cook wrote: > > > >> On Thu, Aug 22, 2019 at 01:55:22PM -0700, David Abdurachmanov wrote: > >> This patch was extensively tested on Fedora/RISCV (applied by default on > >> top of 5.2-rc7 kernel for <2 months). The patch was also tested with 5.3-rc > >> on QEMU and SiFive Unleashed board. > > > > Oops, I see the mention of QEMU here. Where's the best place to find > > instructions on creating a qemu riscv image/environment? > > I don’t suppose one of you riscv folks would like to contribute riscv support to virtme? virtme-run —arch=riscv would be quite nice, and the total patch should be just a couple lines. Unfortunately, it helps a lot to understand the subtleties of booting the architecture to write those couple lines :) As it turns out, this is where I'm stuck. All the instructions I can find are about booting a kernel off a disk image. :( -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97374C3A5A1 for ; Wed, 28 Aug 2019 18:01:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69B7722DA7 for ; Wed, 28 Aug 2019 18:01:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="s+ChZsVQ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ASkY1rUl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69B7722DA7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y6AM+zgFhCO06HgN9jhmzkk4hJvNjv0tcqJXkgwJPy4=; b=s+ChZsVQFNUAwV mHC5chuagD6LJ72cGT8Q6ilGLliIjZxv5xGILq3KdG6mcZxWPfUUCbiO88cb3MXOuyQCwNrGZMvaT YPW17Ng8RecyxnokCjIO/yAix/TGUNBgf+YOQBWAJ0O4sekGTCdn/wqV0w9h8Eyxj31o6PkQ2WM0k n0WFOxme+nw9UefAbYXArdA/tzV/KvKMbSh9xzBlz9s5RSMRKoYzrvaYPe594MneRWzVh6vcEgg5e 1EpqtsoplC21OrPu1cHt9Du2TDCDN2FNk0QUHyybJADxlz1FEnn2+5E1ZGwCNtDKt2ZCxEz56L6L2 iBHV9n7XdTr1+plt8s2A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i32G1-0002l4-By; Wed, 28 Aug 2019 18:01:21 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i32Fu-0002jn-Kk for linux-riscv@lists.infradead.org; Wed, 28 Aug 2019 18:01:19 +0000 Received: by mail-pf1-x444.google.com with SMTP id w26so265774pfq.12 for ; Wed, 28 Aug 2019 11:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=BFJvddMVdRzlLg4JaQXTPKjXHEos9ALpLQhTxwQRgB0=; b=ASkY1rUlh5uPsHc6yy1UDllwaGq7eHHaqrx9mHH1JQk+Juc6hS4cevD9XTNCDZesbH Mmo9mFrqYcCia1Ti/2PSg9CY+Q8KpxUS8DMx9XHSfqZZ6kXEF39+pefIA2AvUzXJi4+i 2z/Sepk/beKs+aXtnAYFGTpIHKCQHRn848/5Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=BFJvddMVdRzlLg4JaQXTPKjXHEos9ALpLQhTxwQRgB0=; b=tFnONJ5tGmR55le4C7gNXfokugZ0Eyh6pgDSdGrCFqT+aH4bRoLs3EWM6BusVJ/6h1 4eveBS2adrK/IueUfB3JtqDoLD+6FXSqbuUzMWjscXP0DGDiOmWNQI92LNI8zZzMt2q6 GS5s31lyeZ5fJh/E82kQW+k8YTWNaOtbAxuWEYjhm72UN9kD/nQzdQtS9eVpsPn5SbMs DMrvWOlx+tY6DMwZyrt67T8wL3hDFnBBC0CLmFVXrmDNftWfR13yQ/e37bvQ09ecFX4v 05dxYbGWKi5TB9BY1m7mZbF9iZjjW5GpTvKeFYfQju+5gh4yH06FHKIEa2espuQTOynH uwtA== X-Gm-Message-State: APjAAAW6r/fzpOQ1nBeObyaCMa7Fyu7cm72GmcTttP3dJ5r02DnCo9Ew clNFNxmxX3u7MVKYe9068QCarA== X-Google-Smtp-Source: APXvYqxl9ldGbN+Y6p7HIDBEFutfmUjTW+7dVVdP5QoMG/5a9Fx5qHPh4AtBUYcTgv24Hatkm1LSYw== X-Received: by 2002:a17:90a:6581:: with SMTP id k1mr5476919pjj.47.1567015272079; Wed, 28 Aug 2019 11:01:12 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z4sm3347892pfg.166.2019.08.28.11.01.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 11:01:11 -0700 (PDT) Date: Wed, 28 Aug 2019 11:01:10 -0700 From: Kees Cook To: Andy Lutomirski Subject: Re: [PATCH v2] riscv: add support for SECCOMP and SECCOMP_FILTER Message-ID: <201908281100.D78277FD@keescook> References: <20190822205533.4877-1-david.abdurachmanov@sifive.com> <201908251451.73C6812E8@keescook> <419CB0D1-E51C-49D5-9745-7771C863462F@amacapital.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <419CB0D1-E51C-49D5-9745-7771C863462F@amacapital.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190828_110117_125046_531EBF8A X-CRM114-Status: GOOD ( 12.57 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Song Liu , Alan Kao , Palmer Dabbelt , Alexei Starovoitov , Oleg Nesterov , linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org, Shuah Khan , Daniel Borkmann , Yonghong Song , me@carlosedp.com, Albert Ou , Alexios Zavras , Paul Walmsley , Thomas Gleixner , Allison Randal , Will Drewry , David Abdurachmanov , David Abdurachmanov , netdev@vger.kernel.org, Anup Patel , linux-kernel@vger.kernel.org, Vincent Chen , bpf@vger.kernel.org, Martin KaFai Lau Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org T24gV2VkLCBBdWcgMjgsIDIwMTkgYXQgMTA6NTI6MDVBTSAtMDcwMCwgQW5keSBMdXRvbWlyc2tp IHdyb3RlOgo+IAo+IAo+ID4gT24gQXVnIDI1LCAyMDE5LCBhdCAyOjU5IFBNLCBLZWVzIENvb2sg PGtlZXNjb29rQGNocm9taXVtLm9yZz4gd3JvdGU6Cj4gPiAKPiA+PiBPbiBUaHUsIEF1ZyAyMiwg MjAxOSBhdCAwMTo1NToyMlBNIC0wNzAwLCBEYXZpZCBBYmR1cmFjaG1hbm92IHdyb3RlOgo+ID4+ IFRoaXMgcGF0Y2ggd2FzIGV4dGVuc2l2ZWx5IHRlc3RlZCBvbiBGZWRvcmEvUklTQ1YgKGFwcGxp ZWQgYnkgZGVmYXVsdCBvbgo+ID4+IHRvcCBvZiA1LjItcmM3IGtlcm5lbCBmb3IgPDIgbW9udGhz KS4gVGhlIHBhdGNoIHdhcyBhbHNvIHRlc3RlZCB3aXRoIDUuMy1yYwo+ID4+IG9uIFFFTVUgYW5k IFNpRml2ZSBVbmxlYXNoZWQgYm9hcmQuCj4gPiAKPiA+IE9vcHMsIEkgc2VlIHRoZSBtZW50aW9u IG9mIFFFTVUgaGVyZS4gV2hlcmUncyB0aGUgYmVzdCBwbGFjZSB0byBmaW5kCj4gPiBpbnN0cnVj dGlvbnMgb24gY3JlYXRpbmcgYSBxZW11IHJpc2N2IGltYWdlL2Vudmlyb25tZW50Pwo+IAo+IEkg ZG9u4oCZdCBzdXBwb3NlIG9uZSBvZiB5b3UgcmlzY3YgZm9sa3Mgd291bGQgbGlrZSB0byBjb250 cmlidXRlIHJpc2N2IHN1cHBvcnQgdG8gdmlydG1lPyAgdmlydG1lLXJ1biDigJRhcmNoPXJpc2N2 IHdvdWxkIGJlIHF1aXRlIG5pY2UsIGFuZCB0aGUgdG90YWwgcGF0Y2ggc2hvdWxkIGJlIGp1c3Qg YSBjb3VwbGUgbGluZXMuICBVbmZvcnR1bmF0ZWx5LCBpdCBoZWxwcyBhIGxvdCB0byB1bmRlcnN0 YW5kIHRoZSBzdWJ0bGV0aWVzIG9mIGJvb3RpbmcgdGhlIGFyY2hpdGVjdHVyZSB0byB3cml0ZSB0 aG9zZSBjb3VwbGUgbGluZXMgOikKCkFzIGl0IHR1cm5zIG91dCwgdGhpcyBpcyB3aGVyZSBJJ20g c3R1Y2suIEFsbCB0aGUgaW5zdHJ1Y3Rpb25zIEkgY2FuCmZpbmQgYXJlIGFib3V0IGJvb3Rpbmcg YSBrZXJuZWwgb2ZmIGEgZGlzayBpbWFnZS4gOigKCi0tIApLZWVzIENvb2sKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcg bGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK