All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	Ioana Ciornei <ioana.ciornei@nxp.com>
Subject: Re: [PATCH net-next v2 3/3] dpaa2-eth: Add pause frame support
Date: Wed, 28 Aug 2019 13:52:50 +0200	[thread overview]
Message-ID: <20190828115250.GA32178@lunn.ch> (raw)
In-Reply-To: <AM0PR04MB499496AC09FD7BE58AE7B9C394A30@AM0PR04MB4994.eurprd04.prod.outlook.com>

> Clearing the ASYM_PAUSE flag only means we tell the firmware we want
> both Rx and Tx pause to be enabled in the beginning. User can still set
> an asymmetric config (i.e. only Rx pause or only Tx pause to be enabled)
> if needed.
> 
> The truth table is like this:
> 
> PAUSE | ASYM_PAUSE | Rx pause | Tx pause
> ----------------------------------------
>   0   |     0      | disabled | disabled
>   0   |     1      | disabled | enabled
>   1   |     0      | enabled  | enabled
>   1   |     1      | enabled  | disabled

Hi Ioana

Ah, that is not intuitive. Please add a comment, and maybe this table
to the commit message.

Thanks
	Andrew

  reply	other threads:[~2019-08-28 11:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-27 14:15 [PATCH net-next v2 1/3] dpaa2-eth: Remove support for changing link settings Ioana Radulescu
2019-08-27 14:15 ` [PATCH net-next v2 2/3] dpaa2-eth: Use stored " Ioana Radulescu
2019-08-27 23:12   ` Andrew Lunn
2019-08-27 14:15 ` [PATCH net-next v2 3/3] dpaa2-eth: Add pause frame support Ioana Radulescu
2019-08-27 23:21   ` Andrew Lunn
2019-08-28  8:40     ` Ioana Ciocoi Radulescu
2019-08-28 11:52       ` Andrew Lunn [this message]
2019-08-28 13:31         ` Ioana Ciocoi Radulescu
2019-08-28 20:06         ` David Miller
2019-08-27 23:11 ` [PATCH net-next v2 1/3] dpaa2-eth: Remove support for changing link settings Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190828115250.GA32178@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=ioana.ciornei@nxp.com \
    --cc=netdev@vger.kernel.org \
    --cc=ruxandra.radulescu@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.