From: Vivek Goyal <vgoyal@redhat.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Miklos Szeredi <mszeredi@redhat.com>,
linux-kernel@vger.kernel.org, virtio-fs@redhat.com,
linux-fsdevel@vger.kernel.org
Subject: Re: [Virtio-fs] [PATCH 02/13] fuse: Use default_file_splice_read for direct IO
Date: Wed, 28 Aug 2019 08:27:49 -0400 [thread overview]
Message-ID: <20190828122749.GA912@redhat.com> (raw)
In-Reply-To: <CAJfpegu41FYEBfniEBPtujgLW4nC+w6_6VG2EmNi=kC8ZeNFtA@mail.gmail.com>
On Wed, Aug 28, 2019 at 09:45:28AM +0200, Miklos Szeredi wrote:
> On Wed, Aug 21, 2019 at 7:38 PM Vivek Goyal <vgoyal@redhat.com> wrote:
> >
> > From: Miklos Szeredi <mszeredi@redhat.com>
>
> Nice patch, except I have no idea why I did this. Splice with
> FOPEN_DIRECT_IO seems to work fine without it.
I don't know either. I took it because it was there in one of the branches
you were doing development on.
>
> Anyway, I'll just drop this, unless someone has an idea why it is
> actually needed.
Sure, drop this patch. If need be, we can dig it up later.
Thanks
Vivek
WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
virtio-fs@redhat.com, Stefan Hajnoczi <stefanha@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Miklos Szeredi <mszeredi@redhat.com>
Subject: Re: [PATCH 02/13] fuse: Use default_file_splice_read for direct IO
Date: Wed, 28 Aug 2019 08:27:49 -0400 [thread overview]
Message-ID: <20190828122749.GA912@redhat.com> (raw)
In-Reply-To: <CAJfpegu41FYEBfniEBPtujgLW4nC+w6_6VG2EmNi=kC8ZeNFtA@mail.gmail.com>
On Wed, Aug 28, 2019 at 09:45:28AM +0200, Miklos Szeredi wrote:
> On Wed, Aug 21, 2019 at 7:38 PM Vivek Goyal <vgoyal@redhat.com> wrote:
> >
> > From: Miklos Szeredi <mszeredi@redhat.com>
>
> Nice patch, except I have no idea why I did this. Splice with
> FOPEN_DIRECT_IO seems to work fine without it.
I don't know either. I took it because it was there in one of the branches
you were doing development on.
>
> Anyway, I'll just drop this, unless someone has an idea why it is
> actually needed.
Sure, drop this patch. If need be, we can dig it up later.
Thanks
Vivek
next prev parent reply other threads:[~2019-08-28 12:27 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 17:37 [Virtio-fs] [PATCH v3 00/13] virtio-fs: shared file system for virtual machines Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-21 17:37 ` [Virtio-fs] [PATCH 01/13] fuse: delete dentry if timeout is zero Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-21 17:37 ` [Virtio-fs] [PATCH 02/13] fuse: Use default_file_splice_read for direct IO Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-28 7:45 ` [Virtio-fs] " Miklos Szeredi
2019-08-28 7:45 ` Miklos Szeredi
2019-08-28 12:27 ` Vivek Goyal [this message]
2019-08-28 12:27 ` Vivek Goyal
2019-08-21 17:37 ` [Virtio-fs] [PATCH 03/13] fuse: export fuse_end_request() Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-21 17:37 ` [Virtio-fs] [PATCH 04/13] fuse: export fuse_len_args() Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-21 17:37 ` [Virtio-fs] [PATCH 05/13] fuse: Export fuse_send_init_request() Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-21 17:37 ` [Virtio-fs] [PATCH 06/13] fuse: export fuse_get_unique() Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-21 17:37 ` [Virtio-fs] [PATCH 07/13] Export fuse_dequeue_forget() function Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-21 17:37 ` [Virtio-fs] [PATCH 08/13] fuse: extract fuse_fill_super_common() Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-21 17:37 ` [Virtio-fs] [PATCH 09/13] fuse: add fuse_iqueue_ops callbacks Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-21 17:37 ` [Virtio-fs] [PATCH 10/13] fuse: Separate fuse device allocation and installation in fuse_conn Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-21 17:37 ` [Virtio-fs] [PATCH 11/13] virtio_fs: add skeleton virtio_fs.ko module Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-21 17:37 ` [Virtio-fs] [PATCH 12/13] virtio-fs: Do not provide abort interface in fusectl Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-21 17:37 ` [Virtio-fs] [PATCH 13/13] init/do_mounts.c: add virtio_fs root fs support Vivek Goyal
2019-08-21 17:37 ` Vivek Goyal
2019-08-29 9:28 ` [Virtio-fs] [PATCH v3 00/13] virtio-fs: shared file system for virtual machines Miklos Szeredi
2019-08-29 9:28 ` Miklos Szeredi
2019-08-29 11:58 ` [Virtio-fs] " Vivek Goyal
2019-08-29 11:58 ` Vivek Goyal
2019-08-29 12:35 ` [Virtio-fs] " Stefan Hajnoczi
2019-08-29 12:35 ` Stefan Hajnoczi
2019-08-29 13:29 ` [Virtio-fs] " Vivek Goyal
2019-08-29 13:29 ` Vivek Goyal
2019-08-29 13:41 ` [Virtio-fs] " Miklos Szeredi
2019-08-29 13:41 ` Miklos Szeredi
2019-08-29 14:31 ` [Virtio-fs] " Vivek Goyal
2019-08-29 14:31 ` Vivek Goyal
2019-08-29 14:47 ` [Virtio-fs] " Miklos Szeredi
2019-08-29 14:47 ` Miklos Szeredi
2019-08-29 16:01 ` [Virtio-fs] " Vivek Goyal
2019-08-29 16:01 ` Vivek Goyal
2019-08-31 5:46 ` [Virtio-fs] " Miklos Szeredi
2019-08-31 5:46 ` Miklos Szeredi
2019-09-03 8:05 ` [Virtio-fs] " Miklos Szeredi
2019-09-03 8:05 ` Miklos Szeredi
2019-09-03 8:31 ` [Virtio-fs] " Michael S. Tsirkin
2019-09-03 8:31 ` Michael S. Tsirkin
2019-09-03 9:17 ` [Virtio-fs] " Miklos Szeredi
2019-09-03 9:17 ` Miklos Szeredi
2019-09-04 15:54 ` Stefan Hajnoczi
2019-09-04 15:54 ` [Virtio-fs] " Stefan Hajnoczi
2019-09-04 15:54 ` Stefan Hajnoczi
2019-09-03 14:07 ` [Virtio-fs] " Vivek Goyal
2019-09-03 14:07 ` Vivek Goyal
2019-09-03 14:12 ` Michael S. Tsirkin
2019-09-03 14:12 ` [Virtio-fs] " Michael S. Tsirkin
2019-09-03 14:12 ` Michael S. Tsirkin
2019-09-03 14:18 ` Vivek Goyal
2019-09-03 14:18 ` [Virtio-fs] " Vivek Goyal
2019-09-03 14:18 ` Vivek Goyal
2019-09-03 17:15 ` Michael S. Tsirkin
2019-09-03 17:15 ` [Virtio-fs] " Michael S. Tsirkin
2019-09-03 17:15 ` Michael S. Tsirkin
2019-09-03 14:07 ` Vivek Goyal
2019-09-03 8:31 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828122749.GA912@redhat.com \
--to=vgoyal@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=mszeredi@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.