From: Jiri Olsa <jolsa@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Michael Petlan <mpetlan@redhat.com>
Subject: [PATCH 19/23] libperf: Add PERF_RECORD_HEADER_FEATURE 'struct feature_event' to perf/event.h
Date: Wed, 28 Aug 2019 15:57:13 +0200 [thread overview]
Message-ID: <20190828135717.7245-20-jolsa@kernel.org> (raw)
In-Reply-To: <20190828135717.7245-1-jolsa@kernel.org>
Move the PERF_RECORD_HEADER_FEATURE event definition to libperf's event.h.
In order to keep libperf simple, we switch 'u64/u32/u16/u8'
types used events to their generic '__u*' versions.
Link: http://lkml.kernel.org/n/tip-adohmimljqrbq2i3dxhhrpnp@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
tools/perf/builtin-report.c | 2 +-
tools/perf/lib/include/perf/event.h | 6 ++++++
tools/perf/util/event.h | 6 ------
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 318b0b95c14c..0d71f26a8a44 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -211,7 +211,7 @@ static int process_feature_event(struct perf_session *session,
return perf_event__process_feature(session, event);
if (event->feat.feat_id != HEADER_LAST_FEATURE) {
- pr_err("failed: wrong feature ID: %" PRIu64 "\n",
+ pr_err("failed: wrong feature ID: %" PRI_lu64 "\n",
event->feat.feat_id);
return -1;
}
diff --git a/tools/perf/lib/include/perf/event.h b/tools/perf/lib/include/perf/event.h
index 7600f53f6ad1..ed1c22e650e2 100644
--- a/tools/perf/lib/include/perf/event.h
+++ b/tools/perf/lib/include/perf/event.h
@@ -312,4 +312,10 @@ struct time_conv_event {
__u64 time_zero;
};
+struct feature_event {
+ struct perf_event_header header;
+ __u64 feat_id;
+ char data[];
+};
+
#endif /* __LIBPERF_EVENT_H */
diff --git a/tools/perf/util/event.h b/tools/perf/util/event.h
index d758485956b3..94777ee435c2 100644
--- a/tools/perf/util/event.h
+++ b/tools/perf/util/event.h
@@ -337,12 +337,6 @@ enum {
PERF_STAT_ROUND_TYPE__FINAL = 1,
};
-struct feature_event {
- struct perf_event_header header;
- u64 feat_id;
- char data[];
-};
-
struct compressed_event {
struct perf_event_header header;
char data[];
--
2.21.0
next prev parent reply other threads:[~2019-08-28 13:58 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 13:56 [PATCH 00/23] libperf: Add rest of events to perf/event.h Jiri Olsa
2019-08-28 13:56 ` [PATCH 01/23] libperf: Add PERF_RECORD_HEADER_ATTR 'struct attr_event' " Jiri Olsa
2019-08-29 19:01 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2019-08-28 13:56 ` [PATCH 02/23] libperf: Add PERF_RECORD_CPU_MAP 'struct cpu_map_event' " Jiri Olsa
2019-08-29 19:01 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2019-08-28 13:56 ` [PATCH 03/23] libperf: Add PERF_RECORD_EVENT_UPDATE 'struct event_update_event' " Jiri Olsa
2019-08-29 19:01 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2019-08-28 13:56 ` [PATCH 04/23] libperf: Add PERF_RECORD_HEADER_EVENT_TYPE 'struct event_type_event' " Jiri Olsa
2019-08-29 19:01 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2019-08-28 13:56 ` [PATCH 05/23] libperf: Add PERF_RECORD_HEADER_TRACING_DATA 'struct tracing_data_event' " Jiri Olsa
2019-08-29 19:01 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2019-08-28 13:57 ` [PATCH 06/23] libperf: Add PERF_RECORD_HEADER_BUILD_ID 'struct build_id_event' " Jiri Olsa
2019-08-29 19:01 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2019-08-28 13:57 ` [PATCH 07/23] libperf: Add PERF_RECORD_ID_INDEX 'struct id_index_event' " Jiri Olsa
2019-08-29 19:01 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2019-08-28 13:57 ` [PATCH 08/23] libperf: Add PERF_RECORD_AUXTRACE_INFO 'struct auxtrace_info_event' " Jiri Olsa
2019-08-29 19:01 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2019-08-28 13:57 ` [PATCH 09/23] libperf: Add PERF_RECORD_AUXTRACE 'struct auxtrace_event' " Jiri Olsa
2019-08-29 19:01 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2019-08-28 13:57 ` [PATCH 10/23] libperf: Add PERF_RECORD_AUXTRACE_ERROR 'struct auxtrace_error_event' " Jiri Olsa
2019-08-29 19:01 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2019-08-28 13:57 ` [PATCH 11/23] libperf: Add PERF_RECORD_AUX 'struct aux_event' " Jiri Olsa
2019-08-29 19:01 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2019-08-28 13:57 ` [PATCH 12/23] libperf: Add PERF_RECORD_ITRACE_START 'struct itrace_start_event' " Jiri Olsa
2019-08-29 19:01 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2019-08-28 13:57 ` [PATCH 13/23] libperf: Add PERF_RECORD_SWITCH 'struct context_switch_event' " Jiri Olsa
2019-08-29 19:01 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2019-08-28 13:57 ` [PATCH 14/23] libperf: Add PERF_RECORD_THREAD_MAP 'struct thread_map_event' " Jiri Olsa
2019-08-29 19:01 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2019-08-28 13:57 ` [PATCH 15/23] libperf: Add PERF_RECORD_STAT_CONFIG 'struct stat_config_event' " Jiri Olsa
2019-08-29 19:01 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2019-08-28 13:57 ` [PATCH 16/23] libperf: Add PERF_RECORD_STAT 'struct stat_event' " Jiri Olsa
2019-08-29 19:01 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2019-08-28 13:57 ` [PATCH 17/23] libperf: Add PERF_RECORD_STAT_ROUND 'struct stat_round_event' " Jiri Olsa
2019-08-29 19:01 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2019-08-28 13:57 ` [PATCH 18/23] libperf: Add PERF_RECORD_TIME_CONV 'struct time_conv_event' " Jiri Olsa
2019-08-29 19:01 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2019-08-28 13:57 ` Jiri Olsa [this message]
2019-08-29 19:02 ` [tip: perf/core] libperf: Add PERF_RECORD_HEADER_FEATURE 'struct feature_event' " tip-bot2 for Jiri Olsa
2019-08-28 13:57 ` [PATCH 20/23] libperf: Add PERF_RECORD_COMPRESSED 'struct compressed_event' " Jiri Olsa
2019-08-29 19:02 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2019-08-28 13:57 ` [PATCH 21/23] libperf: Add 'union perf_event' " Jiri Olsa
2019-08-29 19:02 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2019-08-28 13:57 ` [PATCH 22/23] libperf: Rename the PERF_RECORD_ structs to have a "perf" prefix Jiri Olsa
2019-08-29 19:02 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2019-08-28 13:57 ` [PATCH 23/23] libperf: Move 'enum perf_user_event_type' to perf/event.h Jiri Olsa
2019-08-29 19:02 ` [tip: perf/core] " tip-bot2 for Jiri Olsa
2019-08-28 18:29 ` [PATCH 00/23] libperf: Add rest of events " Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828135717.7245-20-jolsa@kernel.org \
--to=jolsa@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpetlan@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.