From: Vladimir Oltean <olteanv@gmail.com>
To: linux@armlinux.org.uk, andrew@lunn.ch, f.fainelli@gmail.com,
asolokha@kb.kras.ru
Cc: netdev@vger.kernel.org, Vladimir Oltean <olteanv@gmail.com>
Subject: [RFC PATCH 0/1] Fix PHYLINK handling of ethtool ksettings with no PHY
Date: Wed, 28 Aug 2019 17:58:01 +0300 [thread overview]
Message-ID: <20190828145802.3609-1-olteanv@gmail.com> (raw)
Logically speaking, this patch pertains to the "Fix issues in tc-taprio
and tc-cbs" series at:
https://patchwork.ozlabs.org/project/netdev/list/?series=127821&state=*
The reason why I did not submit this patch together with those is that I
don't know whether the error condition can happen in current mainline
Linux at the moment. I am running Arseny's RFC patch "gianfar: convert
to phylink" and have found that __ethtool_get_link_ksettings returns a
speed of 0 instead of SPEED_UNKNOWN when there is no PHY connected.
Gianfar has carried this oddity over from its PHYLIB days, where it
connects "late" to the PHY. I am not sure whether PHYLINK, gianfar, or
both, need to be changed. Comments welcome.
Vladimir Oltean (1):
phylink: Set speed to SPEED_UNKNOWN when there is no PHY connected
drivers/net/phy/phylink.c | 1 +
1 file changed, 1 insertion(+)
--
2.17.1
next reply other threads:[~2019-08-28 14:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 14:58 Vladimir Oltean [this message]
2019-08-28 14:58 ` [RFC PATCH 1/1] phylink: Set speed to SPEED_UNKNOWN when there is no PHY connected Vladimir Oltean
2019-08-28 17:14 ` Russell King - ARM Linux admin
2019-08-29 9:34 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828145802.3609-1-olteanv@gmail.com \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=asolokha@kb.kras.ru \
--cc=f.fainelli@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.