From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Saranya Gopal <saranya.gopal@intel.com>
Cc: hdegoede@redhat.com, gregkh@linuxfoundation.org,
mathias.nyman@intel.com, linux-usb@vger.kernel.org,
Balaji Manoharan <m.balaji@intel.com>
Subject: Re: [PATCH v2 2/2] usb: roles: intel: Enable static DRD mode for role switch
Date: Wed, 28 Aug 2019 19:06:06 +0300 [thread overview]
Message-ID: <20190828160606.GC5486@kuha.fi.intel.com> (raw)
In-Reply-To: <1567004932-16967-3-git-send-email-saranya.gopal@intel.com>
On Wed, Aug 28, 2019 at 08:38:52PM +0530, Saranya Gopal wrote:
> Enable static DRD mode in Intel platforms which guarantees
> successful role switch all the time. This fixes issues like
> software role switch failure after cold boot and issue with
> role switch when USB 3.0 cable is used. But, do not enable
> static DRD mode for Cherrytrail devices which rely on firmware
> for role switch.
>
> Signed-off-by: Saranya Gopal <saranya.gopal@intel.com>
> Signed-off-by: Balaji Manoharan <m.balaji@intel.com>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Ditto. Can't use my SoB anymore.
Note. Since I only proposed using the device property, in this patch
you should also not use my "Suggested-by" tag. So I think it is OK to
use it in the first patch of this series, but not in this second patch.
thanks,
--
heikki
next prev parent reply other threads:[~2019-08-28 16:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-28 15:08 [PATCH v2 0/2] usb: roles: intel: Use static mode by default Saranya Gopal
2019-08-28 15:08 ` [PATCH v2 1/2] xhci-ext-caps.c: Add property to disable Intel SW switch Saranya Gopal
2019-08-28 16:00 ` Heikki Krogerus
2019-08-28 15:08 ` [PATCH v2 2/2] usb: roles: intel: Enable static DRD mode for role switch Saranya Gopal
2019-08-28 16:06 ` Heikki Krogerus [this message]
2019-08-28 16:58 ` Gopal, Saranya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828160606.GC5486@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-usb@vger.kernel.org \
--cc=m.balaji@intel.com \
--cc=mathias.nyman@intel.com \
--cc=saranya.gopal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.