From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2] drm/i915/tgl: Gen-12 display loses Yf tiling and legacy CCS support Date: Wed, 28 Aug 2019 19:25:28 +0300 Message-ID: <20190828162528.GH7482@intel.com> References: <20190827084516.6748-1-dhinakaran.pandiyan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id DACC289D81 for ; Wed, 28 Aug 2019 16:25:32 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190827084516.6748-1-dhinakaran.pandiyan@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dhinakaran Pandiyan Cc: intel-gfx@lists.freedesktop.org, Lucas De Marchi List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBBdWcgMjcsIDIwMTkgYXQgMDE6NDU6MTZBTSAtMDcwMCwgRGhpbmFrYXJhbiBQYW5k aXlhbiB3cm90ZToKPiBZZiB0aWxpbmcgd2FzIHJlbW92ZWQgaW4gZ2VuLTEyLCBzbyBkbyBub3Qg ZXhwb3NlIFlmIG1vZGlmaWVycyB0byB1c2VyCj4gc3BhY2UuIEdlbi0xMiBkaXNwbGF5IGFsc28g aXMgaW5jb21wYXRpYmxlIHdpdGggcHJlLWdlbjEyIFktdGlsZWQKPiBDQ1MsIHNvIGRvIG5vdCBl eHBvc2UgSTkxNV9GT1JNQVRfTU9EX1lfVElMRURfQ0NTLgo+IAo+IHYyOiBSZWJhc2UgdG8gY2Fy cnkgZm9yd2FyZCByZWNlbnRseSBhZGRlZCBnZW4xMSBmb3JtYXRzLgo+IAo+IENjOiBWaWxsZSBT eXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBTdGFuaXNsYXYg TGlzb3Zza2l5IDxzdGFuaXNsYXYubGlzb3Zza2l5QGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5 OiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNvbT4KPiBT aWduZWQtb2ZmLWJ5OiBMdWNhcyBEZSBNYXJjaGkgPGx1Y2FzLmRlbWFyY2hpQGludGVsLmNvbT4K ClJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9zcHJpdGUu YyB8IDg2ICsrKysrKysrKysrKysrKysrKystLQo+ICAxIGZpbGUgY2hhbmdlZCwgODAgaW5zZXJ0 aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvZGlzcGxheS9pbnRlbF9zcHJpdGUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3Bs YXkvaW50ZWxfc3ByaXRlLmMKPiBpbmRleCBkZWE2M2JlMTk2NGYuLjhjYTJmYmMyYWYxZCAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX3Nwcml0ZS5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9zcHJpdGUuYwo+IEBAIC0y MTU3LDYgKzIxNTcsMTMgQEAgc3RhdGljIGNvbnN0IHU2NCBza2xfcGxhbmVfZm9ybWF0X21vZGlm aWVyc19jY3NbXSA9IHsKPiAgCURSTV9GT1JNQVRfTU9EX0lOVkFMSUQKPiAgfTsKPiAgCj4gK3N0 YXRpYyBjb25zdCB1NjQgZ2VuMTJfcGxhbmVfZm9ybWF0X21vZGlmaWVyc19ub2Njc1tdID0gewo+ ICsJSTkxNV9GT1JNQVRfTU9EX1lfVElMRUQsCj4gKwlJOTE1X0ZPUk1BVF9NT0RfWF9USUxFRCwK PiArCURSTV9GT1JNQVRfTU9EX0xJTkVBUiwKPiArCURSTV9GT1JNQVRfTU9EX0lOVkFMSUQKPiAr fTsKPiArCj4gIHN0YXRpYyBib29sIGc0eF9zcHJpdGVfZm9ybWF0X21vZF9zdXBwb3J0ZWQoc3Ry dWN0IGRybV9wbGFuZSAqX3BsYW5lLAo+ICAJCQkJCSAgICB1MzIgZm9ybWF0LCB1NjQgbW9kaWZp ZXIpCj4gIHsKPiBAQCAtMjMwNSw2ICsyMzEyLDU1IEBAIHN0YXRpYyBib29sIHNrbF9wbGFuZV9m b3JtYXRfbW9kX3N1cHBvcnRlZChzdHJ1Y3QgZHJtX3BsYW5lICpfcGxhbmUsCj4gIAl9Cj4gIH0K PiAgCj4gK3N0YXRpYyBib29sIGdlbjEyX3BsYW5lX2Zvcm1hdF9tb2Rfc3VwcG9ydGVkKHN0cnVj dCBkcm1fcGxhbmUgKl9wbGFuZSwKPiArCQkJCQkgICAgIHUzMiBmb3JtYXQsIHU2NCBtb2RpZmll cikKPiArewo+ICsJc3dpdGNoIChtb2RpZmllcikgewo+ICsJY2FzZSBEUk1fRk9STUFUX01PRF9M SU5FQVI6Cj4gKwljYXNlIEk5MTVfRk9STUFUX01PRF9YX1RJTEVEOgo+ICsJY2FzZSBJOTE1X0ZP Uk1BVF9NT0RfWV9USUxFRDoKPiArCQlicmVhazsKPiArCWRlZmF1bHQ6Cj4gKwkJcmV0dXJuIGZh bHNlOwo+ICsJfQo+ICsKPiArCXN3aXRjaCAoZm9ybWF0KSB7Cj4gKwljYXNlIERSTV9GT1JNQVRf WFJHQjg4ODg6Cj4gKwljYXNlIERSTV9GT1JNQVRfWEJHUjg4ODg6Cj4gKwljYXNlIERSTV9GT1JN QVRfQVJHQjg4ODg6Cj4gKwljYXNlIERSTV9GT1JNQVRfQUJHUjg4ODg6Cj4gKwljYXNlIERSTV9G T1JNQVRfUkdCNTY1Ogo+ICsJY2FzZSBEUk1fRk9STUFUX1hSR0IyMTAxMDEwOgo+ICsJY2FzZSBE Uk1fRk9STUFUX1hCR1IyMTAxMDEwOgo+ICsJY2FzZSBEUk1fRk9STUFUX1lVWVY6Cj4gKwljYXNl IERSTV9GT1JNQVRfWVZZVToKPiArCWNhc2UgRFJNX0ZPUk1BVF9VWVZZOgo+ICsJY2FzZSBEUk1f Rk9STUFUX1ZZVVk6Cj4gKwljYXNlIERSTV9GT1JNQVRfTlYxMjoKPiArCWNhc2UgRFJNX0ZPUk1B VF9QMDEwOgo+ICsJY2FzZSBEUk1fRk9STUFUX1AwMTI6Cj4gKwljYXNlIERSTV9GT1JNQVRfUDAx NjoKPiArCWNhc2UgRFJNX0ZPUk1BVF9YVllVMjEwMTAxMDoKPiArCWNhc2UgRFJNX0ZPUk1BVF9D ODoKPiArCWNhc2UgRFJNX0ZPUk1BVF9YQkdSMTYxNjE2MTZGOgo+ICsJY2FzZSBEUk1fRk9STUFU X0FCR1IxNjE2MTYxNkY6Cj4gKwljYXNlIERSTV9GT1JNQVRfWFJHQjE2MTYxNjE2RjoKPiArCWNh c2UgRFJNX0ZPUk1BVF9BUkdCMTYxNjE2MTZGOgo+ICsJY2FzZSBEUk1fRk9STUFUX1kyMTA6Cj4g KwljYXNlIERSTV9GT1JNQVRfWTIxMjoKPiArCWNhc2UgRFJNX0ZPUk1BVF9ZMjE2Ogo+ICsJY2Fz ZSBEUk1fRk9STUFUX1hWWVUxMl8xNjE2MTYxNjoKPiArCWNhc2UgRFJNX0ZPUk1BVF9YVllVMTYx NjE2MTY6Cj4gKwkJaWYgKG1vZGlmaWVyID09IERSTV9GT1JNQVRfTU9EX0xJTkVBUiB8fAo+ICsJ CSAgICBtb2RpZmllciA9PSBJOTE1X0ZPUk1BVF9NT0RfWF9USUxFRCB8fAo+ICsJCSAgICBtb2Rp ZmllciA9PSBJOTE1X0ZPUk1BVF9NT0RfWV9USUxFRCkKPiArCQkJcmV0dXJuIHRydWU7Cj4gKwkJ LyogZmFsbCB0aHJvdWdoICovCj4gKwlkZWZhdWx0Ogo+ICsJCXJldHVybiBmYWxzZTsKPiArCX0K PiArfQo+ICsKPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fcGxhbmVfZnVuY3MgZzR4X3Nwcml0 ZV9mdW5jcyA9IHsKPiAgCS51cGRhdGVfcGxhbmUgPSBkcm1fYXRvbWljX2hlbHBlcl91cGRhdGVf cGxhbmUsCj4gIAkuZGlzYWJsZV9wbGFuZSA9IGRybV9hdG9taWNfaGVscGVyX2Rpc2FibGVfcGxh bmUsCj4gQEAgLTIzNDEsNiArMjM5NywxNSBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9wbGFu ZV9mdW5jcyBza2xfcGxhbmVfZnVuY3MgPSB7Cj4gIAkuZm9ybWF0X21vZF9zdXBwb3J0ZWQgPSBz a2xfcGxhbmVfZm9ybWF0X21vZF9zdXBwb3J0ZWQsCj4gIH07Cj4gIAo+ICtzdGF0aWMgY29uc3Qg c3RydWN0IGRybV9wbGFuZV9mdW5jcyBnZW4xMl9wbGFuZV9mdW5jcyA9IHsKPiArCS51cGRhdGVf cGxhbmUgPSBkcm1fYXRvbWljX2hlbHBlcl91cGRhdGVfcGxhbmUsCj4gKwkuZGlzYWJsZV9wbGFu ZSA9IGRybV9hdG9taWNfaGVscGVyX2Rpc2FibGVfcGxhbmUsCj4gKwkuZGVzdHJveSA9IGludGVs X3BsYW5lX2Rlc3Ryb3ksCj4gKwkuYXRvbWljX2R1cGxpY2F0ZV9zdGF0ZSA9IGludGVsX3BsYW5l X2R1cGxpY2F0ZV9zdGF0ZSwKPiArCS5hdG9taWNfZGVzdHJveV9zdGF0ZSA9IGludGVsX3BsYW5l X2Rlc3Ryb3lfc3RhdGUsCj4gKwkuZm9ybWF0X21vZF9zdXBwb3J0ZWQgPSBnZW4xMl9wbGFuZV9m b3JtYXRfbW9kX3N1cHBvcnRlZCwKPiArfTsKPiArCj4gIHN0YXRpYyBib29sIHNrbF9wbGFuZV9o YXNfZmJjKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQkJICAgICAgZW51 bSBwaXBlIHBpcGUsIGVudW0gcGxhbmVfaWQgcGxhbmVfaWQpCj4gIHsKPiBAQCAtMjQyOSw2ICsy NDk0LDcgQEAgc3RydWN0IGludGVsX3BsYW5lICoKPiAgc2tsX3VuaXZlcnNhbF9wbGFuZV9jcmVh dGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJCQkgICBlbnVtIHBpcGUg cGlwZSwgZW51bSBwbGFuZV9pZCBwbGFuZV9pZCkKPiAgewo+ICsJc3RhdGljIGNvbnN0IHN0cnVj dCBkcm1fcGxhbmVfZnVuY3MgKnBsYW5lX2Z1bmNzOwo+ICAJc3RydWN0IGludGVsX3BsYW5lICpw bGFuZTsKPiAgCWVudW0gZHJtX3BsYW5lX3R5cGUgcGxhbmVfdHlwZTsKPiAgCXVuc2lnbmVkIGlu dCBzdXBwb3J0ZWRfcm90YXRpb25zOwo+IEBAIC0yNDcxLDExICsyNTM3LDE5IEBAIHNrbF91bml2 ZXJzYWxfcGxhbmVfY3JlYXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAg CQlmb3JtYXRzID0gc2tsX2dldF9wbGFuZV9mb3JtYXRzKGRldl9wcml2LCBwaXBlLAo+ICAJCQkJ CQlwbGFuZV9pZCwgJm51bV9mb3JtYXRzKTsKPiAgCj4gLQlwbGFuZS0+aGFzX2NjcyA9IHNrbF9w bGFuZV9oYXNfY2NzKGRldl9wcml2LCBwaXBlLCBwbGFuZV9pZCk7Cj4gLQlpZiAocGxhbmUtPmhh c19jY3MpCj4gLQkJbW9kaWZpZXJzID0gc2tsX3BsYW5lX2Zvcm1hdF9tb2RpZmllcnNfY2NzOwo+ IC0JZWxzZQo+IC0JCW1vZGlmaWVycyA9IHNrbF9wbGFuZV9mb3JtYXRfbW9kaWZpZXJzX25vY2Nz Owo+ICsJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTIpIHsKPiArCQkvKiBUT0RPOiBJbXBs ZW1lbnQgc3VwcG9ydCBmb3IgZ2VuLTEyIENDUyBtb2RpZmllcnMgKi8KPiArCQlwbGFuZS0+aGFz X2NjcyA9IGZhbHNlOwo+ICsJCW1vZGlmaWVycyA9IGdlbjEyX3BsYW5lX2Zvcm1hdF9tb2RpZmll cnNfbm9jY3M7Cj4gKwkJcGxhbmVfZnVuY3MgPSAmZ2VuMTJfcGxhbmVfZnVuY3M7Cj4gKwl9IGVs c2Ugewo+ICsJCXBsYW5lLT5oYXNfY2NzID0gc2tsX3BsYW5lX2hhc19jY3MoZGV2X3ByaXYsIHBp cGUsIHBsYW5lX2lkKTsKPiArCQlpZiAocGxhbmUtPmhhc19jY3MpCj4gKwkJCW1vZGlmaWVycyA9 IHNrbF9wbGFuZV9mb3JtYXRfbW9kaWZpZXJzX2NjczsKPiArCQllbHNlCj4gKwkJCW1vZGlmaWVy cyA9IHNrbF9wbGFuZV9mb3JtYXRfbW9kaWZpZXJzX25vY2NzOwo+ICsJCXBsYW5lX2Z1bmNzID0g JnNrbF9wbGFuZV9mdW5jczsKPiArCX0KPiAgCj4gIAlpZiAocGxhbmVfaWQgPT0gUExBTkVfUFJJ TUFSWSkKPiAgCQlwbGFuZV90eXBlID0gRFJNX1BMQU5FX1RZUEVfUFJJTUFSWTsKPiBAQCAtMjQ4 NSw3ICsyNTU5LDcgQEAgc2tsX3VuaXZlcnNhbF9wbGFuZV9jcmVhdGUoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJcG9zc2libGVfY3J0Y3MgPSBCSVQocGlwZSk7Cj4gIAo+ ICAJcmV0ID0gZHJtX3VuaXZlcnNhbF9wbGFuZV9pbml0KCZkZXZfcHJpdi0+ZHJtLCAmcGxhbmUt PmJhc2UsCj4gLQkJCQkgICAgICAgcG9zc2libGVfY3J0Y3MsICZza2xfcGxhbmVfZnVuY3MsCj4g KwkJCQkgICAgICAgcG9zc2libGVfY3J0Y3MsIHBsYW5lX2Z1bmNzLAo+ICAJCQkJICAgICAgIGZv cm1hdHMsIG51bV9mb3JtYXRzLCBtb2RpZmllcnMsCj4gIAkJCQkgICAgICAgcGxhbmVfdHlwZSwK PiAgCQkJCSAgICAgICAicGxhbmUgJWQlYyIsIHBsYW5lX2lkICsgMSwKPiAtLSAKPiAyLjE3LjEK Ci0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4