From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manasi Navare Subject: Re: [PATCH 2/2] drm/i915/display: Move the commit_tail() disable sequence to commit_modeset_disables() hook Date: Wed, 28 Aug 2019 10:09:28 -0700 Message-ID: <20190828170927.GA4922@intel.com> References: <20190827221735.29351-1-manasi.d.navare@intel.com> <20190827221735.29351-3-manasi.d.navare@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6BC2189CBC for ; Wed, 28 Aug 2019 17:07:49 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBBdWcgMjgsIDIwMTkgYXQgMDg6MzA6MjNBTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMjgtMDgtMjAxOSBvbSAwMDoxNyBzY2hyZWVmIE1hbmFzaSBOYXZhcmU6 Cj4gPiBDcmVhdGUgYSBuZXcgaG9vayBjb21taXRfbW9kZXNldF9kaXNhYmxlcygpIGNvbnNpc3Rl bnQgd2l0aCB0aGUgbmFtaW5nCj4gPiBpbiBkcm0gYXRvbWljIGhlbHBlcnMgYW5kIHNpbWlsYXIg dG8gdGhlIGNvbW1pdF9tb2Rlc2V0X2VuYWJsZXMoKSBob29rLgo+ID4gVGhpcyBoZWxwcyBiZXR0 ZXIgb3JnYW5pemUgdGhlIGRpc2FibGUgc2VxdWVuY2UgaW4gYXRvbWljX2NvbW1pdF90YWlsKCkK PiA+IGFuZCBtb3ZlIHRoYXQgdG8gdGhpcyBkaXNhYmxlIGhvb2suCj4gPgo+ID4gTm8gZnVuY3Rp b25hbCBjaGFuZ2UKPiA+Cj4gPiB2MzoKPiA+ICogUmViYXNlIChNYW5hc2kpCj4gPiB2MjoKPiA+ ICogQ3JlYXRlIGEgaGVscGVyIGZvciBvbGRfY3J0Y19zdGF0ZSBkaXNhYmxlcyAoTHVjYXMpCj4g Pgo+ID4gU3VnZ2VzdGVkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNv bT4KPiA+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29t Pgo+ID4gQ2M6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRl bC5jb20+Cj4gPiBDYzogTWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4KPiA+ IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+ID4gU2lnbmVkLW9mZi1i eTogTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJlQGludGVsLmNvbT4KPiA+IC0tLQo+ID4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheS5jIHwgOTQgKysrKysr KysrKysrKy0tLS0tLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICAgICAg ICAgICAgICB8ICAxICsKPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDYxIGluc2VydGlvbnMoKyksIDM0 IGRlbGV0aW9ucygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9k aXNwbGF5L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50 ZWxfZGlzcGxheS5jCj4gPiBpbmRleCAyM2M4YzdmNWM0N2EuLjdmMGFiMDEwMTU2OSAxMDA2NDQK PiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheS5jCj4g PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rpc3BsYXkuYwo+ID4g QEAgLTEzNzU4LDYgKzEzNzU4LDYxIEBAIHN0YXRpYyB2b2lkIGludGVsX3VwZGF0ZV9jcnRjKHN0 cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ID4gIAlpbnRlbF9maW5pc2hfY3J0Y19jb21taXQoc3Rh dGUsIGNydGMpOwo+ID4gIH0KPiA+ICAKPiA+ICtzdGF0aWMgdm9pZCBpbnRlbF9vbGRfY3J0Y19z dGF0ZV9kaXNhYmxlcyhzdHJ1Y3QgaW50ZWxfYXRvbWljX3N0YXRlICpzdGF0ZSwKPiA+ICsJCQkJ CSAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKm9sZF9jcnRjX3N0YXRlLAo+ID4gKwkJCQkJICBz dHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqbmV3X2NydGNfc3RhdGUsCj4gPiArCQkJCQkgIHN0cnVj dCBpbnRlbF9jcnRjICpjcnRjKQo+ID4gK3sKPiA+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2ID0gdG9faTkxNShzdGF0ZS0+YmFzZS5kZXYpOwo+ID4gKwo+ID4gKwlpbnRlbF9j cnRjX2Rpc2FibGVfcGxhbmVzKHN0YXRlLCBjcnRjKTsKPiA+ICsKPiA+ICsJLyoKPiA+ICsJICog V2UgbmVlZCB0byBkaXNhYmxlIHBpcGUgQ1JDIGJlZm9yZSBkaXNhYmxpbmcgdGhlIHBpcGUsCj4g PiArCSAqIG9yIHdlIHJhY2UgYWdhaW5zdCB2Ymxhbmsgb2ZmLgo+ID4gKwkgKi8KPiA+ICsJaW50 ZWxfY3J0Y19kaXNhYmxlX3BpcGVfY3JjKGNydGMpOwo+ID4gKwo+ID4gKwlkZXZfcHJpdi0+ZGlz cGxheS5jcnRjX2Rpc2FibGUob2xkX2NydGNfc3RhdGUsIHN0YXRlKTsKPiA+ICsJY3J0Yy0+YWN0 aXZlID0gZmFsc2U7Cj4gPiArCWludGVsX2ZiY19kaXNhYmxlKGNydGMpOwo+ID4gKwlpbnRlbF9k aXNhYmxlX3NoYXJlZF9kcGxsKG9sZF9jcnRjX3N0YXRlKTsKPiA+ICsKPiA+ICsJLyoKPiA+ICsJ ICogVW5kZXJydW5zIGRvbid0IGFsd2F5cyByYWlzZSBpbnRlcnJ1cHRzLAo+ID4gKwkgKiBzbyBj aGVjayBtYW51YWxseS4KPiA+ICsJICovCj4gPiArCWludGVsX2NoZWNrX2NwdV9maWZvX3VuZGVy cnVucyhkZXZfcHJpdik7Cj4gPiArCWludGVsX2NoZWNrX3BjaF9maWZvX3VuZGVycnVucyhkZXZf cHJpdik7Cj4gPiArCj4gPiArCS8qIEZJWE1FIHVuaWZ5IHRoaXMgZm9yIGFsbCBwbGF0Zm9ybXMg Ki8KPiA+ICsJaWYgKCFuZXdfY3J0Y19zdGF0ZS0+YmFzZS5hY3RpdmUgJiYKPiA+ICsJICAgICFI QVNfR01DSChkZXZfcHJpdikgJiYKPiA+ICsJICAgIGRldl9wcml2LT5kaXNwbGF5LmluaXRpYWxf d2F0ZXJtYXJrcykKPiA+ICsJCWRldl9wcml2LT5kaXNwbGF5LmluaXRpYWxfd2F0ZXJtYXJrcyhz dGF0ZSwKPiA+ICsJCQkJCQkgICAgIG5ld19jcnRjX3N0YXRlKTsKPiA+ICt9Cj4gPiArCj4gPiAr c3RhdGljIHZvaWQgaW50ZWxfY29tbWl0X21vZGVzZXRfZGlzYWJsZXMoc3RydWN0IGludGVsX2F0 b21pY19zdGF0ZSAqc3RhdGUpCj4gPiArewo+ID4gKwlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAq bmV3X2NydGNfc3RhdGUsICpvbGRfY3J0Y19zdGF0ZTsKPiA+ICsJc3RydWN0IGludGVsX2NydGMg KmNydGM7Cj4gPiArCWludCBpOwo+ID4gKwo+ID4gKwlmb3JfZWFjaF9vbGRuZXdfaW50ZWxfY3J0 Y19pbl9zdGF0ZShzdGF0ZSwgY3J0Yywgb2xkX2NydGNfc3RhdGUsIG5ld19jcnRjX3N0YXRlLCBp KSB7Cj4gPiArCQlpZiAoIW5lZWRzX21vZGVzZXQobmV3X2NydGNfc3RhdGUpKQo+ID4gKwkJCWNv bnRpbnVlOwo+ID4gKwo+ID4gKwkJaW50ZWxfcHJlX3BsYW5lX3VwZGF0ZShvbGRfY3J0Y19zdGF0 ZSwgbmV3X2NydGNfc3RhdGUpOwo+ID4gKwo+ID4gKwkJaWYgKG9sZF9jcnRjX3N0YXRlLT5iYXNl LmFjdGl2ZSkKPiA+ICsJCQlpbnRlbF9vbGRfY3J0Y19zdGF0ZV9kaXNhYmxlcyhzdGF0ZSwKPiA+ ICsJCQkJCQkgICAgICBvbGRfY3J0Y19zdGF0ZSwKPiA+ICsJCQkJCQkgICAgICBuZXdfY3J0Y19z dGF0ZSwKPiA+ICsJCQkJCQkgICAgICBjcnRjKTsKPiA+ICsJfQo+ID4gK30KPiA+ICsKPiA+ICBz dGF0aWMgdm9pZCBpbnRlbF9jb21taXRfbW9kZXNldF9lbmFibGVzKHN0cnVjdCBpbnRlbF9hdG9t aWNfc3RhdGUgKnN0YXRlKQo+ID4gIHsKPiA+ICAJc3RydWN0IGludGVsX2NydGMgKmNydGM7Cj4g PiBAQCAtMTM5MzgsNDIgKzEzOTkzLDEwIEBAIHN0YXRpYyB2b2lkIGludGVsX2F0b21pY19jb21t aXRfdGFpbChzdHJ1Y3QgaW50ZWxfYXRvbWljX3N0YXRlICpzdGF0ZSkKPiA+ICAJCQlwdXRfZG9t YWluc1tjcnRjLT5waXBlXSA9Cj4gPiAgCQkJCW1vZGVzZXRfZ2V0X2NydGNfcG93ZXJfZG9tYWlu cyhuZXdfY3J0Y19zdGF0ZSk7Cj4gPiAgCQl9Cj4gPiAtCj4gPiAtCQlpZiAoIW5lZWRzX21vZGVz ZXQobmV3X2NydGNfc3RhdGUpKQo+ID4gLQkJCWNvbnRpbnVlOwo+ID4gLQo+ID4gLQkJaW50ZWxf cHJlX3BsYW5lX3VwZGF0ZShvbGRfY3J0Y19zdGF0ZSwgbmV3X2NydGNfc3RhdGUpOwo+ID4gLQo+ ID4gLQkJaWYgKG9sZF9jcnRjX3N0YXRlLT5iYXNlLmFjdGl2ZSkgewo+ID4gLQkJCWludGVsX2Ny dGNfZGlzYWJsZV9wbGFuZXMoc3RhdGUsIGNydGMpOwo+ID4gLQo+ID4gLQkJCS8qCj4gPiAtCQkJ ICogV2UgbmVlZCB0byBkaXNhYmxlIHBpcGUgQ1JDIGJlZm9yZSBkaXNhYmxpbmcgdGhlIHBpcGUs Cj4gPiAtCQkJICogb3Igd2UgcmFjZSBhZ2FpbnN0IHZibGFuayBvZmYuCj4gPiAtCQkJICovCj4g PiAtCQkJaW50ZWxfY3J0Y19kaXNhYmxlX3BpcGVfY3JjKGNydGMpOwo+ID4gLQo+ID4gLQkJCWRl dl9wcml2LT5kaXNwbGF5LmNydGNfZGlzYWJsZShvbGRfY3J0Y19zdGF0ZSwgc3RhdGUpOwo+ID4g LQkJCWNydGMtPmFjdGl2ZSA9IGZhbHNlOwo+ID4gLQkJCWludGVsX2ZiY19kaXNhYmxlKGNydGMp Owo+ID4gLQkJCWludGVsX2Rpc2FibGVfc2hhcmVkX2RwbGwob2xkX2NydGNfc3RhdGUpOwo+ID4g LQo+ID4gLQkJCS8qCj4gPiAtCQkJICogVW5kZXJydW5zIGRvbid0IGFsd2F5cyByYWlzZQo+ID4g LQkJCSAqIGludGVycnVwdHMsIHNvIGNoZWNrIG1hbnVhbGx5Lgo+ID4gLQkJCSAqLwo+ID4gLQkJ CWludGVsX2NoZWNrX2NwdV9maWZvX3VuZGVycnVucyhkZXZfcHJpdik7Cj4gPiAtCQkJaW50ZWxf Y2hlY2tfcGNoX2ZpZm9fdW5kZXJydW5zKGRldl9wcml2KTsKPiA+IC0KPiA+IC0JCQkvKiBGSVhN RSB1bmlmeSB0aGlzIGZvciBhbGwgcGxhdGZvcm1zICovCj4gPiAtCQkJaWYgKCFuZXdfY3J0Y19z dGF0ZS0+YmFzZS5hY3RpdmUgJiYKPiA+IC0JCQkgICAgIUhBU19HTUNIKGRldl9wcml2KSAmJgo+ ID4gLQkJCSAgICBkZXZfcHJpdi0+ZGlzcGxheS5pbml0aWFsX3dhdGVybWFya3MpCj4gPiAtCQkJ CWRldl9wcml2LT5kaXNwbGF5LmluaXRpYWxfd2F0ZXJtYXJrcyhzdGF0ZSwKPiA+IC0JCQkJCQkJ CSAgICAgbmV3X2NydGNfc3RhdGUpOwo+ID4gLQkJfQo+ID4gIAl9Cj4gPiAgCj4gPiArCWRldl9w cml2LT5kaXNwbGF5LmNvbW1pdF9tb2Rlc2V0X2Rpc2FibGVzKHN0YXRlKTsKPiA+ICsKPiA+ICAJ LyogRklYTUU6IEV2ZW50dWFsbHkgZ2V0IHJpZCBvZiBvdXIgY3J0Yy0+Y29uZmlnIHBvaW50ZXIg Ki8KPiA+ICAJZm9yX2VhY2hfbmV3X2ludGVsX2NydGNfaW5fc3RhdGUoc3RhdGUsIGNydGMsIG5l d19jcnRjX3N0YXRlLCBpKQo+ID4gIAkJY3J0Yy0+Y29uZmlnID0gbmV3X2NydGNfc3RhdGU7Cj4g PiBAQCAtMTU5MjksNiArMTU5NTIsOSBAQCB2b2lkIGludGVsX2luaXRfZGlzcGxheV9ob29rcyhz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiAgCQlkZXZfcHJpdi0+ZGlzcGxh eS5jb21taXRfbW9kZXNldF9lbmFibGVzID0gc2tsX2NvbW1pdF9tb2Rlc2V0X2VuYWJsZXM7Cj4g PiAgCWVsc2UKPiA+ICAJCWRldl9wcml2LT5kaXNwbGF5LmNvbW1pdF9tb2Rlc2V0X2VuYWJsZXMg PSBpbnRlbF9jb21taXRfbW9kZXNldF9lbmFibGVzOwo+ID4gKwo+ID4gKwlkZXZfcHJpdi0+ZGlz cGxheS5jb21taXRfbW9kZXNldF9kaXNhYmxlcyA9IGludGVsX2NvbW1pdF9tb2Rlc2V0X2Rpc2Fi bGVzOwo+ID4gKwo+ID4gIH0KPiA+ICAKPiA+ICBzdGF0aWMgaTkxNV9yZWdfdCBpOTE1X3ZnYWNu dHJsX3JlZyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZHJ2LmgKPiA+IGluZGV4IDc1YTQyZThkZjY3ZS4uZGI3NDgwODMxZTUyIDEwMDY0NAo+ ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ID4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ID4gQEAgLTI4OSw2ICsyODksNyBAQCBzdHJ1Y3Qg ZHJtX2k5MTVfZGlzcGxheV9mdW5jcyB7Cj4gPiAgCXZvaWQgKCpjcnRjX2Rpc2FibGUpKHN0cnVj dCBpbnRlbF9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZSwKPiA+ICAJCQkgICAgIHN0cnVjdCBp bnRlbF9hdG9taWNfc3RhdGUgKm9sZF9zdGF0ZSk7Cj4gPiAgCXZvaWQgKCpjb21taXRfbW9kZXNl dF9lbmFibGVzKShzdHJ1Y3QgaW50ZWxfYXRvbWljX3N0YXRlICpzdGF0ZSk7Cj4gPiArCXZvaWQg KCpjb21taXRfbW9kZXNldF9kaXNhYmxlcykoc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqc3Rh dGUpOwo+ID4gIAl2b2lkICgqYXVkaW9fY29kZWNfZW5hYmxlKShzdHJ1Y3QgaW50ZWxfZW5jb2Rl ciAqZW5jb2RlciwKPiA+ICAJCQkJICAgY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNy dGNfc3RhdGUsCj4gPiAgCQkJCSAgIGNvbnN0IHN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICpj b25uX3N0YXRlKTsKPiAKPiBIZXksCj4gCj4gTmFjaywgdGhlcmUgaXMgbm8gbmVlZCB0byBzdGFy dCBpbnRyb2R1Y2luZyBhIHNwZWNpYWwgY2FzZSBoZXJlLiBUaGUgc2FtZSBlbmFibGUgYW5kIGRp c2FibGUgc2VxdWVuY2UgZm9yIGdlbjExIHdpbGwgc3RpbGwgd29yayBhbGwgdGhlIHdheSBiYWNr IHRvIGdlbjkgaWYgdHJhbnNjb2RlciBzeW5jIGlzIG5vdCB1c2VkLiA6KSBGb3IgZGlzYWJsZSBh bGwgdGhlIHdheSBiYWNrIHRvIGdlbjIuCj4gCgpTbyBqdXN0IHVzZSB0aGUgc2FtZSBmdW5jdGlv biBmb3IgYWxsIGdlbnMgYW5kIGRvIHNwZWNpYWwgaGFuZGlsaW5nIG9ubHkgaWYgdHJhbnNfcG9y dF9zeW5jX21vZGUoKSBpbiB0aGF0IHNhbWUgZnVuY3Rpb24/CgpEYW52ZXQgaGFkIHN1Z2dlc3Rl ZCBhZGRpbmcgYSBzZXBhcmF0ZSBob29rIGZvciBJQ0wgc2luY2UgdGhpcyBmZWF0dXJlIGlzIHN1 cHBvcnRlZCBmb3IgSUNMKyBhbmQgaGF2aW5nIGl0IGluIHNlcGFyYXRlIGhvb2sgYXZvaWRzIHBv c3NpYmlsaXR5Cm9mIHJlZ3Jlc3Npb25zLiBCdXQgaWYgeW91IHN0cm9uZ2x5IGZlZWwgYWdhaW5z dCBpdCBJIHdpbGwgbm90IGNyZWF0ZSBhbm90aGVyIGhvb2suCgo+IEl0IGNvdWxkIHN0aWxsIGJl IGJlbmVmaWNpYWwgdG8gbWFrZSB0aG9zZSBzZXBhcmF0ZSBmdW5jdGlvbnMsIGp1c3Qgbm8gZnVu Y3Rpb24gcG9pbnRlci4KClNvIHlvdSBtZWFuIG5vdCBjcmVhdGUgYSBuZXcgY29tbWl0X21vZGVz ZXRfZGlzYWJsZXMgaG9vaz8gSnVzdCBleHRyYWN0IHRoZSBpbnRlbF9vbGRfY3J0Y19zdGF0ZV9k aXNhYmxlcygpIGZyb20gYXRvbWljX2NvbW1pdF90YWlsKCk/CgpNYW5hc2kKCj4gCj4gaW50ZWxf b2xkX2NydGNfc3RhdGVfZGlzYWJsZXMoCj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeA==